Apple search ads weren't timing out on iPad during initialization. (#769)

Apple Search Ads weren't timing out on iPad which prevented Branch initialization. I added a 10 second timeout for search ads before initialization continues.

Author: E-B-Smith

Branch-SDK/Branch-SDK/Branch.m

@@ -39,6 +39,7 @@
 #import "NSString+Branch.h"
 #import "BNCSpotlightService.h"
 #import "../Fabric/FABKitProtocol.h" // Fabric
+#import <stdatomic.h>
 
 NSString * const BRANCH_FEATURE_TAG_SHARE = @"share";
 NSString * const BRANCH_FEATURE_TAG_REFERRAL = @"referral";
@@ -76,6 +77,14 @@
 #define CSSearchableItemActivityIdentifier @"kCSSearchableItemActivityIdentifier"
 #endif
 
+static inline dispatch_time_t BNCDispatchTimeFromSeconds(NSTimeInterval seconds) {
+    return dispatch_time(DISPATCH_TIME_NOW, seconds * NSEC_PER_SEC);
+}
+
+static inline void BNCAfterSecondsPerformBlock(NSTimeInterval seconds, dispatch_block_t block) {
+    dispatch_after(BNCDispatchTimeFromSeconds(seconds), dispatch_get_main_queue(), block);
+}
+
 #pragma mark - Load Categories
 
 void ForceCategoriesToLoad(void);
@@ -881,8 +890,12 @@ - (BOOL)checkAppleSearchAdsAttribution {
     self.preferenceHelper.checkedAppleSearchAdAttribution = YES;
     self.asyncRequestCount++;
 
+    _Atomic __block BOOL hasBeenCalled = NO;
     void (^__nullable completionBlock)(NSDictionary *attrDetails, NSError *error) =
       ^ void(NSDictionary *__nullable attrDetails, NSError *__nullable error) {
+        BOOL localHasBeenCalled = atomic_exchange(&hasBeenCalled, YES);
+        if (localHasBeenCalled) return;
+
         self.asyncRequestCount--;
 
         // If searchAdsDebugMode is on then force the result to a set value for testing:
@@ -929,6 +942,11 @@ - (BOOL)checkAppleSearchAdsAttribution {
         });
     };
 
+    // Set a expiration timer in case we don't get a call back (I'm looking at you, iPad):
+    BNCAfterSecondsPerformBlock(10.0, ^ {
+        completionBlock(nil, [NSError errorWithDomain:NSNetServicesErrorDomain code:NSNetServicesTimeoutError userInfo:nil]);
+    });
+
     ((void (*)(id, SEL, void (^ __nullable)(NSDictionary *__nullable attrDetails, NSError * __nullable error)))
         [sharedClientInstance methodForSelector:requestAttribution])
             (sharedClientInstance, requestAttribution, completionBlock);

Branch-TestBed/Branch-SDK-Tests/BNCTestCase.h

@@ -11,7 +11,7 @@
 #import "Branch.h"
 #import "NSString+Branch.h"
 
-static inline dispatch_time_t BNCDispatchTimeFromSeconds(NSTimeInterval seconds)	{
+static inline dispatch_time_t BNCDispatchTimeFromSeconds(NSTimeInterval seconds) {
 	return dispatch_time(DISPATCH_TIME_NOW, seconds * NSEC_PER_SEC);
 }