Skip to content

Commit 5e858be

Browse files
committed
SDK-562 add values to open/install
1 parent bf41ae9 commit 5e858be

File tree

3 files changed

+13
-9
lines changed

3 files changed

+13
-9
lines changed

Branch-SDK/Branch-SDK/BNCDeviceInfo.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,7 @@ - (NSDictionary *)v2dictionary {
171171
[dictionary bnc_safeSetObject:self.locale forKey:@"locale"];
172172
[dictionary bnc_safeSetObject:self.country forKey:@"country"];
173173
[dictionary bnc_safeSetObject:self.language forKey:@"language"];
174-
[dictionary bnc_safeSetObject:self.carrierName forKey:@"carrier_name"];
174+
[dictionary bnc_safeSetObject:self.carrierName forKey:@"device_carrier"];
175175
[dictionary bnc_safeSetObject:[self connectionType] forKey:@"connection_type"];
176176
[dictionary bnc_safeSetObject:[BNCUserAgentCollector instance].userAgent forKey:@"user_agent"];
177177

Branch-SDK/Branch-SDK/Networking/BNCServerInterface.m

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -919,19 +919,28 @@ - (void)updateDeviceInfoToMutableDictionary:(NSMutableDictionary *)dict {
919919

920920
[self safeSetValue:deviceInfo.osName forKey:BRANCH_REQUEST_KEY_OS onDict:dict];
921921
[self safeSetValue:deviceInfo.osVersion forKey:BRANCH_REQUEST_KEY_OS_VERSION onDict:dict];
922-
// environment
922+
[self safeSetValue:deviceInfo.osBuildVersion forKey:@"build" onDict:dict];
923+
[self safeSetValue:deviceInfo.extensionType forKey:@"environment" onDict:dict];
924+
[self safeSetValue:deviceInfo.locale forKey:@"locale" onDict:dict];
923925
[self safeSetValue:deviceInfo.country forKey:@"country" onDict:dict];
924926
[self safeSetValue:deviceInfo.language forKey:@"language" onDict:dict];
925927
[self safeSetValue:deviceInfo.brandName forKey:BRANCH_REQUEST_KEY_BRAND onDict:dict];
926-
// application version
927928
[self safeSetValue:deviceInfo.modelName forKey:BRANCH_REQUEST_KEY_MODEL onDict:dict];
928-
// screen dpi
929+
[self safeSetValue:deviceInfo.cpuType forKey:@"cpu_type" onDict:dict];
930+
[self safeSetValue:deviceInfo.screenScale forKey:@"screen_dpi" onDict:dict];
929931
[self safeSetValue:deviceInfo.screenHeight forKey:BRANCH_REQUEST_KEY_SCREEN_HEIGHT onDict:dict];
930932
[self safeSetValue:deviceInfo.screenWidth forKey:BRANCH_REQUEST_KEY_SCREEN_WIDTH onDict:dict];
933+
[self safeSetValue:deviceInfo.carrierName forKey:@"device_carrier" onDict:dict];
934+
931935
[self safeSetValue:[deviceInfo localIPAddress] forKey:@"local_ip" onDict:dict];
936+
[self safeSetValue:[deviceInfo connectionType] forKey:@"connection_type" onDict:dict];
932937
[self safeSetValue:[deviceInfo userAgentString] forKey:@"user_agent" onDict:dict];
933938

934939
[self safeSetValue:@(deviceInfo.isAdTrackingEnabled) forKey:BRANCH_REQUEST_KEY_AD_TRACKING_ENABLED onDict:dict];
940+
941+
[self safeSetValue:deviceInfo.applicationVersion forKey:@"app_version" onDict:dict];
942+
[self safeSetValue:deviceInfo.pluginName forKey:@"plugin_name" onDict:dict];
943+
[self safeSetValue:deviceInfo.pluginVersion forKey:@"plugin_version" onDict:dict];
935944
}
936945
}
937946

Branch-TestBed/Branch-TestBed.xcodeproj/xcshareddata/xcschemes/Branch-TestBed.xcscheme

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -77,11 +77,6 @@
7777
BlueprintName = "Branch-SDK-Tests"
7878
ReferencedContainer = "container:Branch-TestBed.xcodeproj">
7979
</BuildableReference>
80-
<SkippedTests>
81-
<Test
82-
Identifier = "BranchSDKFunctionalityTests">
83-
</Test>
84-
</SkippedTests>
8580
<DeviceAppData
8681
resolvedPath = "../Simulate-FirstRun.xcappdata">
8782
</DeviceAppData>

0 commit comments

Comments
 (0)