Skip to content

Commit 6628241

Browse files
authored
Added a rating field to the BUO (AIS-429). (#773)
1 parent 9f5566d commit 6628241

File tree

7 files changed

+21
-4
lines changed

7 files changed

+21
-4
lines changed

Branch-SDK/Branch-SDK/BranchUniversalObject.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -83,6 +83,7 @@ FOUNDATION_EXPORT BranchCondition _Nonnull BranchConditionRefurbished;
8383
@property (nonatomic, assign) double ratingAverage;
8484
@property (nonatomic, assign) NSInteger ratingCount;
8585
@property (nonatomic, assign) double ratingMax;
86+
@property (nonatomic, assign) double rating;
8687
@property (nonatomic, strong, nullable) NSString *addressStreet;
8788
@property (nonatomic, strong, nullable) NSString *addressCity;
8889
@property (nonatomic, strong, nullable) NSString *addressRegion;

Branch-SDK/Branch-SDK/BranchUniversalObject.m

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -88,6 +88,7 @@ - (NSDictionary*_Nonnull) dictionary {
8888
addDouble(ratingAverage, $rating_average);
8989
addInteger(ratingCount, $rating_count);
9090
addDouble(ratingMax, $rating_max);
91+
addDouble(rating, $rating);
9192
addString(addressStreet, $address_street);
9293
addString(addressCity, $address_city);
9394
addString(addressRegion, $address_region);
@@ -122,6 +123,7 @@ + (BranchContentMetadata*_Nonnull) contentMetadataWithDictionary:(NSDictionary*_
122123
addDouble(ratingAverage, $rating_average);
123124
addInteger(ratingCount, $rating_count);
124125
addDouble(ratingMax, $rating_max);
126+
addDouble(rating, $rating);
125127
addString(addressStreet, $address_street);
126128
addString(addressCity, $address_city);
127129
addString(addressRegion, $address_region);
@@ -684,6 +686,7 @@ + (BranchUniversalObject*_Nonnull) objectWithDictionary:(NSDictionary*_Null_unsp
684686
@"$rating_average",
685687
@"$rating_count",
686688
@"$rating_max",
689+
@"$rating",
687690
@"$address_street",
688691
@"$address_city",
689692
@"$address_region",

Branch-TestBed/Branch-SDK-Tests/Branch-SDK-Tests.strings

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,7 @@ Instance 0x132585f70 is of class 'DumpClass' of class 'NSObject':
8484
\"$rating_average\": 5,
8585
\"$rating_count\": 5,
8686
\"$rating_max\": 7,
87+
\"$rating\": 6,
8788
\"$condition\": \"FAIR\",
8889
\"$address_street\": \"Street_name1\",
8990
\"$address_city\": \"city1\",
@@ -158,6 +159,7 @@ Instance 0x132585f70 is of class 'DumpClass' of class 'NSObject':
158159
\"$rating_average\": 5,
159160
\"$rating_count\": 5,
160161
\"$rating_max\": 7,
162+
\"$rating\": 6,
161163
\"$address_street\": \"Street_name1\",
162164
\"$address_city\": \"city1\",
163165
\"$address_region\": \"Region1\",

Branch-TestBed/Branch-SDK-Tests/BranchEvent.Test.m

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,7 @@ - (void) testEvent {
6868
buo.contentMetadata.ratingAverage = 5;
6969
buo.contentMetadata.ratingCount = 5;
7070
buo.contentMetadata.ratingMax = 7;
71+
buo.contentMetadata.rating = 6;
7172
buo.contentMetadata.addressStreet = @"Street_name1";
7273
buo.contentMetadata.addressCity = @"city1";
7374
buo.contentMetadata.addressRegion = @"Region1";
@@ -214,6 +215,7 @@ - (void) testUserCompletedAction {
214215
buo.contentMetadata.ratingAverage = 5;
215216
buo.contentMetadata.ratingCount = 5;
216217
buo.contentMetadata.ratingMax = 7;
218+
buo.contentMetadata.rating = 6;
217219
buo.contentMetadata.addressStreet = @"Street_name1";
218220
buo.contentMetadata.addressCity = @"city1";
219221
buo.contentMetadata.addressRegion = @"Region1";

Branch-TestBed/Branch-SDK-Tests/BranchEvent.Test.swift

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,14 +44,18 @@ class BranchEventTestSwift : BNCTestCase {
4444
branchUniversalObject.contentMetadata.ratingAverage = 5;
4545
branchUniversalObject.contentMetadata.ratingCount = 5;
4646
branchUniversalObject.contentMetadata.ratingMax = 7;
47+
branchUniversalObject.contentMetadata.rating = 6;
4748
branchUniversalObject.contentMetadata.addressStreet = "Street_name1"
4849
branchUniversalObject.contentMetadata.addressCity = "city1"
4950
branchUniversalObject.contentMetadata.addressRegion = "Region1"
5051
branchUniversalObject.contentMetadata.addressCountry = "Country1"
5152
branchUniversalObject.contentMetadata.addressPostalCode = "postal_code"
5253
branchUniversalObject.contentMetadata.latitude = 12.07
5354
branchUniversalObject.contentMetadata.longitude = -97.5
54-
branchUniversalObject.contentMetadata.imageCaptions = [ "my_img_caption1", "my_img_caption_2"]
55+
branchUniversalObject.contentMetadata.imageCaptions = [
56+
"my_img_caption1",
57+
"my_img_caption_2"
58+
]
5559
branchUniversalObject.contentMetadata.customMetadata = [
5660
"Custom_Content_metadata_key1": "Custom_Content_metadata_val1",
5761
"Custom_Content_metadata_key2": "Custom_Content_metadata_val2"

Branch-TestBed/Branch-SDK-Tests/BranchUniversalObject.Test.m

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,7 @@ - (void) testDeserialize {
4545
XCTAssertEqual(buo.contentMetadata.ratingAverage, 5);
4646
XCTAssertEqual(buo.contentMetadata.ratingCount, 5);
4747
XCTAssertEqual(buo.contentMetadata.ratingMax, 7);
48+
XCTAssertEqual(buo.contentMetadata.rating, 6);
4849
XCTAssertEqualObjects(buo.contentMetadata.addressStreet, @"Street_name1");
4950
XCTAssertEqualObjects(buo.contentMetadata.addressCity, @"city1");
5051
XCTAssertEqualObjects(buo.contentMetadata.addressRegion, @"Region1");
@@ -107,6 +108,7 @@ - (void) testSerialize {
107108
buo.contentMetadata.ratingAverage = 5;
108109
buo.contentMetadata.ratingCount = 5;
109110
buo.contentMetadata.ratingMax = 7;
111+
buo.contentMetadata.rating = 6;
110112
buo.contentMetadata.addressStreet = @"Street_name1";
111113
buo.contentMetadata.addressCity = @"city1";
112114
buo.contentMetadata.addressRegion = @"Region1";
@@ -125,11 +127,12 @@ - (void) testSerialize {
125127
buo.keywords = @[@"My_Keyword1", @"My_Keyword2"];
126128
buo.contentDescription = @"my_product_description1";
127129
buo.imageUrl = @"https://test_img_url";
128-
buo.expirationDate = [NSDate dateWithTimeIntervalSince1970:(double)212123232544.0/1000.0];
130+
buo.expirationDate =
131+
[NSDate dateWithTimeIntervalSince1970:(double)212123232544.0/1000.0];
129132
buo.publiclyIndex = NO;
130133
buo.locallyIndex = YES;
131-
buo.creationDate = [NSDate dateWithTimeIntervalSince1970:(double)1501869445321.0/1000.0];
132-
134+
buo.creationDate =
135+
[NSDate dateWithTimeIntervalSince1970:(double)1501869445321.0/1000.0];
133136
NSDictionary *buoDictionary = buo.dictionary;
134137

135138
// Load the JSON:

Branch-TestBed/Branch-TestBed/ViewController.m

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -265,6 +265,7 @@ - (IBAction)shareLinkButtonTouchUpInside:(id)sender {
265265
buo.contentMetadata.ratingAverage = 5;
266266
buo.contentMetadata.ratingCount = 5;
267267
buo.contentMetadata.ratingMax = 7;
268+
buo.contentMetadata.rating = 6;
268269
buo.contentMetadata.addressStreet = @"Street_name1";
269270
buo.contentMetadata.addressCity = @"city1";
270271
buo.contentMetadata.addressRegion = @"Region1";
@@ -455,6 +456,7 @@ - (void) sendV2EventWithName:(NSString*)eventName {
455456
buo.contentMetadata.ratingAverage = 5;
456457
buo.contentMetadata.ratingCount = 5;
457458
buo.contentMetadata.ratingMax = 7;
459+
buo.contentMetadata.rating = 6;
458460
buo.contentMetadata.addressStreet = @"Street_name1";
459461
buo.contentMetadata.addressCity = @"city1";
460462
buo.contentMetadata.addressRegion = @"Region1";

0 commit comments

Comments
 (0)