Skip to content

Commit 8575f23

Browse files
committed
Added check for maccatalyst
1 parent 2285c6c commit 8575f23

File tree

5 files changed

+11
-11
lines changed

5 files changed

+11
-11
lines changed

Branch-TestBed/Branch-SDK-Tests/BNCSKAdNetworkTests.m

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ - (void)tearDown {
4747

4848
- (void)testDefaultMaxTimeout {
4949
NSTimeInterval days;
50-
if (@available(iOS 16.1, *)) {
50+
if (@available(iOS 16.1, macCatalyst 16.1, *)) {
5151
days = 3600.0 * 24.0 * 60.0; // one day
5252
} else {
5353
days = 3600.0 * 24.0; // one day
@@ -66,7 +66,7 @@ - (void)testShouldAttemptSKAdNetworkCalloutFalse {
6666

6767
- (void)testPostbackCall {
6868

69-
if (@available(iOS 16.1, *)) {
69+
if (@available(iOS 16.1, macCatalyst 16.1, *)) {
7070
self.skAdNetwork.maxTimeSinceInstall = 3600.0 * 24.0 * 60.0;
7171
} else {
7272
self.skAdNetwork.maxTimeSinceInstall = 3600.0 * 24.0; // one day
@@ -94,7 +94,7 @@ - (void)testPostbackCall {
9494

9595
- (void)testSKAN4ParamsDefaultValues {
9696

97-
if (@available(iOS 16.1, *)) {
97+
if (@available(iOS 16.1, macCatalyst 16.1, *)) {
9898
NSString *coarseValue = [[BNCSKAdNetwork sharedInstance] getCoarseConversionValueFromDataResponse:@{}];
9999
XCTAssertTrue([coarseValue isEqualToString:@"low"]);
100100

@@ -108,7 +108,7 @@ - (void)testSKAN4ParamsDefaultValues {
108108

109109
- (void)testSKAN4ParamsValues {
110110

111-
if (@available(iOS 16.1, *)) {
111+
if (@available(iOS 16.1, macCatalyst 16.1, *)) {
112112

113113
NSDictionary *response = @{@"update_conversion_value": @16, @"coarse_key": @"high", @"locked": @YES, @"ascending_only":@NO };
114114
BNCSKAdNetwork *adNetwork = [BNCSKAdNetwork sharedInstance];

BranchSDK/BNCServerInterface.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -576,7 +576,7 @@ - (BOOL)installDateIsRecent {
576576
//NSTimeInterval maxTimeSinceInstall = 60.0;
577577
NSTimeInterval maxTimeSinceInstall = 0;
578578

579-
if (@available(iOS 16.1, *)) {
579+
if (@available(iOS 16.1, macCatalyst 16.1, *)) {
580580
maxTimeSinceInstall = 3600.0 * 24.0 * 60; // For SKAN 4.0, The user has 60 days to launch the app.
581581
} else {
582582
maxTimeSinceInstall = 3600.0 * 24.0 * 30;

BranchSDK/Branch.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -977,7 +977,7 @@ - (void)handleATTAuthorizationStatus:(NSUInteger)status {
977977
}
978978

979979
- (void)setSKAdNetworkCalloutMaxTimeSinceInstall:(NSTimeInterval)maxTimeInterval {
980-
if (@available(iOS 16.1, *)) {
980+
if (@available(iOS 16.1, macCatalyst 16.1, *)) {
981981
BNCLogDebug(@"This is no longer supported for iOS 16.1+ - SKAN4.0");
982982
} else {
983983
[BNCSKAdNetwork sharedInstance].maxTimeSinceInstall = maxTimeInterval;

BranchSDK/BranchEvent.m

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ - (void)processResponse:(BNCServerResponse*)response error:(NSError*)error {
8888
NSNumber *conversionValue = (NSNumber *)dictionary[BRANCH_RESPONSE_KEY_UPDATE_CONVERSION_VALUE];
8989
// Regardless of SKAN opted-in in dashboard, we always get conversionValue, so adding check to find out if install/open response had "invoke_register_app" true
9090
if (conversionValue && [BNCPreferenceHelper sharedInstance].invokeRegisterApp) {
91-
if (@available(iOS 16.1, *)){
91+
if (@available(iOS 16.1, macCatalyst 16.1, *)){
9292
NSString * coarseConversionValue = [[BNCSKAdNetwork sharedInstance] getCoarseConversionValueFromDataResponse:dictionary] ;
9393
BOOL lockWin = [[BNCSKAdNetwork sharedInstance] getLockedStatusFromDataResponse:dictionary];
9494
BOOL shouldCallUpdatePostback = [[BNCSKAdNetwork sharedInstance] shouldCallPostbackForDataResponse:dictionary];
@@ -351,7 +351,7 @@ - (NSDictionary *)buildEventDictionary {
351351
eventDictionary[BRANCH_REQUEST_KEY_PARTNER_PARAMETERS] = partnerParameters;
352352
}
353353

354-
if (@available(iOS 16.1, *)){
354+
if (@available(iOS 16.1, macCatalyst 16.1, *)){
355355
if ([BNCPreferenceHelper sharedInstance].invokeRegisterApp) {
356356
int currentWindow = [[BNCSKAdNetwork sharedInstance] calculateSKANWindowForTime:[NSDate date]];
357357
if (currentWindow == BranchSkanWindowFirst){

BranchSDK/BranchOpenRequest.m

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ - (void)makeRequest:(BNCServerInterface *)serverInterface key:(NSString *)key ca
113113
params[@"first_install_time"] = BNCWireFormatFromDate(application.firstInstallDate);
114114
params[@"update"] = [self.class appUpdateState];
115115

116-
if (@available(iOS 16.1, *)){
116+
if (@available(iOS 16.1, macCatalyst 16.1, *)){
117117
if ([BNCPreferenceHelper sharedInstance].invokeRegisterApp) {
118118
int currentWindow = [[BNCSKAdNetwork sharedInstance] calculateSKANWindowForTime:[NSDate date]];
119119
if (currentWindow == BranchSkanWindowFirst){
@@ -303,7 +303,7 @@ - (void)processResponse:(BNCServerResponse *)response error:(NSError *)error {
303303
NSNumber *invokeRegister = (NSNumber *)data[BRANCH_RESPONSE_KEY_INVOKE_REGISTER_APP];
304304
preferenceHelper.invokeRegisterApp = invokeRegister.boolValue;
305305
if (invokeRegister.boolValue && self.isInstall) {
306-
if (@available(iOS 16.1, *)){
306+
if (@available(iOS 16.1, macCatalyst 16.1, *)){
307307
NSString *defaultCoarseConValue = [[BNCSKAdNetwork sharedInstance] getCoarseConversionValueFromDataResponse:@{}];
308308
[[BNCSKAdNetwork sharedInstance] updatePostbackConversionValue:0 coarseValue:defaultCoarseConValue
309309
lockWindow:NO completionHandler:^(NSError * _Nullable error) {
@@ -335,7 +335,7 @@ - (void)processResponse:(BNCServerResponse *)response error:(NSError *)error {
335335
NSNumber *conversionValue = (NSNumber *)data[BRANCH_RESPONSE_KEY_UPDATE_CONVERSION_VALUE];
336336
// Regardless of SKAN opted-in in dashboard, we always get conversionValue, so adding check to find out if install/open response had "invoke_register_app" true
337337
if (conversionValue && preferenceHelper.invokeRegisterApp ) {
338-
if (@available(iOS 16.1, *)){
338+
if (@available(iOS 16.1, macCatalyst 16.1, *)){
339339
NSString* coarseConversionValue = [[BNCSKAdNetwork sharedInstance] getCoarseConversionValueFromDataResponse:data] ;
340340
BOOL lockWin = [[BNCSKAdNetwork sharedInstance] getLockedStatusFromDataResponse:data];
341341
BOOL shouldCallUpdatePostback = [[BNCSKAdNetwork sharedInstance] shouldCallPostbackForDataResponse:data];

0 commit comments

Comments
 (0)