Fix tests.

Edward Smith · Edward Smith · commit 99bd0bc8e046 · 2018-07-17T11:55:00.000-07:00
diff --git a/Branch-SDK-Tests/Branch-SDK-Tests/BranchInstallRequestTests.m b/Branch-SDK-Tests/Branch-SDK-Tests/BranchInstallRequestTests.m
@@ -96,7 +96,7 @@ - (void)testRequestBody {
 		postRequest:[OCMArg checkWithBlock:^BOOL(id value) {
             if (![value isKindOfClass:[NSDictionary class]]) {
                 XCTFail(@"Expected NSDictionary. Got '%@'.", NSStringFromClass([value class]));
-                return NO;
+                return YES;
             }
             NSDictionary *dictionary = (NSDictionary*)value;
             XCTAssertEqualObjects(dictionary, expectedParams);
diff --git a/scripts/test-unit-tests b/scripts/test-unit-tests
@@ -110,8 +110,9 @@ fi
 testSimulatorVersion "iPhone SE" "$stressOS"
 testSimulatorVersion "iPhone 6s" 10.0
 testSimulatorVersion "iPhone 5"  9.3
-# xctest doesn't work for iOS 8.4 in Xcode 9.3.  Bummer.
-if [ "$(xcodebuild -version | head -n1)" != "Xcode 9.3" ]
+# xctest doesn't work for iOS 8.4 in Xcode 9.3 and above.  Bummer.
+xv=$(xcodebuild -version | head -n1)
+if [[ "$xv" == "Xcode 9.3" ]] || [[ "$xv" == "Xcode 9.4" ]]
 then
     testSimulatorVersion "iPhone 4s" 8.4
 fi

Original file line number	Diff line number	Diff line change
`@@ -96,7 +96,7 @@ - (void)testRequestBody {`
`96`	`96`	`postRequest:[OCMArg checkWithBlock:^BOOL(id value) {`
`97`	`97`	`if (![value isKindOfClass:[NSDictionary class]]) {`
`98`	`98`	`XCTFail(@"Expected NSDictionary. Got '%@'.", NSStringFromClass([value class]));`
`99`		`- return NO;`
	`99`	`+ return YES;`
`100`	`100`	`}`
`101`	`101`	`NSDictionary dictionary = (NSDictionary)value;`
`102`	`102`	`XCTAssertEqualObjects(dictionary, expectedParams);`