Updated sharing events to fire. (#801)

E-B-Smith · web-flow · commit 9a5c38b6f672 · 2018-03-14T16:12:11.000-07:00
diff --git a/Branch-SDK/Branch-SDK/Branch.m b/Branch-SDK/Branch-SDK/Branch.m
@@ -1842,7 +1842,7 @@ - (void)registerViewWithParams:(NSDictionary *)params andCallback:(callbackWithP
     [self initSessionIfNeededAndNotInProgress];
     BranchUniversalObject *buo = [[BranchUniversalObject alloc] init];
     buo.contentMetadata.customMetadata = (id) params;
-    [BranchEvent standardEvent:BranchStandardEventViewItem withContentItem:buo];
+    [[BranchEvent standardEvent:BranchStandardEventViewItem withContentItem:buo] logEvent];
     if (callback) callback(@{}, nil);
 }
 
diff --git a/Branch-SDK/Branch-SDK/BranchShareLink.m b/Branch-SDK/Branch-SDK/BranchShareLink.m
@@ -81,7 +81,7 @@ - (void) shareDidComplete:(BOOL)completed activityError:(NSError*)error {
         [self.delegate branchShareLink:self didComplete:completed withError:error];
     }
     if (completed && !error)
-        [BranchEvent customEventWithName:BNCShareCompletedEvent contentItem:self.universalObject];
+        [[BranchEvent customEventWithName:BNCShareCompletedEvent contentItem:self.universalObject] logEvent];
     NSDictionary *attributes = [self.universalObject getDictionaryWithCompleteLinkProperties:self.linkProperties];
     [BNCFabricAnswers sendEventWithName:@"Branch Share" andAttributes:attributes];
 }
@@ -110,7 +110,7 @@ - (void) shareDidComplete:(BOOL)completed activityError:(NSError*)error {
     }
 
     // Log share initiated event
-    [BranchEvent customEventWithName:BNCShareInitiatedEvent contentItem:self.universalObject];
+    [[BranchEvent customEventWithName:BNCShareInitiatedEvent contentItem:self.universalObject] logEvent];
 
     _activityItems = [NSMutableArray new];
     BranchShareActivityItem *item = nil;

Original file line number	Diff line number	Diff line change
`@@ -1842,7 +1842,7 @@ - (void)registerViewWithParams:(NSDictionary *)params andCallback:(callbackWithP`
`1842`	`1842`	`[self initSessionIfNeededAndNotInProgress];`
`1843`	`1843`	`BranchUniversalObject *buo = [[BranchUniversalObject alloc] init];`
`1844`	`1844`	`buo.contentMetadata.customMetadata = (id) params;`
`1845`		`- [BranchEvent standardEvent:BranchStandardEventViewItem withContentItem:buo];`
	`1845`	`+ [[BranchEvent standardEvent:BranchStandardEventViewItem withContentItem:buo] logEvent];`
`1846`	`1846`	`if (callback) callback(@{}, nil);`
`1847`	`1847`	`}`
`1848`	`1848`
Original file line number	Diff line number	Diff line change
`@@ -81,7 +81,7 @@ - (void) shareDidComplete:(BOOL)completed activityError:(NSError*)error {`
`81`	`81`	`[self.delegate branchShareLink:self didComplete:completed withError:error];`
`82`	`82`	`}`
`83`	`83`	`if (completed && !error)`
`84`		`- [BranchEvent customEventWithName:BNCShareCompletedEvent contentItem:self.universalObject];`
	`84`	`+ [[BranchEvent customEventWithName:BNCShareCompletedEvent contentItem:self.universalObject] logEvent];`
`85`	`85`	`NSDictionary *attributes = [self.universalObject getDictionaryWithCompleteLinkProperties:self.linkProperties];`
`86`	`86`	`[BNCFabricAnswers sendEventWithName:@"Branch Share" andAttributes:attributes];`
`87`	`87`	`}`
`@@ -110,7 +110,7 @@ - (void) shareDidComplete:(BOOL)completed activityError:(NSError*)error {`
`110`	`110`	`}`
`111`	`111`
`112`	`112`	`// Log share initiated event`
`113`		`- [BranchEvent customEventWithName:BNCShareInitiatedEvent contentItem:self.universalObject];`
	`113`	`+ [[BranchEvent customEventWithName:BNCShareInitiatedEvent contentItem:self.universalObject] logEvent];`
`114`	`114`
`115`	`115`	`_activityItems = [NSMutableArray new];`
`116`	`116`	`BranchShareActivityItem *item = nil;`