Added pragmas to silence availability warnings. (GH #733, #735)

Author: E-B-Smith

Branch-SDK/Branch-SDK/BNCContentDiscoveryManager.m

@@ -544,21 +544,33 @@ - (void)indexUsingNSUserActivity:(NSDictionary *)params {
         // if no view controller, don't index. Current use case: iMessage extensions
         return;
     }
+    #pragma clang diagnostic push
+    #pragma clang diagnostic ignored "-Wpartial-availability"
+
     NSString *uniqueIdentifier = [NSString stringWithFormat:@"io.branch.%@", [[NSBundle mainBundle] bundleIdentifier]];
+    
     // Can't create any weak references here to the userActivity, otherwise it will not index.
     activeViewController.userActivity = [[NSUserActivity alloc] initWithActivityType:uniqueIdentifier];
     activeViewController.userActivity.delegate = self;
     activeViewController.userActivity.title = params[@"title"];
     activeViewController.userActivity.webpageURL = [NSURL URLWithString:params[@"url"]];
     activeViewController.userActivity.eligibleForSearch = YES;
     activeViewController.userActivity.eligibleForPublicIndexing = [params[@"publiclyIndexable"] boolValue];
-    activeViewController.userActivity.userInfo = self.userInfo; // This alone doesn't pass userInfo through
-    activeViewController.userActivity.requiredUserInfoKeys = [NSSet setWithArray:self.userInfo.allKeys]; // This along with the delegate method userActivityWillSave, however, seem to force the userInfo to come through.
+
+    // This alone doesn't pass userInfo through
+    activeViewController.userActivity.userInfo = self.userInfo;
+
+    // This along with the delegate method userActivityWillSave, however, seem to force the userInfo to come through.
+    activeViewController.userActivity.requiredUserInfoKeys = [NSSet setWithArray:self.userInfo.allKeys];
+
     activeViewController.userActivity.keywords = params[@"keywords"];
     SEL setContentAttributeSetSelector = NSSelectorFromString(@"setContentAttributeSet:");
-    ((void (*)(id, SEL, id))[activeViewController.userActivity methodForSelector:setContentAttributeSetSelector])(activeViewController.userActivity, setContentAttributeSetSelector, params[@"attributeSet"]);
+    ((void (*)(id, SEL, id))[activeViewController.userActivity methodForSelector:setContentAttributeSetSelector])
+        (activeViewController.userActivity, setContentAttributeSetSelector, params[@"attributeSet"]);
 
     [activeViewController.userActivity becomeCurrent];
+
+    #pragma clang diagnostic pop
 }
 
 @end

Branch-SDK/Branch-SDK/BNCDeviceInfo.m

@@ -215,9 +215,12 @@ + (NSString*) bnc_country {
 
     // Should work on iOS 10
     NSLocale *currentLocale = [NSLocale currentLocale];
+    #pragma clang diagnostic push
+    #pragma clang diagnostic ignored "-Wpartial-availability"
     if ([currentLocale respondsToSelector:@selector(countryCode)]) {
         country = [currentLocale countryCode];
     }
+    #pragma clang diagnostic pop
     returnIfValidCountry();
 
     // Should work on iOS 9
@@ -252,10 +255,13 @@ + (NSString*) bnc_language {
         } \
 
     // Should work on iOS 10
+    #pragma clang diagnostic push
+    #pragma clang diagnostic ignored "-Wpartial-availability"
     NSLocale *currentLocale = [NSLocale currentLocale];
     if ([currentLocale respondsToSelector:@selector(languageCode)]) {
         language = [currentLocale languageCode];
     }
+    #pragma clang diagnostic pop
     returnIfValidLanguage();
 
     // Should work on iOS 9

Branch-SDK/Branch-SDK/BNCStrongMatchHelper.m

@@ -44,6 +44,9 @@ + (NSURL *)getUrlForCookieBasedMatchingWithBranchKey:(NSString *)branchKey
 
 
 #else   // ------------------------------------------------------------------------------ iOS >= 9.0
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wpartial-availability"
+
 @import SafariServices;
 
 
@@ -367,4 +370,5 @@ - (void)safariViewController:(SFSafariViewController *)controller
 
 @end
 
+#pragma clang diagnostic pop
 #endif  // ------------------------------------------------------------------------------ iOS >= 9.0

Branch-SDK/Branch-SDK/Branch.m

@@ -672,11 +672,14 @@ - (BOOL)application:(UIApplication *)application
 
     NSString *source = nil;
     NSString *annotation = nil;
+    #pragma clang diagnostic push
+    #pragma clang diagnostic ignored "-Wpartial-availability"
     if (UIApplicationOpenURLOptionsSourceApplicationKey &&
         UIApplicationOpenURLOptionsAnnotationKey) {
         source = options[UIApplicationOpenURLOptionsSourceApplicationKey];
         annotation = options[UIApplicationOpenURLOptionsAnnotationKey];
     }
+    #pragma clang diagnostic pop
     return [self application:application openURL:url sourceApplication:source annotation:annotation];
 }
 

Branch-TestBed/Branch-TestBed.xcodeproj/project.pbxproj

@@ -1208,6 +1208,7 @@
 				CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
 				CLANG_WARN_STRICT_PROTOTYPES = YES;
 				CLANG_WARN_SUSPICIOUS_MOVE = YES;
+				CLANG_WARN_UNGUARDED_AVAILABILITY = YES_AGGRESSIVE;
 				CLANG_WARN_UNREACHABLE_CODE = YES;
 				CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
 				CODE_SIGN_IDENTITY = "iPhone Developer";
@@ -1259,6 +1260,7 @@
 				CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
 				CLANG_WARN_STRICT_PROTOTYPES = YES;
 				CLANG_WARN_SUSPICIOUS_MOVE = YES;
+				CLANG_WARN_UNGUARDED_AVAILABILITY = YES_AGGRESSIVE;
 				CLANG_WARN_UNREACHABLE_CODE = YES;
 				CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
 				CODE_SIGN_IDENTITY = "iPhone Developer";
@@ -1292,6 +1294,7 @@
 				GCC_PRECOMPILE_PREFIX_HEADER = YES;
 				GCC_PREFIX_HEADER = "Branch-TestBed/Branch-TestBed-Prefix.pch";
 				INFOPLIST_FILE = "Branch-TestBed/Branch-TestBed-Info.plist";
+				IPHONEOS_DEPLOYMENT_TARGET = 9.0;
 				PRODUCT_BUNDLE_IDENTIFIER = "io.branch.sdk.Branch-TestBed";
 				PRODUCT_NAME = "$(TARGET_NAME)";
 				PROVISIONING_PROFILE = "";
@@ -1312,6 +1315,7 @@
 				GCC_PRECOMPILE_PREFIX_HEADER = YES;
 				GCC_PREFIX_HEADER = "Branch-TestBed/Branch-TestBed-Prefix.pch";
 				INFOPLIST_FILE = "Branch-TestBed/Branch-TestBed-Info.plist";
+				IPHONEOS_DEPLOYMENT_TARGET = 9.0;
 				PRODUCT_BUNDLE_IDENTIFIER = "io.branch.sdk.Branch-TestBed";
 				PRODUCT_NAME = "$(TARGET_NAME)";
 				PROVISIONING_PROFILE = "";

Branch-TestBed/Branch-TestBed/ViewController.m

@@ -363,13 +363,7 @@ - (IBAction) sendCommerceEvent:(id)sender {
 			NSString *message =
 				[NSString stringWithFormat:@"Commerce completion called.\nError: %@\n%@", error, response];
 			NSLog(@"%@", message);
-			[[[UIAlertView alloc]
-				initWithTitle:@"Commerce Event"
-				message:message
-				delegate:nil
-				cancelButtonTitle:@"OK"
-				otherButtonTitles:nil]
-					show];
+            [self showAlert:@"Commerce Event" withDescription:message];
         }];
 }
 
@@ -453,13 +447,16 @@ - (void)showAlert: (NSString *)title withDescription:(NSString *) message {
 
         if ([UIDevice currentDevice].systemVersion.floatValue < 8.0) {
 
+            #pragma clang diagnostic push
+            #pragma clang diagnostic ignored "-Wdeprecated-declarations"
             UIAlertView *alert = [[UIAlertView alloc]
                 initWithTitle:title
                 message:message
                 delegate:nil
                 cancelButtonTitle:@"OK"
                 otherButtonTitles:nil];
             [alert show];
+            #pragma clang diagnostic pop
 
         } else {