Skip to content

Commit da96d6a

Browse files
author
Edward Smith
committed
Updated change log and updated tests.
1 parent 0a2c59a commit da96d6a

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

Branch-TestBed/Branch-SDK-Tests/BNCURLBlackList.Test.m

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,8 @@ - (void) testStandardBlackList {
143143
__unsafe_unretained NSDictionary *dictionary = nil;
144144
[invocation getArgument:&dictionary atIndex:2];
145145

146-
NSString* link = dictionary[@"universal_link_url"];
146+
NSLog(@"d: %@", dictionary);
147+
NSString* link = dictionary[@"external_intent_uri"];
147148
NSString *pattern = @"^(?i)((http|https):\\/\\/).*[\\/|?|#].*\\b(password|o?auth|o?auth.?token|access|access.?token)\\b";
148149
NSLog(@"\n Link: '%@'\nPattern: '%@'\n.", link, pattern);
149150
if ([link isEqualToString:pattern]) {
@@ -176,7 +177,7 @@ - (void) testUserBlackList {
176177
__unsafe_unretained NSDictionary *dictionary = nil;
177178
[invocation getArgument:&dictionary atIndex:2];
178179

179-
NSString* link = dictionary[@"universal_link_url"];
180+
NSString* link = dictionary[@"external_intent_uri"];
180181
NSString *pattern = @"\\/bob\\/";
181182
NSLog(@"\n Link: '%@'\nPattern: '%@'\n.", link, pattern);
182183

ChangeLog.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,12 @@
11
Branch iOS SDK Change Log
22

33
- v0.24.2
4-
* _*Master Release*_ - April 19, 2018
4+
* _*Master Release*_ - April 20, 2018
55
* Fixed a bug where a opening a blacklisted URI scheme would cause an HTTP status 400 for each
66
Branch open until the app was opened with a universal link (DEVEX-341).
77
- After opening a blacklisted scheme, the app would not open other schemes until a https URL was opened.
88
- Added code that clears the blacklisted URL after sending the regex pattern to the server.
9+
- The matching regex is now sent in `external_intent_uri` rather than `universal_link_url`.
910
- Removed an old NSLog from debugging.
1011
* Added `BNCProductCategoryAllCategories(void)` and `BNCCurrencyAllCurrencies(void)` convenience functions.
1112
* Updated Info.plist URI Filter and clarified documentation (DEVEX-343).

0 commit comments

Comments
 (0)