Skip to content

Commit e45aa2b

Browse files
committed
SDK-1437 log a warning about invalid parameters
1 parent 45b5971 commit e45aa2b

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

Branch-SDK/BNCPartnerParameters.m

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
//
88

99
#import "BNCPartnerParameters.h"
10+
#import "BNCLog.h"
1011

1112
@interface BNCPartnerParameters()
1213
@property (nonatomic, strong, readwrite) NSMutableDictionary<NSString *, NSMutableDictionary<NSString *, NSString *> *> *parameters;
@@ -53,15 +54,15 @@ - (void)addFacebookParameterWithName:(NSString *)name value:(NSString *)value {
5354
if ([self sha256HashSanityCheckValue:value]) {
5455
[self addParameterWithName:name value:value partnerName:@"fb"];
5556
} else {
56-
// TODO: log a warning that the parameter looks invalid and will be ignored. Do not log the value as it may be PII that was inadvertently passed in.
57+
BNCLogWarning(@"Partner parameter does not appear to be SHA256 hashed. Dropping the parameter.");
5758
}
5859
}
5960

6061
- (void)addSnapParameterWithName:(NSString *)name value:(NSString *)value {
6162
if ([self sha256HashSanityCheckValue:value]) {
6263
[self addParameterWithName:name value:value partnerName:@"snap"];
6364
} else {
64-
// TODO: log a warning that the parameter looks invalid and will be ignored. Do not log the value as it may be PII that was inadvertently passed in.
65+
BNCLogWarning(@"Partner parameter does not appear to be SHA256 hashed. Dropping the parameter.");
6566
}
6667
}
6768

0 commit comments

Comments
 (0)