Skip to content

Commit ea1a627

Browse files
committed
Fix issue with handlePushNotification
1 parent 02c0bbd commit ea1a627

File tree

6 files changed

+20
-9
lines changed

6 files changed

+20
-9
lines changed

BranchSDK.podspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
Pod::Spec.new do |s|
22
s.name = "BranchSDK"
3-
s.version = "3.4.2"
3+
s.version = "3.4.3"
44
s.summary = "Create an HTTP URL for any piece of content in your app"
55
s.description = <<-DESC
66
- Want the highest possible conversions on your sharing feature?

BranchSDK.xcodeproj/project.pbxproj

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1974,7 +1974,7 @@
19741974
"@executable_path/Frameworks",
19751975
"@loader_path/Frameworks",
19761976
);
1977-
MARKETING_VERSION = 3.4.2;
1977+
MARKETING_VERSION = 3.4.3;
19781978
OTHER_LDFLAGS = (
19791979
"-weak_framework",
19801980
LinkPresentation,
@@ -2009,7 +2009,7 @@
20092009
"@executable_path/Frameworks",
20102010
"@loader_path/Frameworks",
20112011
);
2012-
MARKETING_VERSION = 3.4.2;
2012+
MARKETING_VERSION = 3.4.3;
20132013
OTHER_LDFLAGS = (
20142014
"-weak_framework",
20152015
LinkPresentation,
@@ -2215,7 +2215,7 @@
22152215
"@loader_path/Frameworks",
22162216
);
22172217
MACH_O_TYPE = staticlib;
2218-
MARKETING_VERSION = 3.4.2;
2218+
MARKETING_VERSION = 3.4.3;
22192219
OTHER_LDFLAGS = (
22202220
"-weak_framework",
22212221
LinkPresentation,
@@ -2254,7 +2254,7 @@
22542254
"@loader_path/Frameworks",
22552255
);
22562256
MACH_O_TYPE = staticlib;
2257-
MARKETING_VERSION = 3.4.2;
2257+
MARKETING_VERSION = 3.4.3;
22582258
OTHER_LDFLAGS = (
22592259
"-weak_framework",
22602260
LinkPresentation,
@@ -2291,7 +2291,7 @@
22912291
"@executable_path/Frameworks",
22922292
"@loader_path/Frameworks",
22932293
);
2294-
MARKETING_VERSION = 3.4.2;
2294+
MARKETING_VERSION = 3.4.3;
22952295
OTHER_LDFLAGS = (
22962296
"-weak_framework",
22972297
LinkPresentation,
@@ -2326,7 +2326,7 @@
23262326
"@executable_path/Frameworks",
23272327
"@loader_path/Frameworks",
23282328
);
2329-
MARKETING_VERSION = 3.4.2;
2329+
MARKETING_VERSION = 3.4.3;
23302330
OTHER_LDFLAGS = (
23312331
"-weak_framework",
23322332
LinkPresentation,

ChangeLog.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
11
Branch iOS SDK Change Log
22

3+
v.3.4.3
4+
- Fix push notifications when app is backgrounded and the app uses `handlePushNotification` instead of `handleDeeplink`
5+
36
v.3.4.2
47
- Fix tvOS when using SPM
58

Sources/BranchSDK/BNCConfig.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88

99
#include "BNCConfig.h"
1010

11-
NSString * const BNC_SDK_VERSION = @"3.4.2";
11+
NSString * const BNC_SDK_VERSION = @"3.4.3";
1212
NSString * const BNC_LINK_URL = @"https://bnc.lt";
1313
NSString * const BNC_CDN_URL = @"https://cdn.branch.io";
1414

Sources/BranchSDK/Branch.m

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -837,8 +837,16 @@ + (BOOL)isBranchLink:(NSString *)urlString {
837837

838838
#pragma mark - Push Notification support
839839

840+
// TODO: is there any benefit to the extra checks in this method over directly calling handleDeeplink?
840841
- (void)handlePushNotification:(NSDictionary *)userInfo {
841842
NSString *urlStr = [userInfo objectForKey:BRANCH_PUSH_NOTIFICATION_PAYLOAD_KEY];
843+
844+
// Saves URL into global storage for `applicationDidBecomeActive`
845+
if (urlStr.length) {
846+
// reusing this field, so as not to create yet another url slot on prefshelper
847+
self.preferenceHelper.universalLinkUrl = urlStr;
848+
self.preferenceHelper.referringURL = urlStr;
849+
}
842850

843851
// If app is active, then close out the session and start a new one.
844852
// Else the URL will be handled by `applicationDidBecomeActive`.

scripts/version.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ Options:
3030
USAGE
3131
}
3232

33-
version=3.4.2
33+
version=3.4.3
3434
prev_version="$version"
3535

3636
if (( $# == 0 )); then

0 commit comments

Comments
 (0)