SDK-842 add some tests

Author: echo-branch

Branch-SDK-Tests/BNCDeviceInfoTests.m

@@ -140,6 +140,8 @@ - (void)testV2Dictionary {
     XCTAssertNotNil([dict objectForKey:@"os"]);
     XCTAssertNotNil([dict objectForKey:@"sdk"]);
     XCTAssertNotNil([dict objectForKey:@"sdk_version"]);
+    
+    XCTAssertNil([dict objectForKey:@"disable_ad_network_callouts"]);
 }
 
 @end

Branch-SDK-Tests/BNCDisableAdNetworkCalloutsTests.m

@@ -0,0 +1,58 @@
+//
+//  BNCDisableAdNetworkCalloutsTests.m
+//  Branch-SDK-Tests
+//
+//  Created by Ernest Cho on 3/2/20.
+//  Copyright © 2020 Branch, Inc. All rights reserved.
+//
+
+#import <XCTest/XCTest.h>
+#import "BNCPreferenceHelper.h"
+#import "BNCDeviceInfo.h"
+#import "BNCServerInterface.h"
+
+@interface BNCServerInterface()
+- (void)updateDeviceInfoToMutableDictionary:(NSMutableDictionary *)dict;
+@end
+
+@interface BNCDisableAdNetworkCalloutsTests : XCTestCase
+
+@end
+
+// These tests are not parallelizable and therefore disabled by default
+// This is due to the tight coupling between BNCPreferenceHelper and BNCDeviceInfo
+@implementation BNCDisableAdNetworkCalloutsTests
+
+- (void)setUp {
+    [BNCPreferenceHelper preferenceHelper].disableAdNetworkCallouts = YES;
+}
+
+- (void)tearDown {
+    [BNCPreferenceHelper preferenceHelper].disableAdNetworkCallouts = NO;
+}
+
+// check on the V2 dictionary
+- (void)testV2Dictionary {
+    NSDictionary *dict = [[BNCDeviceInfo getInstance] v2dictionary];
+    XCTAssertNotNil(dict);
+    XCTAssertNotNil([dict objectForKey:@"brand"]);
+    XCTAssertNotNil([dict objectForKey:@"os"]);
+    XCTAssertNotNil([dict objectForKey:@"sdk"]);
+    XCTAssertNotNil([dict objectForKey:@"sdk_version"]);
+    
+    XCTAssertTrue([dict objectForKey:@"disable_ad_network_callouts"]);
+}
+
+// check on V1 payload
+- (void)testV1Payload {
+    BNCServerInterface *interface = [BNCServerInterface new];
+    interface.preferenceHelper = [BNCPreferenceHelper preferenceHelper];
+    
+    NSMutableDictionary *tmp = [NSMutableDictionary new];
+    [interface updateDeviceInfoToMutableDictionary:tmp];
+    
+    XCTAssertNotNil(tmp);
+    XCTAssertTrue([tmp objectForKey:@"disable_ad_network_callouts"]);
+}
+
+@end

Branch-SDK-Tests/BNCPreferenceHelperTests.m

@@ -29,6 +29,7 @@ - (void)testPreferenceDefaults {
     XCTAssertEqual(self.prefHelper.timeout, 5.5);
     XCTAssertEqual(self.prefHelper.retryInterval, 0);
     XCTAssertEqual(self.prefHelper.retryCount, 3);
+    XCTAssertFalse(self.prefHelper.disableAdNetworkCallouts);
 }
 
 - (void)testPreferenceSets {

Branch-TestBed/Branch-TestBed.xcodeproj/project.pbxproj

@@ -445,6 +445,7 @@
 		54FF1F901BD1DC320004CE2E /* BranchLinkProperties.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = BranchLinkProperties.m; sourceTree = "<group>"; };
 		5F08460F23480008005B17E6 /* BNCTuneUtility.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = BNCTuneUtility.h; sourceTree = "<group>"; };
 		5F08461023480008005B17E6 /* BNCTuneUtility.m */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.objc; path = BNCTuneUtility.m; sourceTree = "<group>"; };
+		5F2035CB240DDE90004FDC3E /* BNCDisableAdNetworkCalloutsTests.m */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.objc; path = BNCDisableAdNetworkCalloutsTests.m; sourceTree = "<group>"; };
 		5F205D022318641700C776D1 /* BNCUserAgentCollectorTests.m */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.objc; path = BNCUserAgentCollectorTests.m; sourceTree = "<group>"; };
 		5F205D04231864E800C776D1 /* WebKit.framework */ = {isa = PBXFileReference; lastKnownFileType = wrapper.framework; name = WebKit.framework; path = System/Library/Frameworks/WebKit.framework; sourceTree = SDKROOT; };
 		5F3D6712232C589100454FF1 /* BranchLastAttributedTouchData.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = BranchLastAttributedTouchData.m; sourceTree = "<group>"; };
@@ -763,6 +764,7 @@
 				4AB16367239E3A2700D42931 /* DispatchToIsolationQueueTests.m */,
 				5F437E39237DE3480052064B /* BNCTelephonyTests.m */,
 				5F437E3F237E1A560052064B /* BNCDeviceSystemTests.m */,
+				5F2035CB240DDE90004FDC3E /* BNCDisableAdNetworkCalloutsTests.m */,
 			);
 			name = "Branch-SDK-Tests";
 			path = "../Branch-SDK-Tests";

Branch-TestBed/Branch-TestBed/AppDelegate.m

@@ -26,11 +26,8 @@ - (BOOL)application:(UIApplication *)application
     */
 
     // Branch.useTestBranchKey = YES;  // Make sure to comment this line out for production apps!!!
-
-    //
     Branch *branch = [Branch getInstance];
 
-    
     // test pre init support
     //[self testDispatchToIsolationQueue:branch]