Skip to content

Commit fde5423

Browse files
authored
Merge pull request #1235 from BranchMetrics/SDK-1747-maccatalyst-skan-issue
SDK-1747 macCatalyst SKAN issue
2 parents 296e2e6 + a842159 commit fde5423

File tree

2 files changed

+8
-5
lines changed

2 files changed

+8
-5
lines changed

BranchSDK/BNCSKAdNetwork.m

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ + (BNCSKAdNetwork *)sharedInstance {
3737
- (instancetype)init {
3838
self = [super init];
3939
if (self) {
40-
if (@available(iOS 16.1, *)){
40+
if (@available(iOS 16.1, macCatalyst 16.1, *)){
4141
// For SKAN 4.0, its 60 days = 3600.0 * 24.0 * 60 seconds
4242
self.maxTimeSinceInstall = 3600.0 * 24.0 * 60;
4343
} else {
@@ -70,7 +70,7 @@ - (BOOL)shouldAttemptSKAdNetworkCallout {
7070
}
7171

7272
- (void)registerAppForAdNetworkAttribution {
73-
if (@available(iOS 14.0, *)) {
73+
if (@available(iOS 14.0, macCatalyst 14.0, *)) {
7474
if ([self shouldAttemptSKAdNetworkCallout]) {
7575

7676
// Equivalent call [SKAdNetwork registerAppForAdNetworkAttribution];
@@ -80,7 +80,7 @@ - (void)registerAppForAdNetworkAttribution {
8080
}
8181

8282
- (void)updateConversionValue:(NSInteger)conversionValue {
83-
if (@available(iOS 14.0, *)) {
83+
if (@available(iOS 14.0, macCatalyst 14.0, *)) {
8484
if ([self shouldAttemptSKAdNetworkCallout]) {
8585

8686
// Equivalent call [SKAdNetwork updateConversionValue:conversionValue];
@@ -91,7 +91,7 @@ - (void)updateConversionValue:(NSInteger)conversionValue {
9191

9292
- (void)updatePostbackConversionValue:(NSInteger)conversionValue
9393
completionHandler:(void (^)(NSError *error))completion {
94-
if (@available(iOS 15.4, *)) {
94+
if (@available(iOS 15.4, macCatalyst 15.4, *)) {
9595
if ([self shouldAttemptSKAdNetworkCallout]) {
9696

9797
// Equivalent call [SKAdNetwork updatePostbackConversionValue:completionHandler:];
@@ -105,9 +105,10 @@ - (void)updatePostbackConversionValue:(NSInteger)fineValue
105105
coarseValue:(NSString *)coarseValue
106106
lockWindow:(BOOL)lockWindow
107107
completionHandler:(void (^)(NSError *error))completion {
108-
if (@available(iOS 16.1, *)) {
108+
if (@available(iOS 16.1, macCatalyst 16.1, *)) {
109109
if ([self shouldAttemptSKAdNetworkCallout]) {
110110

111+
// Equivalent call [SKAdNetwork updatePostbackConversionValue:coarseValue:lockWindow:completionHandler:];
111112
((id (*)(id, SEL, NSInteger, NSString *, BOOL, void (^)(NSError *error)))[self.skAdNetworkClass methodForSelector:self.skAdNetworkUpdatePostbackConversionValueCoarseValueLockWindow])(self.skAdNetworkClass, self.skAdNetworkUpdatePostbackConversionValueCoarseValueLockWindow, fineValue, coarseValue, lockWindow, completion);
112113
}
113114
}

BranchSDK/BNCSystemObserver.m

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,7 @@ + (NSString *)appleAttributionToken {
6363
__block NSString *token = nil;
6464

6565
#if !TARGET_OS_TV
66+
#if !TARGET_OS_MACCATALYST
6667
if (@available(iOS 14.3, *)) {
6768

6869
// We are getting reports on iOS 14.5 that this API can hang, adding a short timeout for now.
@@ -83,6 +84,7 @@ + (NSString *)appleAttributionToken {
8384
BNCLogDebug([NSString stringWithFormat:@"AppleAttributionToken request timed out"]);
8485
}
8586
}
87+
#endif
8688
#endif
8789

8890
return token;

0 commit comments

Comments
 (0)