Skip to content

Commit 7ab60c1

Browse files
NidhiDixit09NidhiDixit09
committed
Release 1.45.1
1 parent 4fc2c68 commit 7ab60c1

File tree

13 files changed

+19
-49
lines changed

13 files changed

+19
-49
lines changed

‎Branch-SDK/BNCConfig.m‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,4 +11,4 @@
1111
NSString * const BNC_API_BASE_URL = @"https://api2.branch.io";
1212
NSString * const BNC_API_VERSION = @"v1";
1313
NSString * const BNC_LINK_URL = @"https://bnc.lt";
14-
NSString * const BNC_SDK_VERSION = @"1.45.0";
14+
NSString * const BNC_SDK_VERSION = @"1.45.1";

‎Branch-SDK/BranchEvent.m‎

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -80,8 +80,6 @@ - (void)processResponse:(BNCServerResponse*)response error:(NSError*)error {
8080
NSDictionary *dictionary = ([response.data isKindOfClass:[NSDictionary class]])
8181
? (NSDictionary*) response.data : nil;
8282

83-
BOOL callCompletionHandler = YES;
84-
8583
if (dictionary && [dictionary[BRANCH_RESPONSE_KEY_UPDATE_CONVERSION_VALUE] isKindOfClass:NSNumber.class]) {
8684
NSNumber *conversionValue = (NSNumber *)dictionary[BRANCH_RESPONSE_KEY_UPDATE_CONVERSION_VALUE];
8785
// Regardless of SKAN opted-in in dashboard, we always get conversionValue, so adding check to find out if install/open response had "invoke_register_app" true
@@ -94,11 +92,7 @@ - (void)processResponse:(BNCServerResponse*)response error:(NSError*)error {
9492
BNCLogDebug([NSString stringWithFormat:@"SKAN 4.0 params - conversionValue:%@ coarseValue:%@, locked:%d, shouldCallPostback:%d, currentWindow:%d, firstAppLaunchTime: %@", conversionValue, coarseConversionValue, lockWin, shouldCallUpdatePostback, (int)[BNCPreferenceHelper sharedInstance].skanCurrentWindow, [BNCPreferenceHelper sharedInstance].firstAppLaunchTime]);
9593

9694
if(shouldCallUpdatePostback){
97-
callCompletionHandler = NO;
9895
[[BNCSKAdNetwork sharedInstance] updatePostbackConversionValue: conversionValue.longValue coarseValue:coarseConversionValue lockWindow:lockWin completionHandler:^(NSError * _Nullable error) {
99-
if (self.completion) {
100-
self.completion(dictionary, error);
101-
}
10296
if (error) {
10397
BNCLogError([NSString stringWithFormat:@"Update conversion value failed with error - %@", [error description]]);
10498
} else {
@@ -109,11 +103,7 @@ - (void)processResponse:(BNCServerResponse*)response error:(NSError*)error {
109103
}
110104

111105
} else if (@available(iOS 15.4, *)) {
112-
callCompletionHandler = NO;
113106
[[BNCSKAdNetwork sharedInstance] updatePostbackConversionValue:conversionValue.intValue completionHandler: ^(NSError *error){
114-
if (self.completion) {
115-
self.completion(dictionary, error);
116-
}
117107
if (error) {
118108
BNCLogError([NSString stringWithFormat:@"Update conversion value failed with error - %@", [error description]]);
119109
} else {
@@ -128,7 +118,7 @@ - (void)processResponse:(BNCServerResponse*)response error:(NSError*)error {
128118
}
129119
}
130120

131-
if (self.completion && callCompletionHandler) {
121+
if (self.completion) {
132122
self.completion(dictionary, error);
133123
}
134124
}

‎Branch-SDK/BranchOpenRequest.m‎

Lines changed: 1 addition & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -291,35 +291,22 @@ - (void)processResponse:(BNCServerResponse *)response error:(NSError *)error {
291291
[[BNCAppGroupsData shared] saveAppClipData];
292292
}
293293

294-
BOOL callCalback = YES;
295-
296294
if ([data[BRANCH_RESPONSE_KEY_INVOKE_REGISTER_APP] isKindOfClass:NSNumber.class]) {
297295
NSNumber *invokeRegister = (NSNumber *)data[BRANCH_RESPONSE_KEY_INVOKE_REGISTER_APP];
298296
preferenceHelper.invokeRegisterApp = invokeRegister.boolValue;
299297
if (invokeRegister.boolValue && self.isInstall) {
300298
if (@available(iOS 16.1, *)){
301-
callCalback = NO;
302299
NSString *defaultCoarseConValue = [[BNCSKAdNetwork sharedInstance] getCoarseConversionValueFromDataResponse:@{}];
303300
[[BNCSKAdNetwork sharedInstance] updatePostbackConversionValue:0 coarseValue:defaultCoarseConValue
304301
lockWindow:NO completionHandler:^(NSError * _Nullable error) {
305-
306-
if(self.callback){
307-
self.callback(YES, error);
308-
}
309-
310302
if (error) {
311303
BNCLogError([NSString stringWithFormat:@"Update conversion value failed with error - %@", [error description]]);
312304
} else {
313305
BNCLogDebug([NSString stringWithFormat:@"Update conversion value was successful for INSTALL Event"]);
314306
}
315307
}];
316308
} else if (@available(iOS 15.4, *)){
317-
callCalback = NO;
318309
[[BNCSKAdNetwork sharedInstance] updatePostbackConversionValue:0 completionHandler:^(NSError * _Nullable error) {
319-
if(self.callback){
320-
self.callback(YES, error);
321-
}
322-
323310
if (error) {
324311
BNCLogError([NSString stringWithFormat:@"Update conversion value failed with error - %@", [error description]]);
325312
} else {
@@ -348,13 +335,8 @@ - (void)processResponse:(BNCServerResponse *)response error:(NSError *)error {
348335
BNCLogDebug([NSString stringWithFormat:@"SKAN 4.0 params - conversionValue:%@ coarseValue:%@, locked:%d, shouldCallPostback:%d, currentWindow:%d, firstAppLaunchTime: %@", conversionValue, coarseConversionValue, lockWin, shouldCallUpdatePostback, (int)preferenceHelper.skanCurrentWindow, preferenceHelper.firstAppLaunchTime]);
349336

350337
if(shouldCallUpdatePostback){
351-
callCalback = NO;
352338
[[BNCSKAdNetwork sharedInstance] updatePostbackConversionValue: conversionValue.longValue coarseValue:coarseConversionValue lockWindow:lockWin completionHandler:^(NSError * _Nullable error) {
353339

354-
if(self.callback){
355-
self.callback(YES, error);
356-
}
357-
358340
if (error) {
359341
BNCLogError([NSString stringWithFormat:@"Update conversion value failed with error - %@", [error description]]);
360342
} else {
@@ -363,13 +345,8 @@ - (void)processResponse:(BNCServerResponse *)response error:(NSError *)error {
363345
}];
364346
}
365347
} else if (@available(iOS 15.4, *)) {
366-
callCalback = NO;
367348
[[BNCSKAdNetwork sharedInstance] updatePostbackConversionValue:conversionValue.intValue completionHandler: ^(NSError *error){
368349

369-
if(self.callback){
370-
self.callback(YES, error);
371-
}
372-
373350
if (error) {
374351
BNCLogError([NSString stringWithFormat:@"Update conversion value failed with error - %@", [error description]]);
375352
} else {
@@ -385,7 +362,7 @@ - (void)processResponse:(BNCServerResponse *)response error:(NSError *)error {
385362
}
386363

387364

388-
if (self.callback && callCalback) {
365+
if (self.callback) {
389366
self.callback(YES, nil);
390367
}
391368
}

‎Branch-TestBed/Framework-Info.plist‎

0 Bytes
Binary file not shown.

‎Branch-TestBed/Podfile.lock‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,4 +29,4 @@ SPEC CHECKSUMS:
2929

3030
PODFILE CHECKSUM: 829cf437db3e2065c6c17ddea2f24b51cb0aecc0
3131

32-
COCOAPODS: 1.11.3
32+
COCOAPODS: 1.11.2

‎Branch.podspec‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
Pod::Spec.new do |s|
22
s.name = "Branch"
3-
s.version = "1.45.0"
3+
s.version = "1.45.1"
44
s.summary = "Create an HTTP URL for any piece of content in your app"
55
s.description = <<-DESC
66
- Want the highest possible conversions on your sharing feature?

‎ChangeLog.md‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
11
Branch iOS SDK Change Log
22

3+
v.1.45.1
4+
- SDK-1724 Branch SDK returns an error "SKANErrorDomain Code=10" in initSession function - Fix
5+
36
v.1.45.0
47
- SDK-1659 SKAN 4.0 Support
58
* Support for coarse-grained conversion value

‎carthage-files/BranchSDK.xcodeproj/project.pbxproj‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1723,7 +1723,7 @@
17231723
INFOPLIST_FILE = "Branch-tvOS/Info.plist";
17241724
INSTALL_PATH = "$(LOCAL_LIBRARY_DIR)/Frameworks";
17251725
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks @loader_path/Frameworks";
1726-
MARKETING_VERSION = 1.45.0;
1726+
MARKETING_VERSION = 1.45.1;
17271727
MTL_ENABLE_DEBUG_INFO = INCLUDE_SOURCE;
17281728
MTL_FAST_MATH = YES;
17291729
ONLY_ACTIVE_ARCH = YES;
@@ -1760,7 +1760,7 @@
17601760
INFOPLIST_FILE = "Branch-tvOS/Info.plist";
17611761
INSTALL_PATH = "$(LOCAL_LIBRARY_DIR)/Frameworks";
17621762
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks @loader_path/Frameworks";
1763-
MARKETING_VERSION = 1.45.0;
1763+
MARKETING_VERSION = 1.45.1;
17641764
MTL_FAST_MATH = YES;
17651765
ONLY_ACTIVE_ARCH = NO;
17661766
PRODUCT_BUNDLE_IDENTIFIER = io.branch.Branch;
@@ -1792,7 +1792,7 @@
17921792
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks @loader_path/Frameworks";
17931793
MACH_O_TYPE = staticlib;
17941794
MACOSX_DEPLOYMENT_TARGET = 10.15;
1795-
MARKETING_VERSION = 1.45.0;
1795+
MARKETING_VERSION = 1.45.1;
17961796
ONLY_ACTIVE_ARCH = YES;
17971797
OTHER_LDFLAGS = "-ObjC";
17981798
PRODUCT_BUNDLE_IDENTIFIER = io.branch.Branch;
@@ -1821,7 +1821,7 @@
18211821
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks @loader_path/Frameworks";
18221822
MACH_O_TYPE = staticlib;
18231823
MACOSX_DEPLOYMENT_TARGET = 10.15;
1824-
MARKETING_VERSION = 1.45.0;
1824+
MARKETING_VERSION = 1.45.1;
18251825
ONLY_ACTIVE_ARCH = NO;
18261826
OTHER_LDFLAGS = "-ObjC";
18271827
PRODUCT_BUNDLE_IDENTIFIER = io.branch.Branch;
@@ -1976,7 +1976,7 @@
19761976
IPHONEOS_DEPLOYMENT_TARGET = 11.0;
19771977
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks @loader_path/Frameworks";
19781978
MACOSX_DEPLOYMENT_TARGET = 10.15;
1979-
MARKETING_VERSION = 1.45.0;
1979+
MARKETING_VERSION = 1.45.1;
19801980
ONLY_ACTIVE_ARCH = YES;
19811981
OTHER_LDFLAGS = "-ObjC";
19821982
PRODUCT_BUNDLE_IDENTIFIER = io.branch.Branch;
@@ -2003,7 +2003,7 @@
20032003
IPHONEOS_DEPLOYMENT_TARGET = 11.0;
20042004
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks @loader_path/Frameworks";
20052005
MACOSX_DEPLOYMENT_TARGET = 10.15;
2006-
MARKETING_VERSION = 1.45.0;
2006+
MARKETING_VERSION = 1.45.1;
20072007
ONLY_ACTIVE_ARCH = NO;
20082008
OTHER_LDFLAGS = "-ObjC";
20092009
PRODUCT_BUNDLE_IDENTIFIER = io.branch.Branch;

‎carthage-files/checksum.txt‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
11
#checksum for Branch on Github
2-
5d75f23b55191b3dcd228ab68ee86f114374ba58 Branch.zip
2+
e70c48a4db12cf3ee332dc843f5be2f7ae0f2802 Branch.zip

‎carthage-files/checksum_noidfa.txt‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
11
#checksum for Branch on Github
2-
39b232f7bf1d8333e6983090db8005747cccbd57 Branch_noidfa.zip
2+
50db8dd781102e1c47a77c228aeb036258abe439 Branch_noidfa.zip

0 commit comments

Comments
 (0)