Drop temp var in loops

This was fixed in Go 1.22, see: https://go.dev/blog/loopvar-preview

Author: Brawl345

bot/processor.go

@@ -104,10 +104,7 @@ func (p *Processor) onMessage(b *gotgbot.Bot, ctx *ext.Context) error {
 	text := msg.GetText()
 
 	for _, plg := range p.managerService.Plugins() {
-		plg := plg
 		for _, h := range plg.Handlers(&b.User) {
-			h := h
-
 			handler, ok := h.(*plugin.CommandHandler)
 			if !ok {
 				continue
@@ -249,10 +246,7 @@ func (p *Processor) onCallback(b *gotgbot.Bot, ctx *ext.Context) error {
 	}
 
 	for _, plg := range p.managerService.Plugins() {
-		plg := plg
 		for _, h := range plg.Handlers(&b.User) {
-			h := h
-
 			handler, ok := h.(*plugin.CallbackHandler)
 			if !ok {
 				continue
@@ -371,9 +365,7 @@ func (p *Processor) onInlineQuery(b *gotgbot.Bot, ctx *ext.Context) error {
 	}
 
 	for _, plg := range p.managerService.Plugins() {
-		plg := plg
 		for _, h := range plg.Handlers(&b.User) {
-			h := h
 			handler, ok := h.(*plugin.InlineHandler)
 			if !ok {
 				continue

plugin/expand/expand.go

@@ -134,7 +134,6 @@ func onExpand(b *gotgbot.Bot, c plugin.GobotContext) error {
 	var sb strings.Builder
 
 	for _, url := range shortUrls {
-		url := url
 		if !strings.HasPrefix(url, "http://") && !strings.HasPrefix(url, "https://") {
 			url = fmt.Sprintf("http://%s", url)
 		}

plugin/reminders/reminders.go

@@ -46,7 +46,6 @@ func New(bot *gotgbot.Bot, service Service) *Plugin {
 	}
 
 	for _, reminder := range reminders {
-		reminder := reminder
 		if time.Now().After(reminder.Time) {
 			p.sendReminder(bot, reminder.ID)
 		} else {

plugin/youtube/api.go

@@ -121,7 +121,6 @@ func (d *DeArrowResponse) GetBestTitle() string {
 	maxVotes := -1
 	var title string
 	for _, t := range d.Titles {
-		t := t
 		if t.Votes > maxVotes && !t.Original {
 			maxVotes = t.Votes
 			title = t.Title

utils/tgUtils/utils.go

@@ -75,7 +75,6 @@ func GetBestResolution(photo []gotgbot.PhotoSize) *gotgbot.PhotoSize {
 	var filesize int64
 	var bestResolution *gotgbot.PhotoSize
 	for _, photoSize := range photo {
-		photoSize := photoSize
 		if photoSize.FileSize > filesize {
 			filesize = photoSize.FileSize
 			bestResolution = &photoSize