Skip to content

Commit 43871de

Browse files
committed
refactor: cleanup
1 parent 630300a commit 43871de

File tree

5 files changed

+195
-183
lines changed

5 files changed

+195
-183
lines changed

compositor/operator.py

Lines changed: 11 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -93,13 +93,15 @@ def _process_node(self, node: Node, ntp_nt: NTP_NodeTree, inner: str):
9393

9494
if node.bl_idname == 'CompositorNodeGroup':
9595
self._process_group_node_tree(node, node_var, inner)
96-
elif node.bl_idname == 'NodeGroupInput' and not ntp_nt.inputs_set:
97-
self._group_io_settings(node, inner, "input", ntp_nt)
98-
ntp_nt.inputs_set = True
9996

100-
elif node.bl_idname == 'NodeGroupOutput' and not ntp_nt.outputs_set:
101-
self._group_io_settings(node, inner, "output", ntp_nt)
102-
ntp_nt.outputs_set = True
97+
if bpy.app.version < (4, 0, 0):
98+
if node.bl_idname == 'NodeGroupInput' and not ntp_nt.inputs_set:
99+
self._group_io_settings(node, inner, "input", ntp_nt)
100+
ntp_nt.inputs_set = True
101+
102+
elif node.bl_idname == 'NodeGroupOutput' and not ntp_nt.outputs_set:
103+
self._group_io_settings(node, inner, "output", ntp_nt)
104+
ntp_nt.outputs_set = True
103105

104106
self._set_socket_defaults(node, node_var, inner)
105107

@@ -124,6 +126,9 @@ def _process_node_tree(self, node_tree, level):
124126
ntp_nt = NTP_NodeTree(node_tree, nt_var)
125127
self._initialize_compositor_node_tree(outer, ntp_nt, nt_name)
126128

129+
if bpy.app.version >= (4, 0, 0):
130+
self._tree_interface_settings(inner, ntp_nt)
131+
127132
#initialize nodes
128133
self._write(f"{inner}#initialize {nt_var} nodes\n")
129134

geometry/operator.py

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -69,16 +69,18 @@ def _process_node(self, node: Node, ntp_node_tree: NTP_GeoNodeTree,
6969
#create node
7070
node_var: str = self._create_node(node, inner, ntp_node_tree.var)
7171
self._set_settings_defaults(node, inner, node_var)
72-
if node.bl_idname == 'GeometryNodeGroup':
73-
self._process_group_node_tree(node, node_var, inner)
7472

75-
elif node.bl_idname == 'NodeGroupInput' and not ntp_node_tree.inputs_set:
76-
self._group_io_settings(node, inner, "input", ntp_node_tree)
77-
ntp_node_tree.inputs_set = True
73+
if bpy.app.version < (4, 0, 0):
74+
if node.bl_idname == 'NodeGroupInput' and not ntp_node_tree.inputs_set:
75+
self._group_io_settings(node, inner, "input", ntp_node_tree)
76+
ntp_node_tree.inputs_set = True
77+
78+
elif node.bl_idname == 'NodeGroupOutput' and not ntp_node_tree.outputs_set:
79+
self._group_io_settings(node, inner, "output", ntp_node_tree)
80+
ntp_node_tree.outputs_set = True
7881

79-
elif node.bl_idname == 'NodeGroupOutput' and not ntp_node_tree.outputs_set:
80-
self._group_io_settings(node, inner, "output", ntp_node_tree)
81-
ntp_node_tree.outputs_set = True
82+
if node.bl_idname == 'GeometryNodeGroup':
83+
self._process_group_node_tree(node, node_var, inner)
8284

8385
elif node.bl_idname == 'GeometryNodeSimulationInput':
8486
ntp_node_tree.sim_inputs.append(node)
@@ -169,7 +171,7 @@ def _process_node_tree(self, node_tree: GeometryNodeTree,
169171
ntp_nt = NTP_GeoNodeTree(node_tree, nt_var)
170172

171173
if bpy.app.version >= (4, 0, 0):
172-
self._tree_interface_settings_v4(inner, ntp_nt)
174+
self._tree_interface_settings(inner, ntp_nt)
173175

174176
for node in node_tree.nodes:
175177
self._process_node(node, ntp_nt, inner)

material/operator.py

Lines changed: 13 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -65,16 +65,18 @@ def _process_node(self, node: Node, ntp_node_tree: NTP_NodeTree, inner: str) ->
6565
"""
6666
node_var: str = self._create_node(node, inner, ntp_node_tree.var)
6767
self._set_settings_defaults(node, inner, node_var)
68-
68+
69+
if bpy.app.version < (4, 0, 0):
70+
if node.bl_idname == 'NodeGroupInput' and not ntp_node_tree.inputs_set:
71+
self._group_io_settings(node, inner, "input", ntp_node_tree)
72+
ntp_node_tree.inputs_set = True
73+
74+
elif node.bl_idname == 'NodeGroupOutput' and not ntp_node_tree.outputs_set:
75+
self._group_io_settings(node, inner, "output", ntp_node_tree)
76+
ntp_node_tree.outputs_set = True
77+
6978
if node.bl_idname == 'ShaderNodeGroup':
7079
self._process_group_node_tree(node, node_var, inner)
71-
elif node.bl_idname == 'NodeGroupInput' and not ntp_node_tree.inputs_set:
72-
self._group_io_settings(node, inner, "input", ntp_node_tree)
73-
ntp_node_tree.inputs_set = True
74-
75-
elif node.bl_idname == 'NodeGroupOutput' and not ntp_node_tree.outputs_set:
76-
self._group_io_settings(node, inner, "output", ntp_node_tree)
77-
ntp_node_tree.outputs_set = True
7880

7981
self._hide_hidden_sockets(node, inner, node_var)
8082
self._set_socket_defaults(node, node_var, inner)
@@ -102,6 +104,9 @@ def _process_node_tree(self, node_tree: ShaderNodeTree, level: int) -> None:
102104

103105
self._initialize_shader_node_tree(outer, ntp_nt, nt_name)
104106

107+
if bpy.app.version >= (4, 0, 0):
108+
self._tree_interface_settings(inner, ntp_nt)
109+
105110
#initialize nodes
106111
self._write(f"{inner}#initialize {nt_var} nodes\n")
107112

ntp_node_tree.py

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
from bpy.types import NodeTree
2+
import bpy
23

34
class NTP_NodeTree:
45
def __init__(self, node_tree: NodeTree, var: str):
@@ -8,7 +9,8 @@ def __init__(self, node_tree: NodeTree, var: str):
89
# The variable named for the regenerated node tree
910
self.var: str = var
1011

11-
# Keep track of if we need to set the default values for the node
12-
# tree inputs and outputs
13-
self.inputs_set: bool = False
14-
self.outputs_set: bool = False
12+
if bpy.app.version < (4, 0, 0):
13+
# Keep track of if we need to set the default values for the node
14+
# tree inputs and outputs
15+
self.inputs_set: bool = False
16+
self.outputs_set: bool = False

0 commit comments

Comments
 (0)