Skip to content

Commit 0b9b033

Browse files
authored
Merge pull request #2857 from erikdarlingdata/issue_2816
Fix for 2816
2 parents 20d0944 + 67f2764 commit 0b9b033

File tree

1 file changed

+20
-16
lines changed

1 file changed

+20
-16
lines changed

sp_BlitzCache.sql

Lines changed: 20 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -6942,20 +6942,23 @@ ELSE
69426942

69436943
IF @ValidOutputLocation = 1
69446944
BEGIN
6945-
SET @StringToExecute = 'USE '
6945+
SET @StringToExecute = N'USE '
69466946
+ @OutputDatabaseName
6947-
+ '; IF EXISTS(SELECT * FROM '
6947+
+ N'; IF EXISTS(SELECT * FROM '
69486948
+ @OutputDatabaseName
6949-
+ '.INFORMATION_SCHEMA.SCHEMATA WHERE QUOTENAME(SCHEMA_NAME) = '''
6949+
+ N'.INFORMATION_SCHEMA.SCHEMATA WHERE QUOTENAME(SCHEMA_NAME) = '''
69506950
+ @OutputSchemaName
6951-
+ ''') AND NOT EXISTS (SELECT * FROM '
6951+
+ N''') AND NOT EXISTS (SELECT * FROM '
69526952
+ @OutputDatabaseName
6953-
+ '.INFORMATION_SCHEMA.TABLES WHERE QUOTENAME(TABLE_SCHEMA) = '''
6954-
+ @OutputSchemaName + ''' AND QUOTENAME(TABLE_NAME) = '''
6955-
+ @OutputTableName + ''') CREATE TABLE '
6956-
+ @OutputSchemaName + '.'
6953+
+ N'.INFORMATION_SCHEMA.TABLES WHERE QUOTENAME(TABLE_SCHEMA) = '''
6954+
+ @OutputSchemaName + N''' AND QUOTENAME(TABLE_NAME) = '''
6955+
+ @OutputTableName + N''') CREATE TABLE '
6956+
+ @OutputSchemaName + N'.'
69576957
+ @OutputTableName
6958-
+ N'(ID bigint NOT NULL IDENTITY(1,1),
6958+
+ CONVERT
6959+
(
6960+
nvarchar(MAX),
6961+
N'(ID bigint NOT NULL IDENTITY(1,1),
69596962
ServerName NVARCHAR(258),
69606963
CheckDate DATETIMEOFFSET,
69616964
Version NVARCHAR(258),
@@ -7031,27 +7034,28 @@ ELSE
70317034
AvgSpills MONEY,
70327035
QueryPlanCost FLOAT,
70337036
JoinKey AS ServerName + Cast(CheckDate AS NVARCHAR(50)),
7034-
CONSTRAINT [PK_' + REPLACE(REPLACE(@OutputTableName,'[',''),']','') + '] PRIMARY KEY CLUSTERED(ID ASC));';
7037+
CONSTRAINT [PK_' + REPLACE(REPLACE(@OutputTableName,N'[',N''),N']',N'') + N'] PRIMARY KEY CLUSTERED(ID ASC));'
7038+
);
70357039

70367040
SET @StringToExecute += N'IF EXISTS(SELECT * FROM '
70377041
+@OutputDatabaseName
70387042
+N'.INFORMATION_SCHEMA.SCHEMATA WHERE QUOTENAME(SCHEMA_NAME) = '''
70397043
+@OutputSchemaName
7040-
+''') AND EXISTS (SELECT * FROM '
7044+
+N''') AND EXISTS (SELECT * FROM '
70417045
+@OutputDatabaseName+
70427046
N'.INFORMATION_SCHEMA.TABLES WHERE QUOTENAME(TABLE_SCHEMA) = '''
70437047
+@OutputSchemaName
7044-
+''' AND QUOTENAME(TABLE_NAME) = '''
7048+
+N''' AND QUOTENAME(TABLE_NAME) = '''
70457049
+@OutputTableName
7046-
+''') AND EXISTS (SELECT * FROM '
7050+
+N''') AND EXISTS (SELECT * FROM '
70477051
+@OutputDatabaseName+
70487052
N'.sys.computed_columns WHERE [name] = N''PlanCreationTimeHours'' AND QUOTENAME(OBJECT_NAME(object_id)) = N'''
70497053
+@OutputTableName
7050-
+''' AND [definition] = N''(datediff(hour,[PlanCreationTime],sysdatetime()))'')
7054+
+N''' AND [definition] = N''(datediff(hour,[PlanCreationTime],sysdatetime()))'')
70517055
BEGIN
70527056
RAISERROR(''We noticed that you are running an old computed column definition for PlanCreationTimeHours, fixing that now'',0,0) WITH NOWAIT;
7053-
ALTER TABLE '+@OutputDatabaseName+'.'+@OutputSchemaName+'.'+@OutputTableName+' DROP COLUMN [PlanCreationTimeHours];
7054-
ALTER TABLE '+@OutputDatabaseName+'.'+@OutputSchemaName+'.'+@OutputTableName+' ADD [PlanCreationTimeHours] AS DATEDIFF(HOUR,CONVERT(DATETIMEOFFSET(7),[PlanCreationTime]),[CheckDate]);
7057+
ALTER TABLE '+@OutputDatabaseName+N'.'+@OutputSchemaName+N'.'+@OutputTableName+N' DROP COLUMN [PlanCreationTimeHours];
7058+
ALTER TABLE '+@OutputDatabaseName+N'.'+@OutputSchemaName+N'.'+@OutputTableName+N' ADD [PlanCreationTimeHours] AS DATEDIFF(HOUR,CONVERT(DATETIMEOFFSET(7),[PlanCreationTime]),[CheckDate]);
70557059
END ';
70567060

70577061
IF @ValidOutputServer = 1

0 commit comments

Comments
 (0)