#2847 Fix negative CHARINDEX result when ) precedes (

PeteSral · PeteSral · commit 1901057e4e55 · 2021-03-27T14:31:13.000-05:00
Setting the `starting_position` of the `(` found when retrieving the closing `)` will keep us out of the negative sub-string length.
diff --git a/sp_BlitzCache.sql b/sp_BlitzCache.sql
@@ -3982,7 +3982,7 @@ SET    s.variable_datatype = CASE WHEN s.variable_datatype LIKE '%(%)%'
 	   s.compile_time_value = CASE WHEN s.compile_time_value LIKE '%(%)%' 
                                    THEN SUBSTRING(s.compile_time_value, 
 												  CHARINDEX('(', s.compile_time_value) + 1,
-												  CHARINDEX(')', s.compile_time_value) - 1 - CHARINDEX('(', s.compile_time_value)
+												  CHARINDEX(')', s.compile_time_value, CHARINDEX('(', s.compile_time_value) + 1) - 1 - CHARINDEX('(', s.compile_time_value)
 												  )
 									WHEN variable_datatype NOT IN ('bit', 'tinyint', 'smallint', 'int', 'bigint') 
 									AND s.variable_datatype NOT LIKE '%binary%' 

Original file line number	Diff line number	Diff line change
`@@ -3982,7 +3982,7 @@ SET s.variable_datatype = CASE WHEN s.variable_datatype LIKE '%(%)%'`
`3982`	`3982`	`s.compile_time_value = CASE WHEN s.compile_time_value LIKE '%(%)%'`
`3983`	`3983`	`THEN SUBSTRING(s.compile_time_value,`
`3984`	`3984`	`CHARINDEX('(', s.compile_time_value) + 1,`
`3985`		`- CHARINDEX(')', s.compile_time_value) - 1 - CHARINDEX('(', s.compile_time_value)`
	`3985`	`+ CHARINDEX(')', s.compile_time_value, CHARINDEX('(', s.compile_time_value) + 1) - 1 - CHARINDEX('(', s.compile_time_value)`
`3986`	`3986`	`)`
`3987`	`3987`	`WHEN variable_datatype NOT IN ('bit', 'tinyint', 'smallint', 'int', 'bigint')`
`3988`	`3988`	`AND s.variable_datatype NOT LIKE '%binary%'`