Merge remote-tracking branch 'upstream/master'

Author: dalehhirt

.editorconfig

@@ -0,0 +1,14 @@
+# http://editorconfig.org
+root = true
+
+[*]
+indent_style = tab
+end_of_line = crlf
+charset = utf-8
+indent_size = 4
+trim_trailing_whitespace = true
+insert_final_newline = true
+
+[*.md]
+trim_trailing_whitespace = false
+insert_final_newline = false

.github/ISSUE_TEMPLATE.md

@@ -0,0 +1,10 @@
+**Do you want to request a *feature* or report a *bug*?**
+If you're reporting a bug, include the version number of the script you're using. If it's not the current version, upgrade to the current version and test that before reporting a bug - we fix a lot of stuff in each new build.
+
+**What is the current behavior?**
+
+**If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem via http://sqlfiddle.com**
+
+**What is the expected behavior?**
+
+**Which versions of SQL Server and which OS are affected by this issue? Did this work in previous versions of our procedures?**

.github/PULL_REQUEST_TEMPLATE.md

@@ -0,0 +1,21 @@
+Fixes # .
+
+Changes proposed in this pull request:
+ - 
+ - 
+ - 
+
+How to test this code:
+ - 
+ - 
+ - 
+
+Has been tested on (remove any that don't apply):
+ - Case-sensitive SQL Server instance
+ - SQL Server 2008
+ - SQL Server 2008 R2
+ - SQL Server 2012
+ - SQL Server 2014
+ - SQL Server 2016
+ - Amazon RDS
+ - Azure SQL DB

CONTRIBUTING.md

@@ -7,14 +7,15 @@ First of all, welcome! We're excited that you'd like to contribute. How would yo
 * [I'd like to fix bugs in T-SQL checks](#how-to-fix-bugs-in-existing-t-sql-checks)
 * [I'd like to test checks written by someone else](#how-to-test-checks-written-by-someone-else)
 * [I'd like to write or update documentation](#how-to-write-or-update-documentation)
+* [I don't know how to upload code to GitHub](https://www.brentozar.com/archive/2015/07/pull-request-101-for-dbas-using-github/)
 
 Everyone here is expected to abide by the [Contributor Covenant Code of Conduct](#the-contributor-covenant-code-of-conduct).
 
-Wanna do something else, or have a question not answered here? Hop into Slack and ask us questions before you get started. [Join SQLServer.slack.com](https://sql-server-slack.herokuapp.com/), and we're in the [#FirstResponderKit channel](https://sqlserver.slack.com/messages/firstresponderkit/). We welcome newcomers, and there's always a way you can help.
+Wanna do something else, or have a question not answered here? Hop into Slack and ask us questions before you get started. [Get an invite to SQLCommunity.slack.com](https://sqlps.io/slack/), and we're in the [#FirstResponderKit channel](https://sqlcommunity.slack.com/messages/firstresponderkit/). We welcome newcomers, and there's always a way you can help.
 
 ## How to Report Bugs or Request Enhancements
 
-[Check out the Github issues list.](https://github.com/BrentOzarULTD/SQL-Server-First-Responder-Kit/issues) Search for what you're interested in - there may already be an issue for it. Make sure to search through closed issues, too, because we often decline things that aren't a good fit for these tools.
+Check out the [Github issues list]. Search for what you're interested in - there may already be an issue for it. Make sure to search through closed issues, too, because we often decline things that aren't a good fit for these tools.
 
 If you can't find a similar issue, go ahead and open your own. Include as much detail as you can - what you're seeing now, and what you'd like to see.
 
@@ -24,11 +25,11 @@ When requesting new checks, keep in mind that we want to focus on:
 * Performance issues or reliability risks - if it's just a setting we don't agree with, let's set that aside
 * Things that end users or managers will notice - if we're going to have someone change a setting on their system, we want it to be worth their time
 
-Now [head on over to the Github issues list](https://github.com/BrentOzarULTD/SQL-Server-First-Responder-Kit/issues) and get started.
+Now head on over to the [Github issues list] and get started.
 
 ## How to Write New T-SQL Checks
 
-Before you code, check the [Github issues list](https://github.com/BrentOzarULTD/SQL-Server-First-Responder-Kit/issues) for what you're trying to do - there may already be an issue for it. Make sure to search through closed issues, too, because we often decline things that aren't a good fit for these tools.
+Before you code, check the [Github issues list] for what you're trying to do - there may already be an issue for it. Make sure to search through closed issues, too, because we often decline things that aren't a good fit for these tools.
 
 If you've got a new idea that isn't covered in an existing issue, open a Github issue for it. Outline what you'd like to do, and how you'd like to code it. This just helps make sure other users agree that it's a good idea to add to these tools.
 
@@ -100,5 +101,61 @@ Project maintainers who do not follow or enforce the Code of Conduct in good fai
 This Code of Conduct is adapted from the [Contributor Covenant][homepage], version 1.4,
 available at [http://contributor-covenant.org/version/1/4][version]
 
+
+## Git Flow for pull requests
+<a name="git-flow"></a>
+
+1. [Fork] the project, clone your fork, and configure the remotes:
+
+   ```bash
+   # Clone your fork of the repo into the current directory
+   git clone [email protected]:<YOUR_USERNAME>/SQL-Server-First-Responder-Kit.git
+   # Navigate to the newly cloned directory
+   cd SQL-Server-First-Responder-Kit
+   # Assign the original repo to a remote called "upstream"
+   git remote add upstream https://github.com/BrentOzarULTD/SQL-Server-First-Responder-Kit/
+   ```
+
+2. If you cloned a while ago, get the latest changes from upstream:
+
+   ```bash
+   git checkout master
+   git pull upstream master
+   ```
+
+3. Create a new topic branch (off the main project development branch) to
+   contain your feature, change, or fix:
+
+   ```bash
+   git checkout -b <topic-branch-name>
+   ```
+
+4. Commit your changes in logical chunks. Please adhere to these [git commit message guidelines]
+   or your code is unlikely be merged into the main project. Use Git's [interactive rebase]
+   feature to tidy up your commits before making them public.
+
+5. Locally merge (or rebase) the upstream development branch into your topic branch:
+
+   ```bash
+   git pull [--rebase] upstream master
+   ```
+
+6. Push your topic branch up to your fork:
+
+   ```bash
+   git push origin <topic-branch-name>
+   ```
+
+7. [Open a Pull Request] with a clear title and description.
+
+**IMPORTANT**: By submitting a patch, you agree to allow the project owner to license your work under the MIT [LICENSE]
+
+
 [homepage]: http://contributor-covenant.org
-[version]: http://contributor-covenant.org/version/1/4/
+[version]: http://contributor-covenant.org/version/1/4/
+[Github issues list]:https://github.com/BrentOzarULTD/SQL-Server-First-Responder-Kit/issues
+[Fork]:https://help.github.com/articles/fork-a-repo/
+[git commit message guidelines]:http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html
+[interactive rebase]:https://help.github.com/articles/about-git-rebase/
+[Open a Pull Request]:https://help.github.com/articles/about-pull-requests/
+[LICENSE]:https://github.com/BrentOzarULTD/SQL-Server-First-Responder-Kit/blob/master/LICENSE.md

sp_BlitzRS.sql Deprecated/sp_BlitzRS.sqlsp_BlitzRS.sql renamed to Deprecated/sp_BlitzRS.sql

@@ -497,7 +497,7 @@ IF OBJECT_ID('tempdb..#RoleTaskMask') IS NOT NULL
 
 CREATE TABLE #RoleTaskMask
     (
-      RoleName NVARCHAR(32) ,
+      RoleName NVARCHAR(260) ,
       RoleFlags TINYINT ,
       TaskMaskPos TINYINT ,
       TaskMaskValue TINYINT

sp_BlitzTrace.sql Deprecated/sp_BlitzTrace.sqlsp_BlitzTrace.sql renamed to Deprecated/sp_BlitzTrace.sql

@@ -7,10 +7,11 @@ SET QUOTED_IDENTIFIER ON;
 SET STATISTICS IO OFF;
 SET STATISTICS TIME OFF;
 GO
-IF OBJECT_ID('dbo.sp_BlitzTrace') IS NOT NULL
-    DROP PROCEDURE dbo.sp_BlitzTrace
+IF OBJECT_ID('dbo.sp_BlitzTrace') IS  NULL
+    EXEC ('CREATE PROCEDURE dbo.sp_BlitzTrace AS RETURN 0');
 GO
-CREATE PROCEDURE dbo.sp_BlitzTrace
+
+ALTER PROCEDURE dbo.sp_BlitzTrace
     @Debug BIT = 0 , /* 1 prints the statement and won't execute it */
     @SessionId INT = NULL ,
     @Action VARCHAR(5) = NULL ,  /* 'start', 'read', 'stop', 'drop'*/
@@ -59,7 +60,7 @@ Known limitations of this version:
 Unknown limitations of this version:
  - Probably a lot. This is one of our lesser-tested scripts.
 
-Changes in v1.0 - YYYY/MM/DD
+Changes in v1.0 - 2016/06/26
  - Switched to MIT licensing.
  - Added @Help parameter.
 

Documentation/Development/Merge Blitz.ps1

@@ -0,0 +1,8 @@
+#All Core Blitz Without sp_BlitzQueryStore
+Get-ChildItem -Path "C:\Users\$env:username\Documents\GitHub\PublicTools\*" -Include sp_Blitz*.sql -Exclude sp_BlitzQueryStore.sql | ForEach-Object { Get-Content $_.FullName } | Set-Content -Path "C:\Users\$env:username\Documents\GitHub\PublicTools\Install-Core-Blitz-No-Query-Store.sql" -Force
+
+#All Core Blitz With sp_BlitzQueryStore
+Get-ChildItem -Path "C:\Users\$env:username\Documents\GitHub\PublicTools\*" -Include sp_Blitz*.sql | ForEach-Object { Get-Content $_.FullName } | Set-Content -Path "C:\Users\$env:username\Documents\GitHub\PublicTools\Install-Core-Blitz-With-Query-Store.sql" -Force
+
+#All Scripts
+Get-ChildItem -Path "C:\Users\$env:username\Documents\GitHub\PublicTools\*" -Include sp_*.sql | ForEach-Object { Get-Content $_.FullName } | Set-Content -Path "C:\Users\$env:username\Documents\GitHub\PublicTools\Install-All-Scripts.sql" -Force

Documentation/Development/ReleaseProcess.md

@@ -0,0 +1,49 @@
+# First Responder Kit Release Process
+
+From http://FirstResponderKit.org
+
+This doc explains how to do a release of the First Responder Kit scripts.
+
+It's for internal use at BrentOzar.com, but other folks might find it useful.
+
+Well, useful is probably the wrong word. More like entertaining. Here we go.
+
+## Preparations
+
+* Create a Milestone to tag issues/PRs as you work on them. In Github, go into Issues, Milestones (button at the top), and add a new milestone named YYYY-MM, like 2017-01.
+* As you merge pull requests into the dev branch (or before), tag them with the milestone. This makes it easy to find the related issues when you go to write release notes.
+
+
+## Finalize and Test the Code
+
+* Make sure all issues in the milestone are closed - click Issues, Milestones, and it'll show the percent complete. If there's any issues you want to bump to the next round, add the next round's milestone and tag the issues with it.
+* When enough PRs are in dev, do a round of code testing in 2008-2016 in the cloud lab.
+    * Merge scripts into three files:
+        * Runs command in Merge Blitz.ps1
+        * These get moved to AWS for testing
+    * Run _TestBed.sql: this has stored proc calls with common parameters. May have to add in new scenarios if new features are added. 
+* If it passes, bump all the version numbers inside the scripts and re-run the PowerShell commands so combined scripts reflect correct version and date.
+    * sp_foreachdb @Version and @VersionDate
+    * sp_BlitzWho @Version and @VersionDate
+    * sp_BlitzIndex @Version and @VersionDate
+    * sp_BlitzFirst @VersionDate (no version) 
+    * sp_BlitzCache @Version and @VersionDate 
+    * sp_Blitz @Version and @VersionDate
+    * sp_DatabaseRestore @Version and @VersionDate
+    * sp_BlitzBackups @Version and @VersionDate
+    * sp_BlitzQueryStore @Version and @VersionDate
+    * sp_AllNightLog @Version and @VersionDate
+    * sp_AllNightLog_Setup @Version and @VersionDate
+
+## Push to Master
+
+* Push to the master branch from dev. (Make sure you're pushing FROM dev, TO master.)
+* Draft a new release. Click Code, Releases, and edit one of the recent releases to get the Markdown syntax. Copy/paste that into a new release, and put the issue numbers for the relevant changes.
+* Publish the release pointing at the current master branch code (not dev).
+
+## Announce It
+
+* Copy the FRK scripts into BrentOzar.com's First Responder Kit zip file (Employees/Products/First Responder Kit/FirstResponderKit.zip)
+* Copy the FirstResponderKit.zip into Employees/Public.BrentOzar
+* Copy the Github release text into a WordPress blog post with the First Responder Kit category. The nice thing about doing the Github release first is that you should be able to copy/paste the Github release page and the HTML should paste smoothly into the WordPress draft window, complete with links to the Github issues. At the end of the post, put a download now link that points to: https://www.brentozar.com/first-aid/
+

Documentation/Development/Test sp_DatabaseRestore.sql

@@ -0,0 +1,70 @@
+DECLARE @database_name NVARCHAR(MAX), @backup_path NVARCHAR(MAX), @i INT
+
+SET @database_name = 'ENTER YOUR DATABASE NAME'
+SET @backup_path = 'Path to your Ola Backups ROOT FOLDER (see the db name will be attached later)'
+SET @i = 0
+
+EXECUTE dbo.DatabaseBackup
+@Databases = @database_name,
+@Directory = @backup_path,
+@BackupType = 'FULL',
+@Verify = 'Y',
+@Compress = 'Y',
+@CheckSum = 'Y',
+@CleanupTime = 24
+
+/*Why do I add delays, IDK just wanted to make sure streams do not get crossed */
+WAITFOR DELAY '00:00:30'
+
+EXECUTE dbo.DatabaseBackup
+@Databases = @database_name,
+@Directory = @backup_path,
+@BackupType = 'DIFF',
+@Verify = 'Y',
+@Compress = 'Y',
+@CheckSum = 'Y',
+@CleanupTime = 24
+
+WAITFOR DELAY '00:00:30'
+
+WHILE (@i <= 10)
+BEGIN
+SET @i += 1
+EXECUTE dbo.DatabaseBackup
+@Databases = @database_name,
+@Directory = @backup_path,
+@BackupType = 'LOG',
+@Verify = 'Y',
+@Compress = 'Y',
+@CheckSum = 'Y',
+@CleanupTime = 24
+WAITFOR DELAY '00:00:03'
+END
+
+DECLARE @cmd NVARCHAR(4000), @BackupPathDiff NVARCHAR(MAX), @PointInTime NVARCHAR(4000), @full_path NVARCHAR(MAX), @diff_path VARCHAR(MAX), @log_path VARCHAR(MAX)
+DECLARE @FileList TABLE (BackupFile NVARCHAR(255))
+SET @full_path = @backup_path + '\' + @database_name + '\FULL\'
+SET @diff_path = @backup_path + '\' + @database_name + '\DIFF\'
+SET @log_path =  @backup_path + '\' + @database_name + '\LOG\'
+
+-- get list of files 
+SET @cmd = 'DIR /b "'+ @log_path + '"';
+INSERT INTO @FileList (BackupFile)
+EXEC master.sys.xp_cmdshell @cmd; 
+
+SET @PointInTime = (SELECT TOP 1 * FROM @FileList ORDER BY NEWID())
+SET @PointInTime = REPLACE(LEFT(RIGHT(@PointInTime, 19),15), '_', '')
+PRINT @full_path
+PRINT @diff_path
+PRINT @log_path
+
+EXEC dbo.sp_DatabaseRestore 
+	@Database = @database_name, 
+	@BackupPathFull = @full_path, 
+	@BackupPathDiff = @diff_path,
+	@BackupPathLog = @log_path, 
+	@RestoreDiff = 1,
+	@ContinueLogs = 0, 
+	@RunRecovery = 1,
+	@StopAt = @PointInTime,
+	@Debug = 1;

Documentation/Development/_TestBed.sql

@@ -0,0 +1,48 @@
+/*Blitz*/
+EXEC sp_Blitz @CheckUserDatabaseObjects = 1, @CheckServerInfo = 1
+
+EXEC sp_Blitz @CheckUserDatabaseObjects = 1, @CheckServerInfo = 1, @OutputDatabaseName = 'ChangeMe', @OutputSchemaName = 'dbo', @OutputTableName = 'Blitz'
+
+EXEC sp_Blitz @CheckUserDatabaseObjects = 1, @CheckServerInfo = 1, @Debug = 1
+
+EXEC sp_Blitz @CheckUserDatabaseObjects = 1, @CheckServerInfo = 1, @Debug = 2
+
+/*BlitzFirst*/
+EXEC sp_BlitzFirst @Seconds = 5, @ExpertMode = 1
+
+EXEC sp_BlitzFirst @SinceStartup = 1
+
+EXEC sp_BlitzFirst @Seconds = 5, @ExpertMode = 1, @ShowSleepingSPIDs = 1
+
+/*BlitzIndex*/
+EXEC sp_BlitzIndex @GetAllDatabases = 1, @Mode = 4
+
+EXEC sp_BlitzIndex @DatabaseName = 'StackOverflow', @Mode = 4
+
+EXEC sp_BlitzIndex @DatabaseName = 'ChangeMe', @Mode = 4
+
+EXEC sp_BlitzIndex @DatabaseName = 'StackOverflow', @Mode = 4, @SkipPartitions = 0, @SkipStatistics = 0
+
+EXEC sp_BlitzIndex @DatabaseName = 'ChangeMe', @Mode = 4, @SkipPartitions = 0, @SkipStatistics = 0
+
+EXEC sp_BlitzIndex @GetAllDatabases = 1, @Mode = 1
+
+EXEC sp_BlitzIndex @GetAllDatabases = 1, @Mode = 2
+
+EXEC sp_BlitzIndex @GetAllDatabases = 1, @Mode = 3
+
+
+/*BlitzCache*/
+EXEC sp_BlitzCache @SortOrder = 'all'
+
+EXEC sp_BlitzCache @SortOrder = 'all avg'
+
+EXEC sp_BlitzCache @MinimumExecutionCount = 10
+
+EXEC sp_BlitzCache @OutputDatabaseName = 'ChangeMe', @OutputSchemaName = 'dbo', @OutputTableName = 'BlitzCache'
+
+/*BlitzBackups*/
+EXEC sp_BlitzBackups @HoursBack = 1000000
+
+/*sp_AllNightLog_Setup*/
+EXEC master.dbo.sp_AllNightLog_Setup @RPOSeconds = 30, @RTOSeconds = 30, @BackupPath = 'D:\Backup', @RestorePath = 'D:\Backup', @RunSetup = 1