Merge remote-tracking branch 'refs/remotes/origin/dev'

Author: BlitzErik

Documentation/Development/ReleaseProcess.md

@@ -27,6 +27,7 @@ Well, useful is probably the wrong word. More like entertaining. Here we go.
     * sp_BlitzFirst @VersionDate (no version) 
     * sp_BlitzCache @Version and @VersionDate 
     * sp_Blitz @Version and @VersionDate
+    * sp_DatabaseRestore @Version and @VersionDate
 
 ## Push to Master
 

sp_Blitz.sql

@@ -31,8 +31,8 @@ AS
     SET NOCOUNT ON;
 	SET TRANSACTION ISOLATION LEVEL READ UNCOMMITTED;
 	DECLARE @Version VARCHAR(30);
-	SET @Version = '5.2';
-	SET @VersionDate = '20170406';
+	SET @Version = '5.3';
+	SET @VersionDate = '20170501';
 	SET @OutputType = UPPER(@OutputType);
 
 	IF @Help = 1 PRINT '

sp_BlitzCache.sql

@@ -242,8 +242,8 @@ SET NOCOUNT ON;
 SET TRANSACTION ISOLATION LEVEL READ UNCOMMITTED;
 
 DECLARE @Version VARCHAR(30);
-SET @Version = '5.2';
-SET @VersionDate = '20170406';
+SET @Version = '5.3';
+SET @VersionDate = '20170501';
 
 IF @Help = 1 PRINT '
 sp_BlitzCache from http://FirstResponderKit.org
@@ -4081,7 +4081,9 @@ BEGIN
                     'A high number of plan stubs may result in CMEMTHREAD waits, which you have ' 
 						+ CONVERT(VARCHAR(10), (SELECT CONVERT(DECIMAL(9,0), (dows.wait_time_ms / 60000.)) FROM sys.dm_os_wait_stats AS dows WHERE dows.wait_type = 'CMEMTHREAD')) + ' minutes of.'
 			FROM   #plan_stubs_warning p	;			
-			
+		
+		IF @v >= 11
+		BEGIN	
         IF EXISTS (SELECT 1/0
                    FROM   #trace_flags AS tf 
                    WHERE  tf.global_trace_flags IS NOT NULL
@@ -4094,6 +4096,7 @@ BEGIN
                     'You have Global Trace Flags enabled on your server',
                     'https://www.brentozar.com/blitz/trace-flags-enabled-globally/',
                     'You have the following Global Trace Flags enabled: ' + (SELECT TOP 1 tf.global_trace_flags FROM #trace_flags AS tf WHERE tf.global_trace_flags IS NOT NULL)) ;
+		END 
 
         IF NOT EXISTS (SELECT 1/0
 					   FROM   ##bou_BlitzCacheResults AS bcr

sp_BlitzFirst.sql

@@ -30,8 +30,8 @@ BEGIN
 SET NOCOUNT ON;
 SET TRANSACTION ISOLATION LEVEL READ UNCOMMITTED;
 DECLARE @Version VARCHAR(30);
-SET @Version = '5.2';
-SET @VersionDate = '20170406';
+SET @Version = '5.3';
+SET @VersionDate = '20170501';
 
 
 IF @Help = 1 PRINT '

sp_BlitzIndex.sql

@@ -36,8 +36,8 @@ AS
 SET NOCOUNT ON;
 SET TRANSACTION ISOLATION LEVEL READ UNCOMMITTED;
 DECLARE @Version VARCHAR(30);
-SET @Version = '5.2';
-SET @VersionDate = '20170406';
+SET @Version = '5.3';
+SET @VersionDate = '20170501';
 IF @Help = 1 PRINT '
 /*
 sp_BlitzIndex from http://FirstResponderKit.org
@@ -2503,73 +2503,79 @@ BEGIN;
                https://github.com/BrentOzarULTD/SQL-Server-First-Responder-Kit/issues/825
             */
 
-            DECLARE    @number_indexes_with_includes INT;
-            DECLARE    @percent_indexes_with_includes NUMERIC(10, 1);
+			SELECT    database_name,
+					  SUM(CASE WHEN count_included_columns > 0 THEN 1 ELSE 0    END) AS number_indexes_with_includes,
+					  100.* SUM(CASE WHEN count_included_columns > 0 THEN 1 ELSE 0 END) / ( 1.0 * COUNT(*) ) AS percent_indexes_with_includes
+			INTO #index_includes
+            FROM    #IndexSanity
+			GROUP BY database_name;
 
-            SELECT    @number_indexes_with_includes = SUM(CASE WHEN count_included_columns > 0 THEN 1 ELSE 0    END),
-                    @percent_indexes_with_includes = 100.* 
-                        SUM(CASE WHEN count_included_columns > 0 THEN 1 ELSE 0 END) / ( 1.0 * COUNT(*) )
-            FROM    #IndexSanity;
-
-            IF @number_indexes_with_includes = 0 AND NOT (@GetAllDatabases = 1 OR @Mode = 0)
-                INSERT    #BlitzIndexResults ( check_id, index_sanity_id, Priority, findings_group, finding, URL, details, index_definition,
+            IF NOT (@Mode = 0)
+                INSERT    #BlitzIndexResults ( check_id, index_sanity_id, Priority, findings_group, finding, [database_name], URL, details, index_definition,
                                                secret_columns, index_usage_summary, index_size_summary )
-                        SELECT    30 AS check_id, 
+                        SELECT  30 AS check_id, 
                                 NULL AS index_sanity_id, 
                                 250 AS Priority,
                                 N'Feature-Phobic Indexes' AS findings_group,
+								database_name AS [Database Name],
                                 N'No indexes use includes' AS finding, 'http://BrentOzar.com/go/IndexFeatures' AS URL,
                                 N'No indexes use includes' AS details,
-                                @DatabaseName + N' (Entire database)' AS index_definition, 
+                                database_name + N' (Entire database)' AS index_definition, 
                                 N'' AS secret_columns, 
                                 N'N/A' AS index_usage_summary, 
-                                N'N/A' AS index_size_summary OPTION    ( RECOMPILE );
+                                N'N/A' AS index_size_summary 
+						FROM #index_includes
+						WHERE number_indexes_with_includes = 0
+						OPTION    ( RECOMPILE );
 
             RAISERROR(N'check_id 31: < 3 percent of indexes have includes', 0,1) WITH NOWAIT;
-            IF @percent_indexes_with_includes <= 3 AND @number_indexes_with_includes > 0 AND NOT (@GetAllDatabases = 1 OR @Mode = 0)
+            IF NOT (@Mode = 0)
                 INSERT    #BlitzIndexResults ( check_id, index_sanity_id, Priority, findings_group, finding, [database_name], URL, details, index_definition,
                                                secret_columns, index_usage_summary, index_size_summary )
                         SELECT    31 AS check_id,
                                 NULL AS index_sanity_id, 
                                 150 AS Priority,
                                 N'Feature-Phobic Indexes' AS findings_group,
                                 N'Borderline: Includes are used in < 3% of indexes' AS findings,
-                                @DatabaseName AS [Database Name],
+                                database_name AS [Database Name],
                                 N'http://BrentOzar.com/go/IndexFeatures' AS URL,
-                                N'Only ' + CAST(@percent_indexes_with_includes AS NVARCHAR(10)) + '% of indexes have includes' AS details, 
+                                N'Only ' + CAST(percent_indexes_with_includes AS NVARCHAR(20)) + '% of indexes have includes' AS details, 
                                 N'Entire database' AS index_definition, 
                                 N'' AS secret_columns,
                                 N'N/A' AS index_usage_summary, 
-                                N'N/A' AS index_size_summary OPTION    ( RECOMPILE );
+                                N'N/A' AS index_size_summary
+						FROM #index_includes
+						WHERE number_indexes_with_includes > 0 AND percent_indexes_with_includes <= 3
+						OPTION    ( RECOMPILE );
 
             RAISERROR(N'check_id 32: filtered indexes and indexed views', 0,1) WITH NOWAIT;
-            DECLARE @count_filtered_indexes INT;
-            DECLARE @count_indexed_views INT;
-
-                SELECT    @count_filtered_indexes=COUNT(*)
-                FROM    #IndexSanity
-                WHERE    filter_definition <> '' OPTION    ( RECOMPILE );
-
-                SELECT    @count_indexed_views=COUNT(*)
-                FROM    #IndexSanity AS i
-                        JOIN #IndexSanitySize AS sz ON i.index_sanity_id = sz.index_sanity_id
-                WHERE    is_indexed_view = 1 OPTION    ( RECOMPILE );
 
-            IF @count_filtered_indexes = 0 AND @count_indexed_views=0 AND NOT (@GetAllDatabases = 1 OR @Mode = 0)
+            IF NOT (@Mode = 0)
                 INSERT    #BlitzIndexResults ( check_id, index_sanity_id, Priority, findings_group, finding, [database_name], URL, details, index_definition,
                                                secret_columns, index_usage_summary, index_size_summary )
-                        SELECT    32 AS check_id, 
+                        SELECT  DISTINCT
+								32 AS check_id, 
                                 NULL AS index_sanity_id,
                                 250 AS Priority,
                                 N'Feature-Phobic Indexes' AS findings_group,
                                 N'Borderline: No filtered indexes or indexed views exist' AS finding, 
-                                @DatabaseName AS [Database Name],
+                                i.database_name AS [Database Name],
                                 N'http://BrentOzar.com/go/IndexFeatures' AS URL,
                                 N'These are NOT always needed-- but do you know when you would use them?' AS details,
-                                @DatabaseName + N' (Entire database)' AS index_definition, 
+                                i.database_name + N' (Entire database)' AS index_definition, 
                                 N'' AS secret_columns,
                                 N'N/A' AS index_usage_summary, 
-                                N'N/A' AS index_size_summary OPTION    ( RECOMPILE );
+                                N'N/A' AS index_size_summary 
+						FROM #IndexSanity i
+						WHERE i.database_name NOT IN (                
+								SELECT   database_name
+								FROM     #IndexSanity
+								WHERE    filter_definition <> '' )
+						AND i.database_name NOT IN (
+						       SELECT  database_name
+							   FROM    #IndexSanity
+							   WHERE   is_indexed_view = 1 )
+						OPTION    ( RECOMPILE );
         END;
 
         RAISERROR(N'check_id 33: Potential filtered indexes based on column names.', 0,1) WITH NOWAIT;

sp_BlitzWho.sql

@@ -11,8 +11,8 @@ BEGIN
 	SET NOCOUNT ON;
 	SET TRANSACTION ISOLATION LEVEL READ UNCOMMITTED;
 	DECLARE @Version VARCHAR(30);
-	SET @Version = '5.2';
-	SET @VersionDate = '20170406';
+	SET @Version = '5.3';
+	SET @VersionDate = '20170501';
 
 
 	IF @Help = 1

sp_DatabaseRestore.sql

@@ -57,10 +57,14 @@ GO
 ALTER PROCEDURE [dbo].[sp_DatabaseRestore]
 	  @Database NVARCHAR(128), @RestoreDatabaseName NVARCHAR(128) = NULL, @BackupPathFull NVARCHAR(MAX), @BackupPathDiff NVARCHAR(MAX), @BackupPathLog NVARCHAR(MAX),
 	  @MoveFiles bit = 0, @MoveDataDrive NVARCHAR(260) = NULL, @MoveLogDrive NVARCHAR(260) = NULL, @TestRestore bit = 0, @RunCheckDB bit = 0, @RestoreDiff bit = 0,
-	  @ContinueLogs bit = 0, @RunRecovery bit = 0, @Debug INT = 0
+	  @ContinueLogs bit = 0, @RunRecovery bit = 0, @Debug INT = 0, @VersionDate DATETIME = NULL OUTPUT
 AS
 SET NOCOUNT ON;
 
+	DECLARE @Version VARCHAR(30);
+	SET @Version = '5.3';
+	SET @VersionDate = '20170501';
+
 DECLARE @cmd NVARCHAR(4000), @sql NVARCHAR(MAX), @LastFullBackup NVARCHAR(500), @LastDiffBackup NVARCHAR(500), @BackupFile NVARCHAR(500), @BackupDateTime AS CHAR(15), @FullLastLSN NUMERIC(25, 0), @DiffLastLSN NUMERIC(25, 0);
 DECLARE @FileList TABLE (BackupFile NVARCHAR(255));