Merge branch 'master' into dev

Author: BrentOzar

.github/ISSUE_TEMPLATE.md

@@ -2,7 +2,7 @@
 
 **What is the current behavior?**
 
-**If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem via http://sqlfiddle.com
+**If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem via http://sqlfiddle.com**
 
 **What is the expected behavior?**
 

.github/PULL_REQUEST_TEMPLATE .github/PULL_REQUEST_TEMPLATE.md.github/PULL_REQUEST_TEMPLATE renamed to .github/PULL_REQUEST_TEMPLATE.md

@@ -101,6 +101,61 @@ Project maintainers who do not follow or enforce the Code of Conduct in good fai
 This Code of Conduct is adapted from the [Contributor Covenant][homepage], version 1.4,
 available at [http://contributor-covenant.org/version/1/4][version]
 
+
+## Git Flow for pull requests
+<a name="git-flow"></a>
+
+1. [Fork] the project, clone your fork, and configure the remotes:
+
+   ```bash
+   # Clone your fork of the repo into the current directory
+   git clone [email protected]:<YOUR_USERNAME>/SQL-Server-First-Responder-Kit.git
+   # Navigate to the newly cloned directory
+   cd SQL-Server-First-Responder-Kit
+   # Assign the original repo to a remote called "upstream"
+   git remote add upstream https://github.com/BrentOzarULTD/SQL-Server-First-Responder-Kit/
+   ```
+
+2. If you cloned a while ago, get the latest changes from upstream:
+
+   ```bash
+   git checkout master
+   git pull upstream master
+   ```
+
+3. Create a new topic branch (off the main project development branch) to
+   contain your feature, change, or fix:
+
+   ```bash
+   git checkout -b <topic-branch-name>
+   ```
+
+4. Commit your changes in logical chunks. Please adhere to these [git commit message guidelines]
+   or your code is unlikely be merged into the main project. Use Git's [interactive rebase]
+   feature to tidy up your commits before making them public.
+
+5. Locally merge (or rebase) the upstream development branch into your topic branch:
+
+   ```bash
+   git pull [--rebase] upstream master
+   ```
+
+6. Push your topic branch up to your fork:
+
+   ```bash
+   git push origin <topic-branch-name>
+   ```
+
+7. [Open a Pull Request] with a clear title and description.
+
+**IMPORTANT**: By submitting a patch, you agree to allow the project owner to license your work under the MIT [LICENSE]
+
+
 [homepage]: http://contributor-covenant.org
 [version]: http://contributor-covenant.org/version/1/4/
 [Github issues list]:https://github.com/BrentOzarULTD/SQL-Server-First-Responder-Kit/issues
+[Fork]:https://help.github.com/articles/fork-a-repo/
+[git commit message guidelines]:http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html
+[interactive rebase]:https://help.github.com/articles/about-git-rebase/
+[Open a Pull Request]:https://help.github.com/articles/about-pull-requests/
+[LICENSE]:https://github.com/BrentOzarULTD/SQL-Server-First-Responder-Kit/blob/master/LICENSE.md

CONTRIBUTING.md

@@ -1,9 +1,25 @@
 # SQL Server First Responder Kit
+<a name="header1"></a>
 [![licence badge]][licence]
 [![stars badge]][stars]
 [![forks badge]][forks]
 [![issues badge]][issues]
 
+Navigation
+ - [How to Get Support](#how-to-get-support)
+ - [sp_Blitz: Overall Health Check](#sp_blitz-overall-health-check)
+   - [Advanced sp_Blitz Parameters](#advanced-sp_blitz-parameters)
+     - [Writing sp_Blitz Output to a Table](#writing-sp_blitz-output-to-a-table)
+     - [Skipping Checks or Databases](#skipping-checks-or-databases)
+ - [sp_BlitzCache: Find the Most Resource-Intensive Queries](#sp_blitzcache-find-the-most-resource-intensive-queries)
+   - [Advanced sp_BlitzCache Parameters](#advanced-sp_blitzcache-parameters)
+ - [sp_BlitzIndex: Tune Your Indexes](#sp_blitzindex-tune-your-indexes)
+   - [Advanced sp_BlitzIndex Parameters](#advanced-sp_blitzindex-parameters)
+ - [sp_BlitzFirst: Real-Time Performance Advice](#sp_blitzfirst-real-time-performance-advice)
+   - [Advanced sp_BlitzFirst Parameters](#advanced-sp_blitzfirst-parameters)
+ - [Parameters Common to Many of the Stored Procedures](#parameters-common-to-many-of-the-stored-procedures)
+ - [License MIT](#license)
+
 You're a DBA, sysadmin, or developer who manages Microsoft SQL Servers. It's your fault if they're down or slow. These tools help you understand what's going on in your server.
 
 * When you want an overall health check, run [sp_Blitz](#sp_blitz-overall-health-check).
@@ -20,8 +36,8 @@ The First Responder Kit runs on:
 * Amazon RDS SQL Server - fully supported
 * Azure SQL DB - sp_BlitzFirst, sp_BlitzIndex, and sp_BlitzWho work as-is. To run sp_BlitzCache, do a search/replace in the code to replace ## with # (because global temp tables aren't supported in Azure SQL DB) - then it works fine. sp_Blitz doesn't work at all.
 
-## How to Get Support
 
+## How to Get Support
 Everyone here is expected to abide by the [Contributor Covenant Code of Conduct](CONTRIBUTING.md#the-contributor-covenant-code-of-conduct).
 
 Want to talk to the developers? [Get an invite to SQLCommunity.slack.com](https://sqlps.io/slack/), and we're in the [#FirstResponderKit channel](https://sqlcommunity.slack.com/messages/firstresponderkit/).
@@ -30,8 +46,10 @@ Got a question? Ask it on [DBA.StackExchange.com](http://dba.stackexchange.com).
 
 Want to contribute by writing, testing, or documenting code, or suggesting a new check? [Read the contributing.md file](CONTRIBUTING.md).
 
-## sp_Blitz: Overall Health Check
+[*Back to top*](#header1)
+
 
+## sp_Blitz: Overall Health Check
 Run sp_Blitz daily or weekly for an overall health check. Just run it from SQL Server Management Studio, and you'll get a prioritized list of issues on your server right now:
 
 ![sp_Blitz](http://u.brentozar.com/github-images/sp_Blitz.png)
@@ -51,10 +69,14 @@ Commonly used parameters:
 * @CheckServerInfo = 1 - includes additional rows at priority 250 with server configuration details like service accounts. 
 * @IgnorePrioritiesAbove = 50 - if you want a daily bulletin of the most important warnings, set @IgnorePrioritiesAbove = 50 to only get the urgent stuff.
 
+[*Back to top*](#header1)
+
 ### Advanced sp_Blitz Parameters
 
 In addition to the [parameters common to many of the stored procedures](#parameters-common-to-many-of-the-stored-procedures), here are the ones specific to sp_Blitz:
 
+[*Back to top*](#header1)
+
 #### Writing sp_Blitz Output to a Table
 
 ```SQL
@@ -63,6 +85,8 @@ sp_Blitz @OutputDatabaseName = 'DBAtools', @OutputSchemaName = 'dbo', @OutputTab
 
 Checks for the existence of a table DBAtools.dbo.BlitzResults, creates it if necessary, then adds the output of sp_Blitz into this table. This table is designed to support multiple outputs from multiple servers, so you can track your server's configuration history over time.
 
+[*Back to top*](#header1)
+
 #### Skipping Checks or Databases
 
 ```SQL
@@ -83,6 +107,8 @@ Checks for the existence of a table named Fred - just kidding, named DBAtools.db
 * If both DatabaseName and CheckID are populated, then that check will be skipped for that database
 * If CheckID is populated but DatabaseName is null, then that check will be skipped for all databases
 
+[*Back to top*](#header1)
+
 
 ## sp_BlitzCache: Find the Most Resource-Intensive Queries
 
@@ -124,6 +150,8 @@ Other common parameters include:
 * @IgnoreSystemDBs = 0 - if you want to show queries in master/model/msdb. By default we hide these.
 * @MinimumExecutionCount = 0 - in servers like data warehouses where lots of queries only run a few times, you can set a floor number for examination.
 
+[*Back to top*](#header1)
+
 ### Advanced sp_BlitzCache Parameters
 
 In addition to the [parameters common to many of the stored procedures](#parameters-common-to-many-of-the-stored-procedures), here are the ones specific to sp_BlitzCache:
@@ -133,6 +161,9 @@ In addition to the [parameters common to many of the stored procedures](#paramet
 * OnlySqlHandles, @IgnoreSqlHandles - just like the above two params
 * @DatabaseName - if you only want to analyze plans in a single database. However, keep in mind that this is only the database context. A single query that runs in Database1 can join across objects in Database2 and Database3, but we can only know that it ran in Database1.
 
+[*Back to top*](#header1)
+
+
 ## sp_BlitzIndex: Tune Your Indexes
 
 SQL Server tracks your indexes: how big they are, how often they change, whether they're used to make queries go faster, and which indexes you should consider adding. The results columns are fairly self-explanatory.
@@ -148,6 +179,8 @@ Common parameters include:
 * @Mode = 0 (default) - get different data with 0=Diagnose, 1=Summarize, 2=Index Usage Detail, 3=Missing Index Detail, 4=Diagnose Details.
 
 
+[*Back to top*](#header1)
+
 ### Advanced sp_BlitzIndex Parameters
 
 In addition to the [parameters common to many of the stored procedures](#parameters-common-to-many-of-the-stored-procedures), here are the ones specific to sp_BlitzIndex:
@@ -157,16 +190,25 @@ In addition to the [parameters common to many of the stored procedures](#paramet
 * @Filter = 0 (default) - 1=No low-usage warnings for objects with 0 reads. 2=Only warn for objects >= 500MB
 
 
+[*Back to top*](#header1)
+
+
 ## sp_BlitzFirst: Real-Time Performance Advice
 
 (stub - describe the big picture here)
 
+[*Back to top*](#header1)
+
 ### Advanced sp_BlitzFirst Parameters
 
 In addition to the [parameters common to many of the stored procedures](#parameters-common-to-many-of-the-stored-procedures), here are the ones specific to sp_BlitzFirst:
 
 (stub - describe the lesser-used stuff)
 
+<<<<<<< HEAD
+[*Back to top*](#header1)
+
+=======
 ## DatabaseRestore: Easier Multi-File Restores
 
 If you use [Ola Hallengren's backup scripts](http://ola.hallengren.com), DatabaseRestore.sql helps you rapidly restore a database to the most recent point in time.
@@ -184,6 +226,7 @@ Parameters include:
 * @RunRecovery
 
 For information about how this works, see [Tara Kizer's white paper on Log Shipping 2.0 with Google Compute Engine.](https://BrentOzar.com/go/gce)
+>>>>>>> refs/remotes/origin/dev
 
 ## Parameters Common to Many of the Stored Procedures
 
@@ -192,10 +235,14 @@ For information about how this works, see [Tara Kizer's white paper on Log Shipp
 * @OutputDatabaseName, @OutputSchemaName, @OutputTableName - pass all three of these in, and the stored proc's output will be written to a table. We'll create the table if it doesn't already exist.
 * @OutputServerName - not functional yet. To track (or help!) implementation status: https://github.com/BrentOzarULTD/SQL-Server-First-Responder-Kit/issues/293
 
+[*Back to top*](#header1)
+
+
 ## License
 
 [The SQL Server First Responder Kit uses the MIT License.](LICENSE.md)
 
+[*Back to top*](#header1)
 
 [licence badge]:https://img.shields.io/badge/license-MIT-blue.svg
 [stars badge]:https://img.shields.io/github/stars/BrentOzarULTD/SQL-Server-First-Responder-Kit.svg

README.md

@@ -5253,6 +5253,8 @@ IF @ProductVersionMajor >= 10
 											 WHEN [T].[TraceFlag] = '3505'  THEN ' 3505 enabled globally. Using this Trace Flag disables Checkpoints. Probably not the wisest idea.'
 											 WHEN [T].[TraceFlag] = '8649'  THEN ' 8649 enabled globally. Using this Trace Flag drops cost thresholf for parallelism down to 0. I hope this is a dev server.'
 										     WHEN [T].[TraceFlag] = '834' AND @ColumnStoreIndexesInUse = 1 THEN ' 834 is enabled globally. Using this Trace Flag with Columnstore Indexes is not a great idea.'
+											 WHEN [T].[TraceFlag] = '8017' AND (CAST(SERVERPROPERTY('Edition') AS NVARCHAR(1000)) LIKE N'%Express%') THEN ' 8017 is enabled globally, which is the default for express edition.'
+                                             WHEN [T].[TraceFlag] = '8017' AND (CAST(SERVERPROPERTY('Edition') AS NVARCHAR(1000)) NOT LIKE N'%Express%') THEN ' 8017 is enabled globally. Using this Trace Flag disables creation schedulers for all logical processors. Not good.'
 											 ELSE [T].[TraceFlag] + ' is enabled globally.' END 
 										AS Details
 								FROM    #TraceStatus T