Skip to content

Commit 632ec5c

Browse files
committed
read committed is a garbage isolation level
i had to make one more tweak for reasons detailed in the issue.
1 parent b0b6128 commit 632ec5c

File tree

1 file changed

+35
-8
lines changed

1 file changed

+35
-8
lines changed

sp_BlitzFirst.sql

Lines changed: 35 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1318,7 +1318,11 @@ BEGIN
13181318
ELSE
13191319
(
13201320
SELECT
1321-
SUM(s.total_cpu_usage_ms)
1321+
CONVERT
1322+
(
1323+
FLOAT,
1324+
SUM(s.total_cpu_usage_ms)
1325+
)
13221326
FROM sys.dm_os_schedulers AS s
13231327
WHERE s.status = ''VISIBLE ONLINE''
13241328
AND s.is_online = 1
@@ -1363,14 +1367,14 @@ BEGIN
13631367
)
13641368
GROUP BY x.Pass, x.SampleTime, x.wait_type
13651369
ORDER BY sum_wait_time_ms DESC;'
1366-
1370+
13671371
EXEC sp_executesql
13681372
@StringToExecute,
13691373
N'@StartSampleTime DATETIMEOFFSET,
13701374
@Seconds INT',
13711375
@StartSampleTime,
13721376
@Seconds;
1373-
1377+
13741378
WITH w AS
13751379
(
13761380
SELECT
@@ -1382,15 +1386,24 @@ BEGIN
13821386
)
13831387
FROM #WaitStats AS ws
13841388
WHERE Pass = 1
1389+
),
1390+
m AS
1391+
(
1392+
SELECT
1393+
max_thread =
1394+
MAX(ws.thread_time_ms)
1395+
FROM #WaitStats AS ws
1396+
WHERE Pass = 1
13851397
)
13861398
UPDATE ws
13871399
SET ws.thread_time_ms =
1388-
ws.thread_time_ms + w.total_waits
1400+
m.max_thread + w.total_waits
13891401
FROM #WaitStats AS ws
13901402
CROSS JOIN w
1403+
CROSS JOIN m
13911404
WHERE ws.Pass = 1
13921405
OPTION(RECOMPILE);
1393-
1406+
13941407
INSERT INTO #FileStats (Pass, SampleTime, DatabaseID, FileID, DatabaseName, FileLogicalName, SizeOnDiskMB, io_stall_read_ms ,
13951408
num_of_reads, [bytes_read] , io_stall_write_ms,num_of_writes, [bytes_written], PhysicalName, TypeDesc)
13961409
SELECT
@@ -2508,7 +2521,11 @@ If one of them is a lead blocker, consider killing that query.'' AS HowToStopit,
25082521
SUM(x.sum_wait_time_ms) AS sum_wait_time_ms,
25092522
(
25102523
SELECT
2511-
SUM(s.total_cpu_usage_ms)
2524+
CONVERT
2525+
(
2526+
FLOAT,
2527+
SUM(s.total_cpu_usage_ms)
2528+
)
25122529
FROM sys.dm_os_schedulers AS s
25132530
WHERE s.status = ''VISIBLE ONLINE''
25142531
AND s.is_online = 1
@@ -2552,7 +2569,7 @@ If one of them is a lead blocker, consider killing that query.'' AS HowToStopit,
25522569
)
25532570
GROUP BY x.Pass, x.SampleTime, x.wait_type
25542571
ORDER BY sum_wait_time_ms DESC;';
2555-
2572+
25562573
EXEC sp_executesql
25572574
@StringToExecute,
25582575
N'@Seconds INT',
@@ -2569,14 +2586,24 @@ If one of them is a lead blocker, consider killing that query.'' AS HowToStopit,
25692586
)
25702587
FROM #WaitStats AS ws
25712588
WHERE Pass = 2
2589+
),
2590+
m AS
2591+
(
2592+
SELECT
2593+
max_thread =
2594+
MAX(ws.thread_time_ms)
2595+
FROM #WaitStats AS ws
2596+
WHERE Pass = 2
25722597
)
25732598
UPDATE ws
25742599
SET ws.thread_time_ms =
2575-
ws.thread_time_ms + w.total_waits
2600+
m.max_thread + w.total_waits
25762601
FROM #WaitStats AS ws
25772602
CROSS JOIN w
2603+
CROSS JOIN m
25782604
WHERE ws.Pass = 2
25792605
OPTION(RECOMPILE);
2606+
25802607

25812608
INSERT INTO #FileStats (Pass, SampleTime, DatabaseID, FileID, DatabaseName, FileLogicalName, SizeOnDiskMB, io_stall_read_ms ,
25822609
num_of_reads, [bytes_read] , io_stall_write_ms,num_of_writes, [bytes_written], PhysicalName, TypeDesc, avg_stall_read_ms, avg_stall_write_ms)

0 commit comments

Comments
 (0)