Skip to content

Commit 78596fc

Browse files
committed
#3377 simplified the msdb jobs check
1 parent 6487f33 commit 78596fc

File tree

1 file changed

+12
-77
lines changed

1 file changed

+12
-77
lines changed

sp_Blitz.sql

Lines changed: 12 additions & 77 deletions
Original file line numberDiff line numberDiff line change
@@ -198,8 +198,6 @@ AS
198198
,@SkipMaster bit = 0
199199
,@SkipMSDB_objs bit = 0
200200
,@SkipMSDB_jobs bit = 0
201-
,@SkipMSDB_alerts bit = 0
202-
,@SkipMSDB_operators bit = 0
203201
,@SkipModel bit = 0
204202
,@SkipTempDB bit = 0
205203
,@SkipValidateLogins bit = 0
@@ -439,64 +437,6 @@ AS
439437
SET @SkipMSDB_jobs = 1; /*We don't have read permissions in the msdb database*/
440438
END;
441439
END;
442-
443-
IF ISNULL(@SkipMSDB_alerts, 0) != 1 /*If @SkipMSDB_alerts hasn't been set to 1 by the caller*/
444-
BEGIN
445-
IF EXISTS
446-
(
447-
SELECT 1/0
448-
FROM @db_perms
449-
WHERE database_name = N'msdb'
450-
)
451-
BEGIN
452-
BEGIN TRY
453-
IF EXISTS
454-
(
455-
SELECT 1/0
456-
FROM msdb.dbo.sysalerts
457-
)
458-
BEGIN
459-
SET @SkipMSDB_alerts = 0; /*We have read permissions in the msdb database, and can view the objects*/
460-
END;
461-
END TRY
462-
BEGIN CATCH
463-
SET @SkipMSDB_alerts = 1; /*We have read permissions in the msdb database ... oh wait we got tricked, we can't view the objects*/
464-
END CATCH;
465-
END;
466-
ELSE
467-
BEGIN
468-
SET @SkipMSDB_alerts = 1; /*We don't have read permissions in the msdb database*/
469-
END;
470-
END;
471-
472-
IF ISNULL(@SkipMSDB_operators, 0) != 1 /*If @SkipMSDB_operators hasn't been set to 1 by the caller*/
473-
BEGIN
474-
IF EXISTS
475-
(
476-
SELECT 1/0
477-
FROM @db_perms
478-
WHERE database_name = N'msdb'
479-
)
480-
BEGIN
481-
BEGIN TRY
482-
IF EXISTS
483-
(
484-
SELECT 1/0
485-
FROM msdb.dbo.sysoperators
486-
)
487-
BEGIN
488-
SET @SkipMSDB_operators = 0; /*We have read permissions in the msdb database, and can view the objects*/
489-
END;
490-
END TRY
491-
BEGIN CATCH
492-
SET @SkipMSDB_operators = 1; /*We have read permissions in the msdb database ... oh wait we got tricked, we can't view the objects*/
493-
END CATCH;
494-
END;
495-
ELSE
496-
BEGIN
497-
SET @SkipMSDB_operators = 1; /*We don't have read permissions in the msdb database*/
498-
END;
499-
END;
500440
END;
501441

502442
SET @crlf = NCHAR(13) + NCHAR(10);
@@ -672,33 +612,28 @@ AS
672612
INSERT #SkipChecks (DatabaseName, CheckID, ServerName)
673613
SELECT
674614
v.*
675-
FROM (VALUES(NULL, 6, NULL), /*Jobs Owned By Users*/
615+
FROM (VALUES
616+
/*sysjobs checks*/
617+
(NULL, 6, NULL), /*Jobs Owned By Users*/
676618
(NULL, 57, NULL), /*SQL Agent Job Runs at Startup*/
677619
(NULL, 79, NULL), /*Shrink Database Job*/
678620
(NULL, 94, NULL), /*Agent Jobs Without Failure Emails*/
679621
(NULL, 123, NULL), /*Agent Jobs Starting Simultaneously*/
680622
(NULL, 180, NULL), /*Shrink Database Step In Maintenance Plan*/
681-
(NULL, 181, NULL) /*Repetitive Maintenance Tasks*/
682-
) AS v (DatabaseName, CheckID, ServerName)
683-
WHERE @SkipMSDB_jobs = 1;
684-
685-
INSERT #SkipChecks (DatabaseName, CheckID, ServerName)
686-
SELECT
687-
v.*
688-
FROM (VALUES(NULL, 30, NULL), /*Not All Alerts Configured*/
623+
(NULL, 181, NULL), /*Repetitive Maintenance Tasks*/
624+
625+
/*sysalerts checks*/
626+
(NULL, 30, NULL), /*Not All Alerts Configured*/
689627
(NULL, 59, NULL), /*Alerts Configured without Follow Up*/
690628
(NULL, 61, NULL), /*No Alerts for Sev 19-25*/
691629
(NULL, 96, NULL), /*No Alerts for Corruption*/
692630
(NULL, 98, NULL), /*Alerts Disabled*/
693-
(NULL, 219, NULL) /*Alerts Without Event Descriptions*/
694-
) AS v (DatabaseName, CheckID, ServerName)
695-
WHERE @SkipMSDB_alerts = 1;
631+
(NULL, 219, NULL), /*Alerts Without Event Descriptions*/
696632

697-
INSERT #SkipChecks (DatabaseName, CheckID, ServerName)
698-
SELECT
699-
v.*
700-
FROM (VALUES(NULL, 31, NULL)) AS v (DatabaseName, CheckID, ServerName) /*No Operators Configured/Enabled*/
701-
WHERE @SkipMSDB_operators = 1;
633+
/*sysoperators*/
634+
(NULL, 31, NULL) /*No Operators Configured/Enabled*/
635+
) AS v (DatabaseName, CheckID, ServerName)
636+
WHERE @SkipMSDB_jobs = 1;
702637

703638
INSERT #SkipChecks (DatabaseName, CheckID, ServerName)
704639
SELECT

0 commit comments

Comments
 (0)