Skip to content

Commit 959f55b

Browse files
committed
Closes #1049
Add BEGIN/END to IF block that checks the number of memory dumps in the past year.
1 parent 16a02ec commit 959f55b

File tree

1 file changed

+32
-29
lines changed

1 file changed

+32
-29
lines changed

sp_Blitz.sql

Lines changed: 32 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -3950,37 +3950,40 @@ IF @ProductVersionMajor >= 10
39503950
IF EXISTS ( SELECT 1
39513951
FROM sys.all_objects
39523952
WHERE name = 'dm_server_memory_dumps' )
3953-
BEGIN
3954-
IF 5 <= (SELECT COUNT(*) FROM [sys].[dm_server_memory_dumps] WHERE [creation_time] >= DATEADD(year, -1, GETDATE()))
3955-
3956-
IF @Debug IN (1, 2) RAISERROR('Running CheckId [%d].', 0, 1, 171) WITH NOWAIT;
3957-
3958-
INSERT INTO [#BlitzResults]
3959-
( [CheckID] ,
3960-
[Priority] ,
3961-
[FindingsGroup] ,
3962-
[Finding] ,
3963-
[URL] ,
3964-
[Details] )
3953+
BEGIN
3954+
IF 5 <= (SELECT COUNT(*) FROM [sys].[dm_server_memory_dumps] WHERE [creation_time] >= DATEADD(YEAR, -1, GETDATE()))
39653955

3966-
SELECT
3967-
171 AS [CheckID] ,
3968-
20 AS [Priority] ,
3969-
'Reliability' AS [FindingsGroup] ,
3970-
'Memory Dumps Have Occurred' AS [Finding] ,
3971-
'https://BrentOzar.com/go/dump' AS [URL] ,
3972-
( 'That ain''t good. I''ve had ' +
3973-
CAST(COUNT(*) AS VARCHAR(100)) + ' memory dumps between ' +
3974-
CAST(CAST(MIN([creation_time]) AS DATETIME) AS VARCHAR(100)) +
3975-
' and ' +
3976-
CAST(CAST(MAX([creation_time]) AS DATETIME) AS VARCHAR(100)) +
3977-
'!'
3978-
) AS [Details]
3979-
FROM
3980-
[sys].[dm_server_memory_dumps]
3981-
WHERE [creation_time] >= DATEADD(year, -1, GETDATE());
3956+
BEGIN
3957+
3958+
IF @Debug IN (1, 2) RAISERROR('Running CheckId [%d].', 0, 1, 171) WITH NOWAIT;
3959+
3960+
INSERT INTO [#BlitzResults]
3961+
( [CheckID] ,
3962+
[Priority] ,
3963+
[FindingsGroup] ,
3964+
[Finding] ,
3965+
[URL] ,
3966+
[Details] )
39823967

3983-
END;
3968+
SELECT
3969+
171 AS [CheckID] ,
3970+
20 AS [Priority] ,
3971+
'Reliability' AS [FindingsGroup] ,
3972+
'Memory Dumps Have Occurred' AS [Finding] ,
3973+
'https://BrentOzar.com/go/dump' AS [URL] ,
3974+
( 'That ain''t good. I''ve had ' +
3975+
CAST(COUNT(*) AS VARCHAR(100)) + ' memory dumps between ' +
3976+
CAST(CAST(MIN([creation_time]) AS DATETIME) AS VARCHAR(100)) +
3977+
' and ' +
3978+
CAST(CAST(MAX([creation_time]) AS DATETIME) AS VARCHAR(100)) +
3979+
'!'
3980+
) AS [Details]
3981+
FROM
3982+
[sys].[dm_server_memory_dumps]
3983+
WHERE [creation_time] >= DATEADD(year, -1, GETDATE());
3984+
3985+
END;
3986+
END;
39843987
END;
39853988

39863989
/*Checks to see if you're on Developer or Evaluation*/

0 commit comments

Comments
 (0)