Player advancements fail to sync/update on server shutdown (/stop) #196
Description
I am experiencing an issue where advancements obtained during a session are not saved if the server is shut down using the /stop command. The server seems unable to "capture" the newly earned advancements and write them to the JSON file before closing.
Important Notes:
No Console Errors: There are absolutely no errors, stack traces, or warnings in the console during the session or during the shutdown process.
Isolated Environment: This was tested on a clean server with ONLY the BreweryX plugin installed. The issue disappears instantly when the plugin is removed.
File Behavior: The plugin does not wipe the file. If the file already contains advancements (saved previously via /save-all), it stays as it is. However, any new advancements earned during the current session are lost unless a manual /save-all is performed before stopping. It appears the plugin interferes with the server's ability to sync the player's current advancement cache to the disk during the shutdown sequence.
Server Environment:
- Core: Purpur 1.21.11 (Build 2566, 2026-03-03)
- Java: 21
- Tested OS: Windows 10 21H2 and Ubuntu Server 24.04.4 LTS (Reproduced on both).
Steps to Reproduce:
- Start a clean server with only BreweryX.
- Join the world and earn any advancement (e.g., "Stone Age").
- Shut down the server using the /stop command.
- Start the server and check advancements.
Result: The advancement is gone. The JSON file in the advancements folder remains in its state prior to the current session (or only contains {"DataVersion":...}).
Workaround:
Executing /save-all manually before /stop forces the data to disk and prevents the loss.
Don't ask me how I found this out... it was a long night of binary searching through 40+ plugins.