fix lint

Author: jlkalberer

eslint.config.mjs

@@ -144,7 +144,7 @@ export default defineConfig([
       'import/no-default-export': 'off',
     },
   },
-  // Allow default exports in route files (required by Expo Router)
+  // Allow default exports and function declarations in route files (required by Expo Router)
   {
     name: 'routes-allow-default-export',
     files: [
@@ -159,6 +159,14 @@ export default defineConfig([
       'react/function-component-definition': 'off',
     },
   },
+  // Allow function declaration for generic form components (arrow + generic is awkward in TSX)
+  {
+    name: 'form-components-allow-function',
+    files: ['**/common/form/*.tsx'],
+    rules: {
+      'react/function-component-definition': 'off',
+    },
+  },
   // React 17+ and TypeScript specific overrides
   {
     name: 'react-typescript-overrides',
@@ -201,6 +209,7 @@ export default defineConfig([
       '@typescript-eslint/consistent-type-imports': 'off',
       'no-void': 'off',
       'no-restricted-globals': 'off',
+      '@typescript-eslint/no-unnecessary-boolean-literal-compare': 'off',
     },
   },
   // Import / React structural

src/common/Container.tsx

@@ -1,4 +1,5 @@
 import { StyleSheet, View } from 'react-native';
+
 import { COLORS } from 'theme';
 
 import type { ReactElement, ReactNode } from 'react';

src/common/ErrorListItem.tsx

@@ -25,7 +25,7 @@ type Props = LoaderErrorRowProps<{
 }>;
 
 const ErrorListItem: FC<Props> = ({
-  error: unusedError,
+  error: _error,
   containerStyle,
   ...otherProps
 }) => (

src/common/Header/HeaderIconButton.tsx

@@ -1,5 +1,5 @@
-import { COLORS } from 'theme';
 import { IconButton } from 'common/buttons/IconButton';
+import { COLORS } from 'theme';
 
 import type { ComponentProps, FC, ReactElement } from 'react';
 

src/common/List.tsx

@@ -72,7 +72,7 @@ type Props<TEntity> = ListProps<TEntity> & {
 const List = <TEntity,>(props: Props<TEntity>): ReactElement => {
   const {
     bounceFirstRowOnMount,
-    innerRef,
+    innerRef: _innerRef,
     onRefresh,
     ListEmptyComponent,
     ListFooterComponent,

src/common/ListItem.tsx

@@ -89,14 +89,14 @@ const ListItem = <TItem,>(props: Props<TItem>): ReactElement => {
     }
   }, [swipeable, item, props]);
 
-  const rightIconElement =
-    rightIcon != null ? (
-      isValidElement(rightIcon) ? (
-        rightIcon
-      ) : (
-        <Icon {...rightIcon} />
-      )
-    ) : null;
+  let rightIconElement: React.ReactNode = null;
+  if (rightIcon != null) {
+    rightIconElement = isValidElement(rightIcon) ? (
+      rightIcon
+    ) : (
+      <Icon {...rightIcon} />
+    );
+  }
 
   const content = (
     <Fragment>

src/common/LoadingListItem.tsx

@@ -2,8 +2,8 @@ import * as React from 'react';
 
 import { StyleSheet } from 'react-native';
 
-import { COLORS } from 'theme';
 import { ListItem } from 'common/ListItem';
+import { COLORS } from 'theme';
 
 import type { StyleProp, ViewStyle } from 'react-native';
 

src/common/WarningNotification.tsx

@@ -3,8 +3,8 @@ import * as React from 'react';
 import { Icon } from '@rneui/themed';
 import { StyleSheet, Text, View } from 'react-native';
 
-import { COLORS, TYPOGRAPHY } from 'theme';
 import { TouchableItem } from 'common/buttons/TouchableItem';
+import { COLORS, TYPOGRAPHY } from 'theme';
 
 const styles = StyleSheet.create({
   container: {

src/common/form/DropdownInput.tsx

@@ -62,7 +62,7 @@ export type DropdownInputProps<
 
 // Wrapper: WebDropdown on web, react-native-element-dropdown on native. Props match DropdownProps.
 
-const Dropdown = <TValueType,>(props: DropdownProps) => {
+const Dropdown = <_TValueType,>(props: DropdownProps) => {
   if (Platform.OS === 'web') {
     return <WebDropdown {...props} />;
   }
@@ -96,7 +96,7 @@ export const DropdownInput = <TFormFields extends FieldValues, TValueType>({
   labelField,
   testID,
   mode = 'default',
-  headerTitle,
+  headerTitle: _headerTitle,
   confirmSelectItem = false,
   onConfirmSelectItem,
   useQueryHook,

src/components/DeviceOnlineOverviewItem.tsx

@@ -1,7 +1,7 @@
 import * as React from 'react';
 
-import { DeviceOnlineIndicator } from 'components/DeviceOnlineIndicator';
 import { OverviewItem2 } from 'common/OverviewItem2';
+import { DeviceOnlineIndicator } from 'components/DeviceOnlineIndicator';
 import { useGetParticleAttributes } from 'hooks/queries/CloudDeviceQueries';
 
 import type { EntityID } from '@brewskey/js-api';