Error with handshake process

[xeanhort]

Hi,

I've just tried the steps to build but I'm having troubles during the authentication process.

The error comes when the particle device tries to connect to the cloud but if I look to deviceKeys.deb, the data for that device is properly stored:

{"deviceID":"XXXXXXXXXXXXXXXXXXXXXXXX","algorithm":"ecc","key":"-----BEGIN PUBLIC KEY-----\nMFkwEwYHKoZIzj0CAQYIKoZIzj0DAQcDQgAETNP2mzOQyygIo+2O+WnooEWcEeCH\ncQvvydppV0FlxAc8V4Jhe3g+SokUyjgQkiIHI+BmrUJVumMizhydarG1Ug==\n-----END PUBLIC KEY-----\n","_id":"XvCn29Nb2MMOiDuI"}

The error is when comparing publicKey.equals(deviceProvidedPem) at Handshake.js:383 from spark-protocol (I posted the issue here because I don't really know what is the root cause)

The error log shows this:

[2020-05-05T18:17:17.694Z] INFO: DeviceServer.js/7443 on CX61-2PC: New Connection
[2020-05-05T18:17:18.723Z] ERROR: Handshake.js/7443 on CX61-2PC: Handshake failed (cache_key=_4, deviceID=XXXXXXXXXXXXXXXXXXXXXXXX, ip=::ffff:XX.XX.XX.XX)
Error: Failed to match tag: "objid" at: ["algorithmIdentifier"]["parameters"]
at DecoderBuffer.error (/media/user/spark-server/node_modules/asn1.js/lib/asn1/base/reporter.js:53:11)
at DERNode.decodeTag [as _decodeTag] (/media/user/spark-server/node_modules/asn1.js/lib/asn1/decoders/der.js:67:19)
at DERNode.decode [as _decode] (/media/user/spark-server/node_modules/asn1.js/lib/asn1/base/node.js:302:23)
at decodeChildren (/media/user/spark-server/node_modules/asn1.js/lib/asn1/base/node.js:332:15)
at Array.some ()
at DERNode.decode [as _decode] (/media/user/spark-server/node_modules/asn1.js/lib/asn1/base/node.js:329:33)
at decodeChildren (/media/user/spark-server/node_modules/asn1.js/lib/asn1/base/node.js:332:15)
at Array.some ()
at DERNode.decode [as _decode] (/media/user/spark-server/node_modules/asn1.js/lib/asn1/base/node.js:329:33)
at DERNode.decode [as _decode] (/media/user/spark-server/node_modules/asn1.js/lib/asn1/base/node.js:263:47)
at SpkiKey.decode (/media/user/spark-server/node_modules/asn1.js/lib/asn1/decoders/der.js:25:20)
at Entity.decode (/media/user/spark-server/node_modules/asn1.js/lib/asn1/api.js:47:32)
at parseSpki (/media/user/spark-server/node_modules/ec-key/src/ec-key.js:158:27)
at parsePem (/media/user/spark-server/node_modules/ec-key/src/ec-key.js:184:12)
at new ECKey (/media/user/spark-server/node_modules/ec-key/src/ec-key.js:237:15)
at new DeviceKey (/media/user/spark-server/node_modules/spark-protocol/dist/lib/DeviceKey.js:32:25)
at DeviceKey.equals (/media/user/spark-server/node_modules/spark-protocol/dist/lib/DeviceKey.js:75:20)
at Handshake._callee5$ (/media/user/spark-server/node_modules/spark-protocol/dist/lib/Handshake.js:383:29)
at tryCatch (/media/user/spark-server/node_modules/regenerator-runtime/runtime.js:62:40)
at Generator.invoke [as _invoke] (/media/user/spark-server/node_modules/regenerator-runtime/runtime.js:296:22)
at Generator.prototype.(anonymous function) [as next] (/media/user/spark-server/node_modules/regenerator-runtime/runtime.js:114:21)
at step (/media/user/spark-server/node_modules/babel-runtime/helpers/asyncToGenerator.js:17:30)
at /media/user/spark-server/node_modules/babel-runtime/helpers/asyncToGenerator.js:28:13
at
[2020-05-05T18:17:18.723Z] INFO: Device.js/7443 on CX61-2PC: Device disconnected (cache_key=_4, deviceID="", disconnectCounter=1)
[2020-05-05T18:17:18.723Z] ERROR: DeviceServer.js/7443 on CX61-2PC: Device startup failed (deviceID=null)
Error: Failed to match tag: "objid" at: ["algorithmIdentifier"]["parameters"]
at DecoderBuffer.error (/media/user/spark-server/node_modules/asn1.js/lib/asn1/base/reporter.js:53:11)
at DERNode.decodeTag [as _decodeTag] (/media/user/spark-server/node_modules/asn1.js/lib/asn1/decoders/der.js:67:19)
at DERNode.decode [as _decode] (/media/user/spark-server/node_modules/asn1.js/lib/asn1/base/node.js:302:23)
at decodeChildren (/media/user/spark-server/node_modules/asn1.js/lib/asn1/base/node.js:332:15)
at Array.some ()
at DERNode.decode [as _decode] (/media/user/spark-server/node_modules/asn1.js/lib/asn1/base/node.js:329:33)
at decodeChildren (/media/user/spark-server/node_modules/asn1.js/lib/asn1/base/node.js:332:15)
at Array.some ()
at DERNode.decode [as _decode] (/media/user/spark-server/node_modules/asn1.js/lib/asn1/base/node.js:329:33)
at DERNode.decode [as _decode] (/media/user/spark-server/node_modules/asn1.js/lib/asn1/base/node.js:263:47)
at SpkiKey.decode (/media/user/spark-server/node_modules/asn1.js/lib/asn1/decoders/der.js:25:20)
at Entity.decode (/media/user/spark-server/node_modules/asn1.js/lib/asn1/api.js:47:32)
at parseSpki (/media/user/spark-server/node_modules/ec-key/src/ec-key.js:158:27)
at parsePem (/media/user/spark-server/node_modules/ec-key/src/ec-key.js:184:12)
at new ECKey (/media/user/spark-server/node_modules/ec-key/src/ec-key.js:237:15)
at new DeviceKey (/media/user/spark-server/node_modules/spark-protocol/dist/lib/DeviceKey.js:32:25)
at DeviceKey.equals (/media/user/spark-server/node_modules/spark-protocol/dist/lib/DeviceKey.js:75:20)
at Handshake._callee5$ (/media/user/spark-server/node_modules/spark-protocol/dist/lib/Handshake.js:383:29)
at tryCatch (/media/user/spark-server/node_modules/regenerator-runtime/runtime.js:62:40)
at Generator.invoke [as _invoke] (/media/user/spark-server/node_modules/regenerator-runtime/runtime.js:296:22)
at Generator.prototype.(anonymous function) [as next] (/media/user/spark-server/node_modules/regenerator-runtime/runtime.js:114:21)
at step (/media/user/spark-server/node_modules/babel-runtime/helpers/asyncToGenerator.js:17:30)
at /media/user/spark-server/node_modules/babel-runtime/helpers/asyncToGenerator.js:28:13

I'm using node v8.11.1, npm 5.6.0 and yarn 1.22.4, and tested the server on Ubuntu&Windows.

Thank you

[jlkalberer]

What particle device are you using?
Did you configure the device to use TCP? <-- You need to manually add this flag for devices like electron
Did you run particle config myconfig before adding the device to your server? <-- I see a lot of weird errors when this isn't done

[xeanhort]

It's an electron, and yes! I did the step to change the profile (particle config myconfig) and the tcp step.

I had to change the command slightly to work tough: particle keys server default_key.pub.pem --host IP_ADDRESS --port 5683 --protocol tcp and also particle keys protocol --protocol tcp

[xeanhort]

By the way, I'm using the latest particle CLI version (2.3.0)

[jlkalberer]

There are two things I can think of

1. The server key was incorrectly set on the electron. I would retry this and make sure the file extension is correct.
2. Node v8.11.1 has a crypto bug or some behavior changed in the libraries

[xeanhort]

I did the whole process few times, but I can check again!
About node 8.11.1, I've used it because is the one used in this link. If you have an specific version of node/particleCLI I can use it and try again.

[jlkalberer]

Ok, I think I just need to use the original version of this - usrz/ec-key@23f4dd3

I'm guessing the dependencies are just out of date now.

[xeanhort]

I've changed package.json, deleted node_modules and executed yarn install again. The file yarn.lock was automatically updated with new versions of ec-key, bn.js and asn1.js but no luck connecting the device. The same Error: Failed to match tag: "objid" at: ["algorithmIdentifier"]["parameters"]

Is there anything I'm missing?

[jlkalberer]

I updated the dependency. You'll need to pull the latest version of this repo and yarn install --force to upgrade dependencies.

[xeanhort]

I've seen that spark-protocol repo was updated, but not this. Shouldn't this package.json be updated with the new ec-key ^0.0.4 too?

I can't update properly. It keeps downloading the spark-protocol without your last changes

[jlkalberer]

Doh -- I didn't push. It's updated now.

[xeanhort]

Tried the with the updated version but still fails with the same error. Also I've moved to node v14.2.0 without any improvement :(

This is the "updated" error log:

2020-05-06T07:45:09.161Z] ERROR: Handshake.js/5216 on 8NEO6A5: Handshake failed (cache_key=_2, deviceID=XXXXXXXXXXXXXXXXXXXXXXXX, ip=::ffff:XX.XX.XX.XX)
Error: Failed to match tag: "objid" at: ["algorithmIdentifier"]["parameters"]
at DecoderBuffer.error (D:\spark-server\node_modules\asn1.js\lib\asn1\base\reporter.js:78:11)
at DERNode.decodeTag [as _decodeTag] (D:\spark-server\node_modules\asn1.js\lib\asn1\decoders\der.js:71:19)
at DERNode.decode [as _decode] (D:\spark-server\node_modules\asn1.js\lib\asn1\base\node.js:341:25)
at decodeChildren (D:\spark-server\node_modules\asn1.js\lib\asn1\base\node.js:378:15)
at Array.forEach ()
at DERNode.decode [as _decode] (D:\spark-server\node_modules\asn1.js\lib\asn1\base\node.js:375:22)
at decodeChildren (D:\spark-server\node_modules\asn1.js\lib\asn1\base\node.js:378:15)
at Array.forEach ()
at DERNode.decode [as _decode] (D:\spark-server\node_modules\asn1.js\lib\asn1\base\node.js:375:22)
at DERNode.decode [as _decode] (D:\spark-server\node_modules\asn1.js\lib\asn1\base\node.js:280:47)
at Generated.decode (D:\spark-server\node_modules\asn1.js\lib\asn1\decoders\der.js:28:20)
at Entity.decode (D:\spark-server\node_modules\asn1.js\lib\asn1\api.js:44:32)
at parseSpki (D:\spark-server\node_modules\ec-key\src\ec-key.js:158:27)
at parsePem (D:\spark-server\node_modules\ec-key\src\ec-key.js:184:12)
at new ECKey (D:\spark-server\node_modules\ec-key\src\ec-key.js:237:15)
at new DeviceKey (D:\spark-server\node_modules\spark-protocol\dist\lib\DeviceKey.js:32:25)
at DeviceKey.equals (D:\spark-server\node_modules\spark-protocol\dist\lib\DeviceKey.js:75:20)
at Handshake._callee5$ (D:\spark-server\node_modules\spark-protocol\dist\lib\Handshake.js:383:29)
at tryCatch (D:\spark-server\node_modules\regenerator-runtime\runtime.js:62:40)
at Generator.invoke [as _invoke] (D:\spark-server\node_modules\regenerator-runtime\runtime.js:296:22)
at Generator.prototype. [as next] (D:\spark-server\node_modules\regenerator-runtime\runtime.js:114:21)
at step (D:\spark-server\node_modules\babel-runtime\helpers\asyncToGenerator.js:17:30)
at D:\spark-server\node_modules\babel-runtime\helpers\asyncToGenerator.js:28:13
[2020-05-06T07:45:09.161Z] INFO: Device.js/5216 on 8NEO6A5: Device disconnected (cache_key=_2, deviceID="", disconnectCounter=1)
[2020-05-06T07:45:09.163Z] ERROR: DeviceServer.js/5216 on 8NEO6A5: Device startup failed (deviceID=null)
Error: Failed to match tag: "objid" at: ["algorithmIdentifier"]["parameters"]
at DecoderBuffer.error (D:\spark-server\node_modules\asn1.js\lib\asn1\base\reporter.js:78:11)
at DERNode.decodeTag [as _decodeTag] (D:\spark-server\node_modules\asn1.js\lib\asn1\decoders\der.js:71:19)
at DERNode.decode [as _decode] (D:\spark-server\node_modules\asn1.js\lib\asn1\base\node.js:341:25)
at decodeChildren (D:\spark-server\node_modules\asn1.js\lib\asn1\base\node.js:378:15)
at Array.forEach ()
at DERNode.decode [as _decode] (D:\spark-server\node_modules\asn1.js\lib\asn1\base\node.js:375:22)
at decodeChildren (D:\spark-server\node_modules\asn1.js\lib\asn1\base\node.js:378:15)
at Array.forEach ()
at DERNode.decode [as _decode] (D:\spark-server\node_modules\asn1.js\lib\asn1\base\node.js:375:22)
at DERNode.decode [as _decode] (D:\spark-server\node_modules\asn1.js\lib\asn1\base\node.js:280:47)
at Generated.decode (D:\spark-server\node_modules\asn1.js\lib\asn1\decoders\der.js:28:20)
at Entity.decode (D:\spark-server\node_modules\asn1.js\lib\asn1\api.js:44:32)
at parseSpki (D:\spark-server\node_modules\ec-key\src\ec-key.js:158:27)
at parsePem (D:\spark-server\node_modules\ec-key\src\ec-key.js:184:12)
at new ECKey (D:\spark-server\node_modules\ec-key\src\ec-key.js:237:15)
at new DeviceKey (D:\spark-server\node_modules\spark-protocol\dist\lib\DeviceKey.js:32:25)
at DeviceKey.equals (D:\spark-server\node_modules\spark-protocol\dist\lib\DeviceKey.js:75:20)
at Handshake._callee5$ (D:\spark-server\node_modules\spark-protocol\dist\lib\Handshake.js:383:29)
at tryCatch (D:\spark-server\node_modules\regenerator-runtime\runtime.js:62:40)
at Generator.invoke [as _invoke] (D:\spark-server\node_modules\regenerator-runtime\runtime.js:296:22)
at Generator.prototype. [as next] (D:\spark-server\node_modules\regenerator-runtime\runtime.js:114:21)
at step (D:\spark-server\node_modules\babel-runtime\helpers\asyncToGenerator.js:17:30)
at D:\spark-server\node_modules\babel-runtime\helpers\asyncToGenerator.js:28:13
[2020-05-06T07:45:13.036Z] ERROR: Handshake.js/5216 on 8NEO6A5: Handshake failed (cache_key=_1, deviceID=null, ip=::ffff:XX.XX.XX.XX)
Error: Handshake did not complete in 10 seconds
at Timeout._onTimeout (D:\spark-server\node_modules\spark-protocol\dist\lib\Handshake.js:236:23)
at listOnTimeout (internal/timers.js:549:17)
at processTimers (internal/timers.js:492:7)
[2020-05-06T07:45:13.037Z] INFO: Device.js/5216 on 8NEO6A5: Device disconnected (cache_key=_1, deviceID="", disconnectCounter=1)

[jlkalberer]

The only thing I can think of is that the key is improperly formatted.

Can you run a test script with ec-key which tries to parse the device's key? (I am slammed at work so I can't debug this)
var key = new ECKey(pem_key, 'pem');
I'm wondering if the format of the device key has changed in newer versions of Particle firmware. I use P1s for my fleet so I don't ever test this.

[xeanhort]

There the test with the two keys. The one in deviceKeys.db (also matches the generated XXXXX_rsa_new.pub.pem) and the one received from the device during handshake.

const ECKey = require('ec-key');

device_db_pem = "-----BEGIN PUBLIC KEY-----\nMFkwEwYHKoZIzj0CAQYIKoZIzj0DAQcDQgAEaUXZhpYnCARKEx1FGFrOgu8Dgyb5\n//Drwxg2oR8LkP37MDj7ESmj78PdBqD6PeNmvBMQg5Z7NQ8saRDxX1h50g==\n-----END PUBLIC KEY-----\n"

device_sent_pem = "-----BEGIN PUBLIC KEY-----\nMIGfMA0GCSqGSIb3DQEBAQUAA4GNADCBiQKBgQBThDnRSoUGN20VitFNf4Kj1wWh\nIdiJvFJ4CPj2oAoGCCqGSM49AwEHoUQDQgAEaUXZhpYnCARKEx1FGFrOgu8Dgyb5\n//Drwxg2oR8LkP37MDj7ESmj78PdBqD6PeNmvBMQg5Z7NQ8saRDxX1h50v//////\n/////////////////wIDAQAB\n-----END PUBLIC KEY-----\n"

var key = new ECKey(device_db_pem, 'pem');
console.log(key)

var key2 = new ECKey(device_sent_pem, 'pem');
console.log(key2)
/* The second throws the error:
D:\spark-server>node test.js

D:\spark-server\node_modules\asn1.js\lib\asn1\base\reporter.js:84
    throw err;
    ^
ReporterError: Failed to match tag: "objid" at: ["algorithmIdentifier"]["parameters"]
    at DecoderBuffer.error (D:\spark-server\node_modules\asn1.js\lib\asn1\base\reporter.js:78:11)
    at DERNode.decodeTag [as _decodeTag] (D:\spark-server\node_modules\asn1.js\lib\asn1\decoders\der.js:71:19)
    at DERNode.decode [as _decode] (D:\spark-server\node_modules\asn1.js\lib\asn1\base\node.js:341:25)
    at decodeChildren (D:\spark-server\node_modules\asn1.js\lib\asn1\base\node.js:378:15)
    at Array.forEach (<anonymous>)
    at DERNode.decode [as _decode] (D:\spark-server\node_modules\asn1.js\lib\asn1\base\node.js:375:22)
    at decodeChildren (D:\spark-server\node_modules\asn1.js\lib\asn1\base\node.js:378:15)
    at Array.forEach (<anonymous>)
    at DERNode.decode [as _decode] (D:\spark-server\node_modules\asn1.js\lib\asn1\base\node.js:375:22)
    at DERNode.decode [as _decode] (D:\spark-server\node_modules\asn1.js\lib\asn1\base\node.js:280:47) {
  path: '["algorithmIdentifier"]["parameters"]'
}
*/

[jlkalberer]

Ok -- that's super helpful. It's definitely a different format. I'm wondering if it's just an RSA key instead of an EC key.

particle-iot/particle-cli#280

This makes me think that I don't need the ec-key parsing code since I'm not using UDP.

[xeanhort]

I'm not completely sure of how is this issue related because I always use --protocol tcp in all particlecli commands. Also, that issue is closed, so not sure how they finally implemented it.