chore(algorithms, sliding-window, find-repeated-dna-sequences: minor fixes to naive implementation

Author: BrianLusina

algorithms/sliding_window/repeated_dna_sequences/__init__.py

@@ -13,14 +13,19 @@ def find_repeated_dna_sequences_naive(dna_sequence: str) -> List[str]:
     Returns:
         List[str]
     """
+    if len(dna_sequence) <= 10:
+        return []
+
     result_set = set()
-    seen: Dict[str, bool] = {}
+    seen = set()
     for idx in range(len(dna_sequence)):
         subsequence = dna_sequence[idx:idx+10]
+        if len(subsequence) < 10:
+            continue
         if subsequence in seen:
             result_set.add(subsequence)
         else:
-            seen[subsequence]=True
+            seen.add(subsequence)
 
     return list(result_set)
 

algorithms/sliding_window/repeated_dna_sequences/test_repeated_dna_sequences.py

@@ -1,5 +1,5 @@
 import unittest
-from . import find_repeated_dna_sequences
+from . import find_repeated_dna_sequences, find_repeated_dna_sequences_naive
 
 
 class FindRepeatedDnaSequencesTestCase(unittest.TestCase):
@@ -39,5 +39,42 @@ def test_6(self):
         actual = find_repeated_dna_sequences(dna_sequence)
         self.assertEqual(expected, actual)
 
+class FindRepeatedDnaSequencesNaiveTestCase(unittest.TestCase):
+    def test_1(self):
+        dna_sequence = "AAAAACCCCCAAAAACCCCCCAAAAAGGGTTT"
+        expected = ["CCCCCAAAAA", "AAAAACCCCC"]
+        actual = find_repeated_dna_sequences_naive(dna_sequence)
+        self.assertEqual(sorted(expected), sorted(actual))
+
+    def test_2(self):
+        dna_sequence = "GGGGGGGGGGGGGGGGGGGG"
+        expected = ["GGGGGGGGGG"]
+        actual = find_repeated_dna_sequences_naive(dna_sequence)
+        self.assertEqual(expected, actual)
+
+    def test_3(self):
+        dna_sequence = "TTTGGGAAATTTGGGAAACC"
+        expected = []
+        actual = find_repeated_dna_sequences_naive(dna_sequence)
+        self.assertEqual(expected, actual)
+
+    def test_4(self):
+        dna_sequence = "AAAAAAAAAAAAA"
+        expected = ["AAAAAAAAAA"]
+        actual = find_repeated_dna_sequences_naive(dna_sequence)
+        self.assertEqual(expected, actual)
+
+    def test_5(self):
+        dna_sequence = "ACGTACGTACGTACGTACGTACGTACGTACGT"
+        expected = ["ACGTACGTAC","CGTACGTACG","GTACGTACGT","TACGTACGTA"]
+        actual = find_repeated_dna_sequences_naive(dna_sequence)
+        self.assertEqual(sorted(expected), sorted(actual))
+
+    def test_6(self):
+        dna_sequence = "GTACGTACGTACGCCCCCCCCGGGGG"
+        expected = []
+        actual = find_repeated_dna_sequences_naive(dna_sequence)
+        self.assertEqual(expected, actual)
+
 if __name__ == '__main__':
     unittest.main()