Fix incorrect max stats calculation (TGSAI#665)

BrianMichell · web-flow · commit 3e04f4349452 · 2025-09-12T13:59:03.000-05:00
diff --git a/src/mdio/segy/blocked_io.py b/src/mdio/segy/blocked_io.py
@@ -47,7 +47,7 @@ def _create_stats() -> SummaryStatistics:
 def _update_stats(final_stats: SummaryStatistics, partial_stats: SummaryStatistics) -> None:
     final_stats.count += partial_stats.count
     final_stats.min = min(final_stats.min, partial_stats.min)
-    final_stats.max = min(final_stats.max, partial_stats.max)
+    final_stats.max = max(final_stats.max, partial_stats.max)
     final_stats.sum += partial_stats.sum
     final_stats.sum_squares += partial_stats.sum_squares
 
diff --git a/tests/integration/test_segy_import_export.py b/tests/integration/test_segy_import_export.py
@@ -277,7 +277,7 @@ def test_variable_metadata(self, zarr_tmp: Path) -> None:
             "sum": -8594.551666259766,
             "sumSquares": 40571291.6875,
             "min": -8.375323295593262,
-            "max": 0.0,
+            "max": 7.723702430725098,
             "histogram": {"counts": [], "binCenters": []},
         }
         actual_attrs_json = json.loads(ds["amplitude"].attrs["statsV1"])

Original file line number	Diff line number	Diff line change
`@@ -277,7 +277,7 @@ def test_variable_metadata(self, zarr_tmp: Path) -> None:`
`277`	`277`	`"sum": -8594.551666259766,`
`278`	`278`	`"sumSquares": 40571291.6875,`
`279`	`279`	`"min": -8.375323295593262,`
`280`		`- "max": 0.0,`
	`280`	`+ "max": 7.723702430725098,`
`281`	`281`	`"histogram": {"counts": [], "binCenters": []},`
`282`	`282`	`}`
`283`	`283`	`actual_attrs_json = json.loads(ds["amplitude"].attrs["statsV1"])`