extend per-file ignores for PLR2004 and remove noqa overrides in specific tests

Author: tasansal

pyproject.toml

@@ -134,7 +134,7 @@ ignore = [
 ]
 
 [tool.ruff.lint.per-file-ignores]
-"tests/*" = ["S101"]
+"tests/*" = ["S101", "PLR2004"]
 "tests/integration/test_segy_import_export_masked.py" = ["E501"]
 "docs/tutorials/*.ipynb" = ["S101"]
 

tests/integration/test_segy_import_export.py

@@ -272,8 +272,8 @@ class TestReader:
     def test_meta_read(self, zarr_tmp: Path) -> None:
         """Metadata reading tests."""
         mdio = MDIOReader(zarr_tmp.__str__())
-        assert mdio.binary_header["samples_per_trace"] == 1501  # noqa: PLR2004
-        assert mdio.binary_header["sample_interval"] == 2000  # noqa: PLR2004
+        assert mdio.binary_header["samples_per_trace"] == 1501
+        assert mdio.binary_header["sample_interval"] == 2000
 
     def test_grid(self, zarr_tmp: Path) -> None:
         """Grid reading tests."""

tests/unit/test_dimension.py

@@ -17,7 +17,7 @@ class TestDimension:
 
     def test_len(self, my_dimension: Dimension) -> None:
         """Test length method."""
-        assert len(my_dimension) == 4  # noqa: PLR2004
+        assert len(my_dimension) == 4
 
     @pytest.mark.parametrize(("index", "expected"), [(1, 12), (-1, 16), (2, 14)])
     def test_getitem(self, my_dimension: Dimension, index: int, expected: int) -> None:

tests/unit/v1/test_dataset_builder_add_coordinate.py

@@ -1,7 +1,3 @@
-# ruff: noqa: PLR2004
-# PLR2004 Magic value used in comparison, consider replacing `3` with a constant variable
-# The above erroneous warning is generated for every numerical assert.
-# Thus, disable it for this file
 """Tests the schema v1 dataset_builder.add_coordinate() public API."""
 
 import pytest

tests/unit/v1/test_dataset_builder_add_dimension.py

@@ -1,7 +1,3 @@
-# ruff: noqa: PLR2004
-# PLR2004 Magic value used in comparison, consider replacing `3` with a constant variable
-# The above erroneous warning is generated for every numerical assert.
-# Thus, disable it for this file
 """Tests the schema v1 dataset_builder.add_dimension() public API."""
 
 import pytest

tests/unit/v1/test_dataset_builder_add_variable.py

@@ -1,7 +1,3 @@
-# ruff: noqa: PLR2004
-# PLR2004 Magic value used in comparison, consider replacing `3` with a constant variable
-# The above erroneous warning is generated for every numerical assert.
-# Thus, disable it for this file
 """Tests the schema v1 dataset_builder.add_variable() public API."""
 
 import pytest

tests/unit/v1/test_dataset_builder_build.py

@@ -1,7 +1,3 @@
-# ruff: noqa: PLR2004
-# PLR2004 Magic value used in comparison, consider replacing `3` with a constant variable
-# The above erroneous warning is generated for every numerical assert.
-# Thus, disable it for this file
 """Tests the schema v1 dataset_builder.build() public API."""
 
 from mdio.schemas.dtype import ScalarType

tests/unit/v1/test_dataset_builder_helpers.py

@@ -1,7 +1,3 @@
-# ruff: noqa: PLR2004
-# PLR2004 Magic value used in comparison, consider replacing `3` with a constant variable
-# The above erroneous warning is generated for every numerical assert.
-# Thus, disable it for this file
 """Tests the schema v1 dataset_builder internal methods."""
 
 from datetime import UTC

tests/unit/v1/test_dataset_serializer.py

@@ -1,7 +1,3 @@
-# ruff: noqa: PLR2004
-# PLR2004 Magic value used in comparison, consider replacing `3` with a constant variable
-# The above erroneous warning is generated for every numerical assert.
-# Thus, disable it for this file
 """Tests the schema v1 dataset_serializer public API."""
 
 import pytest