Skip to content

Commit cd7d196

Browse files
committed
Use more correct template name
1 parent eae2c09 commit cd7d196

File tree

5 files changed

+22
-18
lines changed

5 files changed

+22
-18
lines changed

src/mdio/builder/template_registry.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,10 @@
2626
from mdio.builder.templates.seismic_3d_poststack import Seismic3DPostStackTemplate
2727
from mdio.builder.templates.seismic_3d_prestack_cdp import Seismic3DPreStackCDPTemplate
2828
from mdio.builder.templates.seismic_3d_prestack_coca import Seismic3DPreStackCocaTemplate
29-
from mdio.builder.templates.seismic_3d_prestack_field_records import Seismic3DPreStackFieldRecordsTemplate
3029
from mdio.builder.templates.seismic_3d_prestack_shot import Seismic3DPreStackShotTemplate
30+
from mdio.builder.templates.seismic_3d_prestack_streamer_field_records import (
31+
Seismic3DPreStackStreamerFieldRecordsTemplate,
32+
)
3133

3234
if TYPE_CHECKING:
3335
from mdio.builder.templates.base import AbstractDatasetTemplate
@@ -134,7 +136,7 @@ def _register_default_templates(self) -> None:
134136
self.register(Seismic3DPreStackCocaTemplate("depth"))
135137

136138
# Field (shot) data
137-
self.register(Seismic3DPreStackFieldRecordsTemplate("time"))
139+
self.register(Seismic3DPreStackStreamerFieldRecordsTemplate("time"))
138140
self.register(Seismic2DPreStackShotTemplate("time"))
139141
self.register(Seismic3DPreStackShotTemplate("time"))
140142

src/mdio/builder/templates/seismic_3d_prestack_field_records.py renamed to src/mdio/builder/templates/seismic_3d_prestack_streamer_field_records.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,12 @@
88
from mdio.builder.templates.types import SeismicDataDomain
99

1010

11-
class Seismic3DPreStackFieldRecordsTemplate(AbstractDatasetTemplate):
11+
class Seismic3DPreStackStreamerFieldRecordsTemplate(AbstractDatasetTemplate):
1212
"""Seismic pre-stack time Dataset template.
1313
14-
This should be used for both 2D and 3D datasets. Common-shot or common-channel datasets
14+
A generalized template for pre-stack field records in either 2D or 3D.
15+
- Common-shot dataset
16+
- Common-channel dataset
1517
1618
Args:
1719
data_domain: The domain of the dataset.
@@ -31,7 +33,7 @@ def __init__(self, data_domain: SeismicDataDomain):
3133

3234
@property
3335
def _name(self) -> str:
34-
return f"PreStackFieldRecords3D{self._data_domain.capitalize()}"
36+
return f"PreStackStreamerFieldRecords3D{self._data_domain.capitalize()}"
3537

3638
def _load_dataset_attributes(self) -> dict[str, Any]:
3739
return {

tests/integration/test_import_streamer_grid_overrides.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -178,7 +178,7 @@ def test_import_6d_segy( # noqa: PLR0913
178178

179179
segy_to_mdio(
180180
segy_spec=segy_spec,
181-
mdio_template=TemplateRegistry().get("PreStackFieldRecords3DTime"),
181+
mdio_template=TemplateRegistry().get("PreStackStreamerFieldRecords3DTime"),
182182
input_path=segy_path,
183183
output_path=zarr_tmp,
184184
overwrite=True,

tests/unit/v1/templates/test_seismic_3d_prestack_field_records.py renamed to tests/unit/v1/templates/test_seismic_3d_prestack_streamer_field_records.py

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
from mdio.builder.schemas.v1.units import LengthUnitModel
1414
from mdio.builder.schemas.v1.units import TimeUnitEnum
1515
from mdio.builder.schemas.v1.units import TimeUnitModel
16-
from mdio.builder.templates.seismic_3d_prestack_field_records import Seismic3DPreStackFieldRecordsTemplate
16+
from mdio.builder.templates.seismic_3d_prestack_streamer_field_records import Seismic3DPreStackStreamerFieldRecordsTemplate
1717

1818
UNITS_METER = LengthUnitModel(length=LengthUnitEnum.METER)
1919
UNITS_SECOND = TimeUnitModel(time=TimeUnitEnum.SECOND)
@@ -79,15 +79,15 @@ def _validate_coordinates_headers_trace_mask(dataset: Dataset, headers: Structur
7979
assert coord.metadata.units_v1.length == LengthUnitEnum.METER
8080

8181

82-
class TestSeismic3DPreStackFieldRecordsTemplate:
83-
"""Unit tests for Seismic3DPreStackFieldRecordsTemplate."""
82+
class TestSeismic3DPreStackStreamerFieldRecordsTemplate:
83+
"""Unit tests for Seismic3DPreStackStreamerFieldRecordsTemplate."""
8484

8585
def test_configuration(self) -> None:
86-
"""Unit tests for Seismic3DPreStackFieldRecordsTemplate."""
87-
t = Seismic3DPreStackFieldRecordsTemplate(data_domain="time")
86+
"""Unit tests for Seismic3DPreStackStreamerFieldRecordsTemplate."""
87+
t = Seismic3DPreStackStreamerFieldRecordsTemplate(data_domain="time")
8888

8989
# Template attributes
90-
assert t.name == "PreStackFieldRecords3DTime"
90+
assert t.name == "PreStackStreamerFieldRecords3DTime"
9191
assert t._dim_names == ("shot_line", "gun", "shot_point", "cable", "channel", "time")
9292
assert t._physical_coord_names == ("source_coord_x", "source_coord_y", "group_coord_x", "group_coord_y")
9393
# TODO(Anyone): Disable chunking in time domain when support is merged.
@@ -104,17 +104,17 @@ def test_configuration(self) -> None:
104104
assert t.default_variable_name == "amplitude"
105105

106106
def test_build_dataset(self, structured_headers: StructuredType) -> None:
107-
"""Unit tests for Seismic3DPreStackFieldRecordsTemplate build."""
108-
t = Seismic3DPreStackFieldRecordsTemplate(data_domain="time")
107+
"""Unit tests for Seismic3DPreStackStreamerFieldRecordsTemplate build."""
108+
t = Seismic3DPreStackStreamerFieldRecordsTemplate(data_domain="time")
109109
t.add_units({"source_coord_x": UNITS_METER, "source_coord_y": UNITS_METER}) # spatial domain units
110110
t.add_units({"group_coord_x": UNITS_METER, "group_coord_y": UNITS_METER}) # spatial domain units
111111
t.add_units({"time": UNITS_SECOND}) # data domain units
112112

113113
dataset = t.build_dataset(
114-
"North Sea 3D Field Records", sizes=(1, 3, 256, 512, 24, 2048), header_dtype=structured_headers
114+
"North Sea 3D Streamer Field Records", sizes=(1, 3, 256, 512, 24, 2048), header_dtype=structured_headers
115115
)
116116

117-
assert dataset.metadata.name == "North Sea 3D Field Records"
117+
assert dataset.metadata.name == "North Sea 3D Streamer Field Records"
118118
assert dataset.metadata.attributes["surveyDimensionality"] == "3D"
119119
assert dataset.metadata.attributes["ensembleType"] == "shot_point"
120120
assert dataset.metadata.attributes["processingStage"] == "pre-stack"
@@ -139,6 +139,6 @@ def test_build_dataset(self, structured_headers: StructuredType) -> None:
139139
@pytest.mark.parametrize("data_domain", ["Time", "TiME"])
140140
def test_domain_case_handling(data_domain: str) -> None:
141141
"""Test that domain parameter handles different cases correctly."""
142-
template = Seismic3DPreStackFieldRecordsTemplate(data_domain=data_domain)
142+
template = Seismic3DPreStackStreamerFieldRecordsTemplate(data_domain=data_domain)
143143
assert template._data_domain == data_domain.lower()
144144
assert template.name.endswith(data_domain.capitalize())

tests/unit/v1/templates/test_template_registry.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
"PreStackCdpAngleGathers3DDepth",
3232
"PreStackCocaGathers3DTime",
3333
"PreStackCocaGathers3DDepth",
34-
"PreStackFieldRecords3DTime",
34+
"PreStackStreamerFieldRecords3DTime",
3535
"PreStackShotGathers2DTime",
3636
"PreStackShotGathers3DTime",
3737
]

0 commit comments

Comments
 (0)