Unable to find a resilience pipeline

[horsdal]

How can I register and use resiliency pipelines?
I have the code below where I try to first register a couple of resiliency pipelines and then use one of them in a command handler via an attribute, but the it throws because the pipeline is not found while creating the command processor:

info: Paramore.Brighter.CommandProcessor[148105941]
      Building send pipeline for command: GreetCommand 0199ee3a-aa99-71f5-aed6-85e7e10b87b8
Unhandled exception. Paramore.Brighter.ConfigurationException: Error when building pipeline, see inner Exception for details
 ---> System.Collections.Generic.KeyNotFoundException: Unable to find a resilience pipeline associated with the key 'ImmediateRetry'. Please ensure that either the resilience pipeline or the builder is registered.
   at Polly.Registry.ResiliencePipelineProvider`1.GetPipeline(TKey key)
   at Paramore.Brighter.Policies.Handlers.ResilienceExceptionPolicyHandler`1.InitializeFromAttributeParams(Object[] initializerList) in /_/src/Paramore.Brighter/Policies/Handlers/ResilienceExceptionPolicyHandler.cs:line 74
   at Paramore.Brighter.HandlerFactory`1.CreateRequestHandler(IAmALifetime lifetime) in /_/src/Paramore.Brighter/HandlerFactory.cs:line 54
   at Paramore.Brighter.PipelineBuilder`1.<>c__DisplayClass21_0.<PushOntoPipeline>b__0(RequestHandlerAttribute attribute) in /_/src/Paramore.Brighter/PipelineBuilder.cs:line 395
   at Paramore.Brighter.Extensions.EnumerationExtensions.Each[T](IEnumerable`1 collection, Action`1 doThis) in /_/src/Paramore.Brighter/Extensions/Each.cs:line 43
   at Paramore.Brighter.PipelineBuilder`1.PushOntoPipeline(IEnumerable`1 attributes, IHandleRequests`1 lastInPipeline, IRequestContext requestContext, IAmALifetime instanceScope) in /_/src/Paramore.Brighter/PipelineBuilder.cs:line 390
   at Paramore.Brighter.PipelineBuilder`1.BuildPipeline(RequestHandler`1 implicitHandler, IRequestContext requestContext, IAmALifetime instanceScope) in /_/src/Paramore.Brighter/PipelineBuilder.cs:line 217
   at Paramore.Brighter.PipelineBuilder`1.<>c__DisplayClass10_0.<Build>b__0(Type observer) in /_/src/Paramore.Brighter/PipelineBuilder.cs:line 114
   at Paramore.Brighter.Extensions.EnumerationExtensions.Each[T](IEnumerable`1 collection, Action`1 doThis) in /_/src/Paramore.Brighter/Extensions/Each.cs:line 43
   at Paramore.Brighter.PipelineBuilder`1.Build(TRequest request, IRequestContext requestContext) in /_/src/Paramore.Brighter/PipelineBuilder.cs:line 107
   --- End of inner exception stack trace ---
   at Paramore.Brighter.PipelineBuilder`1.Build(TRequest request, IRequestContext requestContext) in /_/src/Paramore.Brighter/PipelineBuilder.cs:line 124
   at Paramore.Brighter.CommandProcessor.Send[T](T command, RequestContext requestContext) in /_/src/Paramore.Brighter/CommandProcessor.cs:line 318

And the code:

var host = Host.CreateDefaultBuilder()
    .ConfigureServices(services =>
    {
        services.AddBrighter(opt =>
            {
                var resiliencePipelineRegistry = new ResiliencePipelineRegistry<string>(); 

                resiliencePipelineRegistry
                    .GetOrAddPipeline(
                        Constants.ImmediateRetry, // <-- seems to be removed from the pipelines avaiable to the command processor
                        builder => builder
                            .AddRetry(new RetryStrategyOptions{ MaxRetryAttempts = 10, Delay = TimeSpan.Zero}).Build());
    
                resiliencePipelineRegistry
                    .GetOrAddPipeline(
                        CommandProcessor.OutboxProducer,  // <-- A different exception is thown if no pipeline with this key is registered
                        builder => builder
                            .AddRetry(new RetryStrategyOptions{ MaxRetryAttempts = 1, Delay = TimeSpan.Zero}));

                opt.ResiliencePipelineRegistry = resiliencePipelineRegistry;

            })
            .AutoFromAssemblies();
        services.AddLogging(configure => configure.AddConsole());
    })
    .Build();

var commandBus = host.Services.GetRequiredService<IAmACommandProcessor>();
commandBus.Send(new GreetCommand($"Brighter{i}"));

static class Constants
{
    public const string ImmediateRetry = "ImmediateRetry";
}

class GreetCommand(string name) : Command(Id.Random())
{
    public string Name { get; init; } = name;
}

class GreetCommandHandler(ILogger<GreetCommandHandler> logger) : RequestHandler<GreetCommand>
{
    [RequestLogging(step: 0, timing: HandlerTiming.Before)]
    [UseResiliencePipeline(step: 1, policy: Constants.ImmediateRetry)] // <--- No exception is thrown if this line is removed
    public override GreetCommand Handle(GreetCommand command)
    {
        Console.WriteLine($"Sync hello {name}");
    }
}

I am using version 10.0.1
I could easily be wrong, but it seems to me the issue could be in CommandProcessorBuilder.Resilience where the argument resiliencePipelineRegistry is only used in a guard clause:

        public INeedMessaging Resilience(ResiliencePipelineRegistry<string> resiliencePipelineRegistry, IPolicyRegistry<string>? policyRegistry = null)
        {
            if (!resiliencePipelineRegistry.TryGetPipeline(CommandProcessor.OutboxProducer, out _))
            {
                throw new ConfigurationException("The resilience pipeline registry is missing the CommandProcessor.OutboxProducer resilience pipeline which is required");
            }
            
            policyRegistry ??= new DefaultPolicy();
#pragma warning disable CS0618 // Type or member is obsolete
            if (!policyRegistry.ContainsKey(CommandProcessor.RETRYPOLICY))
            {
                throw new ConfigurationException("The policy registry is missing the CommandProcessor.RETRYPOLICY policy which is required");
            }

            if (!policyRegistry.ContainsKey(CommandProcessor.CIRCUITBREAKER))
            {
                throw new ConfigurationException("The policy registry is missing the CommandProcessor.CIRCUITBREAKER policy which is required");
            }
#pragma warning restore CS0618 // Type or member is obsolete
            
            _policyRegistry = policyRegistry;
            return this;
        }

Any help is very much appreciated!

[lillo42]

I'll try to look at this weekend

[horsdal]

Thank you! No need to rush, though 😊

[lillo42]

I've created this bug issue: #3864