Could somebody please explain to me or give me examples on how "Retry" should be set up with the resilience pipeline builder?

[MaxwellAllen216]

Hi,

I've been at this issue for at least 4 hours. I just want my asynchronous command handler to use the UseResiliencePipelineAsync attribute.

The issue I am having is that I get an error indicating the pipeline needs to be generic, most likely the command model needs to be passed in the generic, but I have been getting several issues.

The Goal:

• Use SQL Server for Inbox, Outbox and as the message broker/queue
• Set up resilience pipelines for asynchronous handlers

Issues:

• If I try and use the synchronous UseResiliencePipeline attribute, I get an error indicating I cannot use it inside an asynchronous handler

• If I try adding a non-generic pipeline, I get a "KeyNotFound" error indicating it tried to look for the pipeline with a generic.

• If I add the generics, I still get the same "KeyNotFound" error. This is most likely because I had switched to using the fluent.brighter package, as it did happen to work the regular way. But I would like to use the fluent package if it's possible to reach my goal with it.

KeyNotFoundException:

Paramore.Brighter.ConfigurationException: Error when building pipeline, see inner Exception for details
 ---> System.Collections.Generic.KeyNotFoundException: Unable to find a generic resilience pipeline of
'UpsertUserCommand' associated with the key 'DatabaseRetry'. Please ensure that either the generic resilience
pipeline or the generic builder is registered.

What I currently have:

       builder.Services
           .AddSingleton<IAmARelationalDatabaseConfiguration>(databaseConfig)
           .AddFluentBrighter(options =>
           {
               options.UseOutboxSweeper(options =>
               {
                   options.SetTimerInterval(5);
                   options.SetBatchSize(100);
                   options.SetMinimumMessageAge(TimeSpan.FromMilliseconds(500));
               });

               options.RequestHandlers(options =>
               {
                   options.FromAssemblies(builder.GetAllAssemblies());
               });

               options.RegisterServices(services =>
               {
                   services.AddTransient(typeof(ValidationHandler<>));
               });

               options.Producers(options =>
               {
                   options.UseMicrosoftSqlServerDistributedLock(databaseConfig);
                   options.UseMicrosoftSqlServerOutbox(databaseConfig);

                   options.AddMicrosoftSqlServerPublication(options =>
                   {
                       options.SetConnection(databaseConfig);

                       options.AddPublication<UpsertUserCommand>(options =>
                       {
                           options.SetQueue("upsert-user");
                           options.SetMakeChannels(OnMissingChannel.Create);
                       });
                   });
               });

               options.Subscriptions(options =>
               {
                   options.UseHandlersAsScoped();
                   options.AddMicrosoftSqlServerChannelFactory(databaseConfig);
                   options.UseMicrosoftSqlServerInbox(databaseConfig);

                   options.AddMicrosoftSqlServerSubscription<UpsertUserCommand>(options =>
                   {
                       options.SetSubscription("upsert-user");
                       options.SetQueue("upsert-user");
                       options.SetMakeChannels(OnMissingChannel.Create);
                       options.SetUnacceptableMessageLimit(5);
                       options.SetMessagePumpType(MessagePumpType.Proactor);
                   });

                   options.AddResiliencePipeline<UpsertUserCommand>("DatabaseRetry", (builder, context) =>
                   {
                       builder.AddRetry(new RetryStrategyOptions // just to note, with the fluent package, AddRetry is not generic
                       {
                           ShouldHandle = new PredicateBuilder()
                               .Handle<DbUpdateException>()
                               .Handle<SqlException>(),
                           MaxRetryAttempts = 3,
                           Delay = TimeSpan.FromSeconds(1),
                           BackoffType = DelayBackoffType.Exponential
                       });
                   });
               });

           });

       return builder;
   }

What am I doing wrong? What is the correct/latest way to add the pipeline?

Thanks for any help!

[iancooper]

Going to move this to a discussion

[iancooper]

Going to check with @lillo42 as he worked on Fluent Brighter

• First, you can find our existing reslience pipelines here: https://brightercommand.gitbook.io/paramore-brighter-documentation/brighter-request-handlers-and-middleware-pipelines/policyretryandcircuitbreaker
• BUT...
• Fluent Brighter is not documented there as it is not part of BrighterCommand
• Fluent Brighter is presented as an alternative to the "out-of-the-box" syntax by one of the contributors, but is not part of the main project. It's not supported by BrighterCommand. Fewer of us will know how to respond to issues in this repository.
• The Fluent Brighter repository is here: https://github.com/lillo42/fluent-brighter
• It might be better to raise issues there.
• It would be great if we could make it more straightforward to use Fluent Brighter, to prevent future frustration
• Possibly we need to add a Contrib section for documenting third-party plugins

At a guess, the type of your resilience pipeline should be <string> and not <UpsertUserCommand>

[iancooper]

@MaxwellAllen216 I'll ping @lillo42 to try and highlight this for you

[MaxwellAllen216]

Thank you, much appreciated! I did end up getting it working how I wanted without fluent, but I'd still like to work with the fluent package, if possible.

[lillo42]

Hey @MaxwellAllen216 can you share your handler?

Maybe you should use this

  options.AddResiliencePipeline("DatabaseRetry", (builder, context) =>
                   {
                       builder.AddRetry(new RetryStrategyOptions // just to note, with the fluent package, AddRetry is not generic
                       {
                           ShouldHandle = new PredicateBuilder()
                               .Handle<DbUpdateException>()
                               .Handle<SqlException>(),
                           MaxRetryAttempts = 3,
                           Delay = TimeSpan.FromSeconds(1),
                           BackoffType = DelayBackoffType.Exponential
                       });
                   });

[MaxwellAllen216]

Hi! Thank you for the response.

Unfortunately, I ended up deciding to switch to MediatR for my use case and don't have Brighter code anymore.

If I do ever switch back to Brighter, I will try any of the potential solutions provided.

[iancooper]

No worries @MaxwellAllen216 Any feedback as to why you switched would be gratefully received, so that we can improve

[MaxwellAllen216]

No worries @MaxwellAllen216 Any feedback as to why you switched would be gratefully received, so that we can improve

Of course!

Brighter and Darker seem like really great tools to use as a MediatR alternative so that it's one tool handling both internal/synchronous and external out-of-process tasks, but the following notes I have are why I decided to go with MediatR for now:

• For someone learning or new to the whole "out-of-process" work idea, the configuration setup for Brighter is definitely a lot (between the inbox/outbox configuration, etc.), which is one reason I tried the fluent package, to potentially have an easier setup and understand each part better.

• For someone using EFCore code-first migrations, it would be extremely nice to have an extension of some sort to have the necessary brighter tables added to my database automatically (without having to manually add them into a migration). This is especially because I've personally been messing around with my database a lot, removing all tables and re-adding migrations, etc.

[iancooper]

Thanks @MaxwellAllen216 that is really valuable feedback

the configuration setup for Brighter is definitely a lot

100%, I think it is one of our biggest weaknesses and we need to find a better, simpler path

For someone using EFCore code-first migrations, it would be extremely nice to have an extension of some sort to have the necessary brighter tables added to my database automatically

Yeah, it is on our radar. We do this ourselves for the samples, and have been discussing a tool extracted from that to do this. I'll make sure it is our backlog.

[MaxwellAllen216]

Thanks @MaxwellAllen216 that is really valuable feedback

the configuration setup for Brighter is definitely a lot

100%, I think it is one of our biggest weaknesses and we need to find a better, simpler path

For someone using EFCore code-first migrations, it would be extremely nice to have an extension of some sort to have the necessary brighter tables added to my database automatically

Yeah, it is on our radar. We do this ourselves for the samples, and have been discussing a tool extracted from that to do this. I'll make sure it is our backlog.

I'm glad to help! I think with just those two updates alone, I would definitely consider switching back to brighter or using it for my next projects.