Skip to content

Commit 6429412

Browse files
committed
[MI-2736]: Review fixes done
1. Changed the case of few endpoints to snake case
1 parent d7b5adf commit 6429412

File tree

2 files changed

+12
-12
lines changed

2 files changed

+12
-12
lines changed

server/plugin/api.go

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -90,17 +90,17 @@ func (p *Plugin) initializeAPI() {
9090
apiRouter.HandleFunc("/user", p.checkAuth(p.attachContext(p.getGitHubUser), ResponseTypeJSON)).Methods(http.MethodPost)
9191
apiRouter.HandleFunc("/todo", p.checkAuth(p.attachUserContext(p.postToDo), ResponseTypeJSON)).Methods(http.MethodPost)
9292
apiRouter.HandleFunc("/reviews", p.checkAuth(p.attachUserContext(p.getReviews), ResponseTypePlain)).Methods(http.MethodGet)
93-
apiRouter.HandleFunc("/yourprs", p.checkAuth(p.attachUserContext(p.getYourPrs), ResponseTypePlain)).Methods(http.MethodGet)
94-
apiRouter.HandleFunc("/prsdetails", p.checkAuth(p.attachUserContext(p.getPrsDetails), ResponseTypePlain)).Methods(http.MethodPost)
95-
apiRouter.HandleFunc("/searchissues", p.checkAuth(p.attachUserContext(p.searchIssues), ResponseTypePlain)).Methods(http.MethodGet)
96-
apiRouter.HandleFunc("/yourassignments", p.checkAuth(p.attachUserContext(p.getYourAssignments), ResponseTypePlain)).Methods(http.MethodGet)
97-
apiRouter.HandleFunc("/createissue", p.checkAuth(p.attachUserContext(p.createIssue), ResponseTypePlain)).Methods(http.MethodPost)
93+
apiRouter.HandleFunc("/your_prs", p.checkAuth(p.attachUserContext(p.getYourPrs), ResponseTypePlain)).Methods(http.MethodGet)
94+
apiRouter.HandleFunc("/prs_details", p.checkAuth(p.attachUserContext(p.getPrsDetails), ResponseTypePlain)).Methods(http.MethodPost)
95+
apiRouter.HandleFunc("/search_issues", p.checkAuth(p.attachUserContext(p.searchIssues), ResponseTypePlain)).Methods(http.MethodGet)
96+
apiRouter.HandleFunc("/your_assignments", p.checkAuth(p.attachUserContext(p.getYourAssignments), ResponseTypePlain)).Methods(http.MethodGet)
97+
apiRouter.HandleFunc("/create_issue", p.checkAuth(p.attachUserContext(p.createIssue), ResponseTypePlain)).Methods(http.MethodPost)
9898
apiRouter.HandleFunc("/close_or_reopen_issue", p.checkAuth(p.attachUserContext(p.closeOrReopenIssue), ResponseTypePlain)).Methods(http.MethodPost)
9999
apiRouter.HandleFunc("/update_issue", p.checkAuth(p.attachUserContext(p.updateIssue), ResponseTypePlain)).Methods(http.MethodPost)
100100
apiRouter.HandleFunc("/edit_issue_modal", p.checkAuth(p.attachUserContext(p.openIssueEditModal), ResponseTypePlain)).Methods(http.MethodPost)
101101
apiRouter.HandleFunc("/close_reopen_issue_modal", p.checkAuth(p.attachUserContext(p.openCloseOrReopenIssueModal), ResponseTypePlain)).Methods(http.MethodPost)
102102
apiRouter.HandleFunc("/attach_comment_issue_modal", p.checkAuth(p.attachUserContext(p.openAttachCommentIssueModal), ResponseTypePlain)).Methods(http.MethodPost)
103-
apiRouter.HandleFunc("/createissuecomment", p.checkAuth(p.attachUserContext(p.createIssueComment), ResponseTypePlain)).Methods(http.MethodPost)
103+
apiRouter.HandleFunc("/create_issue_comment", p.checkAuth(p.attachUserContext(p.createIssueComment), ResponseTypePlain)).Methods(http.MethodPost)
104104
apiRouter.HandleFunc("/mentions", p.checkAuth(p.attachUserContext(p.getMentions), ResponseTypePlain)).Methods(http.MethodGet)
105105
apiRouter.HandleFunc("/unreads", p.checkAuth(p.attachUserContext(p.getUnreads), ResponseTypePlain)).Methods(http.MethodGet)
106106
apiRouter.HandleFunc("/labels", p.checkAuth(p.attachUserContext(p.getLabels), ResponseTypePlain)).Methods(http.MethodGet)

webapp/src/client/client.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -32,15 +32,15 @@ export default class Client {
3232
}
3333

3434
getYourPrs = async () => {
35-
return this.doGet(`${this.url}/yourprs`);
35+
return this.doGet(`${this.url}/your_prs`);
3636
}
3737

3838
getPrsDetails = async (prList) => {
39-
return this.doPost(`${this.url}/prsdetails`, prList);
39+
return this.doPost(`${this.url}/prs_details`, prList);
4040
}
4141

4242
getYourAssignments = async () => {
43-
return this.doGet(`${this.url}/yourassignments`);
43+
return this.doGet(`${this.url}/your_assignments`);
4444
}
4545

4646
getMentions = async () => {
@@ -72,7 +72,7 @@ export default class Client {
7272
}
7373

7474
createIssue = async (payload) => {
75-
return this.doPost(`${this.url}/createissue`, payload);
75+
return this.doPost(`${this.url}/create_issue`, payload);
7676
}
7777

7878
closeOrReopenIssue = async (payload) => {
@@ -84,11 +84,11 @@ export default class Client {
8484
}
8585

8686
searchIssues = async (searchTerm) => {
87-
return this.doGet(`${this.url}/searchissues?term=${searchTerm}`);
87+
return this.doGet(`${this.url}/search_issues?term=${searchTerm}`);
8888
}
8989

9090
attachCommentToIssue = async (payload) => {
91-
return this.doPost(`${this.url}/createissuecomment`, payload);
91+
return this.doPost(`${this.url}/create_issue_comment`, payload);
9292
}
9393

9494
getIssue = async (owner, repo, issueNumber) => {

0 commit comments

Comments
 (0)