Skip to content

Commit 281be0e

Browse files
[MA-27]: Remove tabIndex from non-interactive elements
1 parent d316df6 commit 281be0e

File tree

6 files changed

+1
-10
lines changed

6 files changed

+1
-10
lines changed

webapp/channels/src/components/post/post_component.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -521,7 +521,6 @@ const PostComponent = (props: Props): JSX.Element => {
521521
ref={postRef}
522522
id={getTestId()}
523523
data-testid={postAriaLabelDivTestId}
524-
tabIndex={0}
525524
post={post}
526525
className={getClassName()}
527526
onClick={handlePostClick}

webapp/channels/src/components/post_edit_history/__snapshots__/post_edit_history.test.tsx.snap

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -255,7 +255,6 @@ exports[`components/post_edit_history should match snapshot 1`] = `
255255
class="post-message__text"
256256
dir="auto"
257257
id="rhsPostMessageText_post_id"
258-
tabindex="0"
259258
>
260259
<p>
261260
post message

webapp/channels/src/components/post_view/post_message_view/__snapshots__/post_message_view.test.tsx.snap

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ exports[`components/post_view/PostAttachment should match snapshot 1`] = `
1010
dir="auto"
1111
id="postMessageText_post_id"
1212
onClick={[Function]}
13-
tabIndex={0}
1413
>
1514
<Connect(PostMarkdown)
1615
imageProps={
@@ -47,7 +46,6 @@ exports[`components/post_view/PostAttachment should match snapshot, on Show Less
4746
dir="auto"
4847
id="postMessageText_post_id"
4948
onClick={[Function]}
50-
tabIndex={0}
5149
>
5250
<Connect(PostMarkdown)
5351
imageProps={
@@ -84,7 +82,6 @@ exports[`components/post_view/PostAttachment should match snapshot, on Show More
8482
dir="auto"
8583
id="postMessageText_post_id"
8684
onClick={[Function]}
87-
tabIndex={0}
8885
>
8986
<Connect(PostMarkdown)
9087
imageProps={
@@ -139,7 +136,6 @@ exports[`components/post_view/PostAttachment should match snapshot, on edited po
139136
dir="auto"
140137
id="postMessageText_post_id"
141138
onClick={[Function]}
142-
tabIndex={0}
143139
>
144140
<Connect(PostMarkdown)
145141
imageProps={
@@ -177,7 +173,6 @@ exports[`components/post_view/PostAttachment should match snapshot, on ephemeral
177173
dir="auto"
178174
id="postMessageText_post_id"
179175
onClick={[Function]}
180-
tabIndex={0}
181176
>
182177
<Connect(PostMarkdown)
183178
imageProps={

webapp/channels/src/components/post_view/post_message_view/post_message_view.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,6 @@ export default class PostMessageView extends React.PureComponent<Props, State> {
146146
maxHeight={maxHeight}
147147
>
148148
<div
149-
tabIndex={0}
150149
id={id}
151150
className='post-message__text'
152151
dir='auto'

webapp/channels/src/plugins/test/__snapshots__/post_type.test.tsx.snap

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,6 @@ exports[`plugins/PostMessageView should match snapshot with no extended post typ
125125
dir="auto"
126126
id="postMessageText_post_id"
127127
onClick={[Function]}
128-
tabIndex={0}
129128
>
130129
<Connect(PostMarkdown)
131130
imageProps={

webapp/platform/components/src/generic_modal/__snapshots__/generic_modal.test.tsx.snap

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ exports[`GenericModal should match snapshot for base case 1`] = `
1111
aria-hidden="true"
1212
/>
1313
<div
14-
role="dialog"
14+
role="none"
1515
>
1616
<div
1717
class="fade modal-backdrop in"

0 commit comments

Comments
 (0)