Indicate supported version in package.json #908
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Node 16 has been EOL for over a year, and hasn't been tested in CI since Brooooooklyn#743 was merged last year. The `engines` field in `package.json` should reflect this as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node 16 has been EOL for over a year (since September 11 2023), and hasn't been tested in CI since #743 was merged last year. The
enginesfield inpackage.jsonshould reflect this as well.This should help prevent introducing accidental behaviour changes -- for example, it looks like #889 was merged because it was causing an error on Node 10 (EOL since 2021) and unfortunately it subtly changes the behaviour of
transformPoint(it's no longer possible to call it with awof0). It's possible0is not a valid value forwanyway, but in general these kind of subtle differences can cause a library to work differently for users from version to version and it would be nice to avoid unnecessary changes like this.