Suggestion: Maximize/unmaximize snapping changes

[fossfreedom]

Suggestion

Just in case you want to include the following rc.xml fix:

diff --git a/src/bridges/labwc/rc.xml b/src/bridges/labwc/rc.xml
index 70681674..800db537 100644
--- a/src/bridges/labwc/rc.xml
+++ b/src/bridges/labwc/rc.xml
@@ -239,10 +239,10 @@
                        <action name="Maximize" direction="both" />
                </keybind>
                <keybind bridge="wm.keybindings/maximize-horizontally" key="undefined">
-                       <action name="Maximize" direction="right" />
+                       <action name="ToggleMaximize" direction="horizontal" />
                </keybind>
                <keybind bridge="wm.keybindings/maximize-vertically" key="undefined">
-                       <action name="Maximize" direction="left" />
+                       <action name="ToggleMaximize" direction="vertically" />
                </keybind>
                <keybind bridge="wm.keybindings/begin-move" key="A-F7">
                        <action name="" command="" />
@@ -257,7 +257,7 @@
                        <action name="Resize" />
                </keybind>
                <keybind bridge="wm.keybindings/unmaximize" key="W-Down">
-                       <action name="UnMaximize" direction="both" />
+                       <action name="UnSnap" />
                </keybind>
                <keybind bridge="wm.keybindings/toggle-fullscreen" key="undefined">
                        <action name="ToggleFullscreen" />

What it does

The direction-values in the maximize-horizontally and maximize-vertically bindings are invalid. Because of that, labwc does use both instead and performs a normal window-maximize. Additionally I like it, if I can press the binding twice and its simply toggling the window-state (so actions were switched to ToogleMaximize).

The second thing is change for W-Down from UnMaximize to UnSnap. I noticed, that once a window is snapped to a side, I can't use W-Down to bring it back to its normal state (pressing the key does nothing). Switching that action to "UnSnap" does work in both situations. It performs UnMaximize and UnSnap at the same time.

I know most things are just personal taste .. hopefully changing those makes sense. But if its kept unchanged, I can live with that as well.

Originally posted by @jls17 in #835 (comment)

[jls17]

Just for completeness: In labwc the possible values for direction="..." are both, horizontal and vertical.

For example with vertical you could make a window use the full height of the screen while keeping the width. But currently the values right and left are used. Those invalid values are getting mapped to both (default value) internally by labwc. This results in a window getting fully maximized, which is not the intention of that keybind.

The invalid values should be fixed .. the rest is a suggestion