Add macOS .icns app icon to DMG workflow

Author: BuddySirJava

.github/workflows/macos-dmg.yml

@@ -163,6 +163,25 @@ jobs:
           fi
           ls -la "$RES" || true
 
+          # 2b) Build macOS .icns app icon from our 512px PNG
+          ICON_SRC="data/media/icon_512.png"
+          if [ -f "$ICON_SRC" ]; then
+            ICONSET_DIR="macos/Icon.iconset"
+            rm -rf "$ICONSET_DIR"
+            mkdir -p "$ICONSET_DIR"
+            for sz in 16 32 64 128 256 512; do
+              sips -s format png "$ICON_SRC" --resampleWidth $sz --out "$ICONSET_DIR/icon_${sz}x${sz}.png" >/dev/null
+            done
+            # @2x variants
+            for sz in 16 32 128 256; do
+              db=$(($sz*2))
+              sips -s format png "$ICON_SRC" --resampleWidth $db --out "$ICONSET_DIR/icon_${sz}x${sz}@2x.png" >/dev/null
+            done
+            iconutil -c icns "$ICONSET_DIR" -o "$RES/SSHStudio.icns"
+          else
+            echo "WARN: Icon source $ICON_SRC not found; bundle will lack .icns" >&2
+          fi
+
           # 3) Vendor Python.framework
           BREW_PREFIX="$(brew --prefix)"
           # Dereference symlinks so the framework is self-contained inside the app bundle
@@ -271,6 +290,7 @@ jobs:
             <key>CFBundleIdentifier</key><string>io.github.BuddySirJava.SSH-Studio</string>
             <key>CFBundleName</key><string>SSH Studio</string>
             <key>CFBundleExecutable</key><string>ssh-studio</string>
+            <key>CFBundleIconFile</key><string>SSHStudio</string>
             <key>CFBundlePackageType</key><string>APPL</string>
             <key>LSMinimumSystemVersion</key><string>11.0</string>
           </dict></plist>