Refs #24759: Order Create API Model - use product to find product in quote and request instead of SKU; increased package version

Author: elluminatte

composer.json

@@ -2,7 +2,7 @@
     "name": "budsies/magento1-vsbridge",
     "description": "Vue Storefront bridge - Extension for Magento 1.x",
     "type": "magento-module",
-    "version": "1.0.2",
+    "version": "1.0.3",
     "authors": [
         {
             "name": "d.kochnov",

magento1-module/app/code/local/Divante/VueStorefrontBridge/Model/Api/Order/Create.php

@@ -141,8 +141,7 @@ private function checkAndAddProducts($requestPayload)
         $currentQuoteItems = $this->quote->getAllVisibleItems();
 
         foreach ($clientItems as $product) {
-            $sku = $product->sku;
-            $serverItem = $this->findProductInQuote($sku, $currentQuoteItems);
+            $serverItem = $this->findProductInQuote($product->id, $currentQuoteItems);
 
             if ($serverItem) {
                 if ($product->qty !== $serverItem->getQty()) {
@@ -168,7 +167,8 @@ private function checkAndAddProducts($requestPayload)
         }
 
         foreach ($currentQuoteItems as $item) {
-            $clientItem = $this->findProductInRequest($item->getData('sku'), $clientItems);
+            $itemProductId = (int)$item->getData('product_id');
+            $clientItem = $this->findProductInRequest($itemProductId, $clientItems);
 
             if (null === $clientItem) {
                 $this->quote->deleteItem($item);
@@ -187,26 +187,27 @@ private function addProductToQuote(stdClass $cartItem)
     }
 
     /**
-     * @param $sku
+     * @param $productId
      * @param $items
      *
      * @return Mage_Sales_Model_Quote_Item|null
      */
-    private function findProductInQuote($sku, $items)
+    private function findProductInQuote($productId, $items)
     {
         foreach ($items as $item) {
-            if ($item->getData('sku') === $sku) {
+            $itemProductId = (int)$item->getData('product_id');
+            if ($itemProductId === $productId) {
                 return $item;
             }
         }
 
         return null;
     }
 
-    private function findProductInRequest($cartItemSku, $products)
+    private function findProductInRequest($cartItemProductId, $products)
     {
         foreach ($products as $product) {
-            if ($product->sku === $cartItemSku) {
+            if ($product->id === $cartItemProductId) {
                 return $product;
             }
         }