feat: add UserFeedback crash type and feedback submission helper (#162)

* feat: add UserFeedback crash type and feedback submission helper

Add CrashType.userFeedback, CrashTypeId.userFeedback enum value,
and a new postUserFeedback() helper that constructs XML callstack
from a title and submits via the existing crash post pipeline.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* fix: better user feedback report xml

* fix: use feedback instead of report

* fix: rename upload file to feedback.xml and add attributes option

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* fix: switch to feedback.json with JSON.stringify for escaping

Replace hand-rolled XML builder and escapeXml() with JSON.stringify(),
which handles all escaping natively. Addresses PR review feedback.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

Author: bobbyg603

src/crashes/crashes-api-row/crashes-api-row.ts

@@ -67,6 +67,7 @@ export enum CrashTypeId {
   ps4 = 28,
   ps5 = 29,
   playStationRecap = 30,
+  userFeedback = 36,
 }
 
 export class CrashesApiRow implements CrashDataWithMappedProperties {

src/post/crash-type.ts

@@ -7,5 +7,6 @@ export class CrashType {
     static readonly ps4 = new CrashType('PlayStation 4', 28);
     static readonly ps5 = new CrashType('PlayStation 5', 29);
     static readonly xml = new CrashType('Xml.Report', 21);
+    static readonly userFeedback = new CrashType('User.Feedback', 36);
     private constructor(public readonly name: string, public readonly id: number) { }
 }

src/post/index.ts

@@ -1,2 +1,4 @@
 export { CrashType } from './crash-type';
-export { CrashPostClient } from './crash-post-client';
+export { CrashPostClient } from './crash-post-client';
+export { buildFeedbackJson, postUserFeedback } from './user-feedback';
+export type { UserFeedbackOptions } from './user-feedback';

src/post/user-feedback.spec.ts

@@ -0,0 +1,33 @@
+import { buildFeedbackJson } from './user-feedback';
+
+describe('buildFeedbackJson', () => {
+    it('should produce JSON with title and description', () => {
+        const json = buildFeedbackJson('Login button broken', 'Nothing happens when I tap login');
+        const parsed = JSON.parse(json);
+
+        expect(parsed.title).toBe('Login button broken');
+        expect(parsed.description).toBe('Nothing happens when I tap login');
+    });
+
+    it('should handle empty description', () => {
+        const json = buildFeedbackJson('Crash on startup');
+        const parsed = JSON.parse(json);
+
+        expect(parsed.title).toBe('Crash on startup');
+        expect(parsed.description).toBe('');
+    });
+
+    it('should handle special characters without manual escaping', () => {
+        const json = buildFeedbackJson('Error <"test"> & \'more\'', 'Use <b>bold</b> & "quotes"');
+        const parsed = JSON.parse(json);
+
+        expect(parsed.title).toBe('Error <"test"> & \'more\'');
+        expect(parsed.description).toBe('Use <b>bold</b> & "quotes"');
+    });
+
+    it('should produce valid JSON', () => {
+        const json = buildFeedbackJson('Test', 'Desc');
+
+        expect(() => JSON.parse(json)).not.toThrow();
+    });
+});

src/post/user-feedback.ts

@@ -0,0 +1,46 @@
+import { UploadableFile } from '@common';
+import { CrashPostClient } from './crash-post-client';
+import { CrashType } from './crash-type';
+
+export interface UserFeedbackOptions {
+    title: string;
+    description?: string;
+    user?: string;
+    email?: string;
+    attachments?: UploadableFile[];
+    attributes?: Record<string, string>;
+}
+
+export function buildFeedbackJson(title: string, description?: string): string {
+    return JSON.stringify({
+        title,
+        description: description ?? '',
+    });
+}
+
+export async function postUserFeedback(
+    client: CrashPostClient,
+    application: string,
+    version: string,
+    options: UserFeedbackOptions,
+): Promise<ReturnType<CrashPostClient['postCrash']>> {
+    const json = buildFeedbackJson(options.title, options.description);
+    const jsonBuffer = Buffer.from(json, 'utf-8');
+    const jsonFile = new UploadableFile('feedback.json', jsonBuffer.length, jsonBuffer);
+
+    const attributes: Record<string, string> = { ...options.attributes };
+    if (options.user) {
+        attributes['user'] = options.user;
+    }
+    if (options.email) {
+        attributes['email'] = options.email;
+    }
+
+    return client.postCrash(
+        application,
+        version,
+        CrashType.userFeedback,
+        jsonFile,
+        Object.keys(attributes).length > 0 ? attributes : undefined
+    );
+}