fix!: remove oauth2 scope

Author: bobbyg603

src/common/client/oauth-client-credentials-api-client/oauth-client-credentials-api-client.spec.ts

@@ -55,7 +55,6 @@ describe('OAuthClientCredentialsClient', () => {
             expect(fakeFormData.append).toHaveBeenCalledWith('grant_type', 'client_credentials');
             expect(fakeFormData.append).toHaveBeenCalledWith('client_id', clientId);
             expect(fakeFormData.append).toHaveBeenCalledWith('client_secret', clientSecret);
-            expect(fakeFormData.append).toHaveBeenCalledWith('scope', 'restricted');
             expect((sut as any)._fetch).toHaveBeenCalledWith(
                 jasmine.anything(),
                 jasmine.objectContaining({

src/common/client/oauth-client-credentials-api-client/oauth-client-credentials-api-client.ts

@@ -36,7 +36,6 @@ export class OAuthClientCredentialsClient implements ApiClient {
         body.append('grant_type', 'client_credentials');
         body.append('client_id', this._clientId);
         body.append('client_secret', this._clientSecret);
-        body.append('scope', 'restricted');
         const request = {
             method,
             body,

src/common/data/table-data/table-data-client/table-data-client.ts

@@ -13,7 +13,7 @@ export class TableDataClient {
   async postGetData<T, U = Record<string, unknown> | undefined>(
     request: TableDataRequest,
     formParts: Record<string, string> = {}
-  ): Promise<BugSplatResponse<TableDataResponse<T, U>>> {
+  ): Promise<BugSplatResponse<TableDataResponse<T, U> | ErrorResponse>> {
     const factory = () => this._apiClient.createFormData();
     const formData = new TableDataFormDataBuilder(factory, formParts)
       .withDatabase(request.database)
@@ -95,3 +95,5 @@ export class TableDataClient {
 export type RawResponse<T> = Array<{
   [Property in keyof T as Capitalize<string & Property>]: T[Property];
 }>;
+
+export type ErrorResponse = { message: string };

src/crashes/crashes-api-client/crashes-api-client.ts

@@ -7,6 +7,7 @@ import {
 } from '@common';
 import { CrashesApiRow, CrashesPageData } from '@crashes';
 import { CrashesApiResponseRow } from '../crashes-api-row/crashes-api-row';
+import { ErrorResponse } from 'src/common/data/table-data/table-data-client/table-data-client';
 
 export class CrashesApiClient {
   private _tableDataClient: TableDataClient;
@@ -35,8 +36,22 @@ export class CrashesApiClient {
       CrashesPageData
     >(request);
     const json = await response.json();
-    const pageData = json.pageData;
-    const rows = json.rows.map((row) => new CrashesApiRow(row));
+
+    if (response.status === 400) {
+      throw new Error((json as ErrorResponse).message || 'Bad Request');
+    }
+
+    if (response.status === 401) {
+      throw new Error('Could not authenticate, check credentials and try again');
+    }
+
+    if (response.status === 403) {
+      throw new Error('Forbidden');
+    }
+
+    const responseData = json as TableDataResponse<CrashesApiResponseRow, CrashesPageData>;
+    const pageData = responseData.pageData;
+    const rows = responseData.rows.map((row) => new CrashesApiRow(row));
 
     return {
       rows,

src/summary/summary-api-client/summary-api-client.ts

@@ -1,6 +1,7 @@
 import { ApiClient, TableDataClient, TableDataResponse } from '@common';
 import { SummaryApiResponseRow, SummaryApiRow } from '../summary-api-row/summary-api-row';
 import { SummaryTableDataRequest } from '../summary-table-data/summary-table-data-request';
+import { ErrorResponse } from 'src/common/data/table-data/table-data-client/table-data-client';
 
 export class SummaryApiClient {
 
@@ -20,8 +21,22 @@ export class SummaryApiClient {
         }
         const response = await this._tableDataClient.postGetData<SummaryApiResponseRow>(request, formParts);
         const json = await response.json();
-        const pageData = json.pageData;
-        const rows = json.rows.map(row => new SummaryApiRow(
+
+        if (response.status === 400) {
+            throw new Error((json as ErrorResponse).message || 'Bad Request');
+        }
+
+        if (response.status === 401) {
+            throw new Error('Could not authenticate, check credentials and try again');
+        }
+
+        if (response.status === 403) {
+            throw new Error('Forbidden');
+        }
+
+        const responseData = await response.json() as TableDataResponse<SummaryApiResponseRow>;
+        const pageData = responseData.pageData;
+        const rows = responseData.rows.map(row => new SummaryApiRow(
             row.stackKey,
             Number(row.stackKeyId),
             row.firstReport,