Skip to content

Commit ba80951

Browse files
Battjmosamijaber
andauthored
Chore/bump isolated vm (#4145)
## Description #4137 Bump `isolated-vm` to version 6.x.x, which supports Node 24: https://github.com/laverdet/isolated-vm?tab=readme-ov-file. I took a look through the commits on that release and didn't see anything that looked like it would impact functionality. The tests in the React package seem to all be borked on main so I can't confirm, took a stab at updating the contributing docs in there too to use `yarn` instead of `npm`. I only did it in the React package since I don't want to get too far into the weeds and that's the one I use on my project. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Upgrade isolated-vm to v6 and move tooling to Node 24, introducing major version bumps (dropping Node 18/20) across SDKs with minor doc updates. > > - **Dependencies**: > - Bump `isolated-vm` to `^6.0.0` across `@builder.io/react` and all Gen1/Gen2 SDK packages (`@builder.io/sdk-{react,react-native,react-nextjs,qwik,solid,svelte,vue,angular}`); update `yarn.lock`. > - **CI/Tooling**: > - Update all GitHub Actions workflows to use Node `24.x`; set `.nvmrc` to `v24.4.1`. > - **Releases/Versioning**: > - Add changeset marking major releases for most SDKs and minor for `@builder.io/sdk-{react-nextjs,qwik}` with a breaking change: drop Node 18/20 support; add Node 24 support. > - **Docs**: > - Update React `CONTRIBUTING.md` to use `yarn` instead of `npm` and link to v2 contribution guide. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit bf87407. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: Sami Jaber <me@sami.website>
1 parent fa676e5 commit ba80951

File tree

18 files changed

+66
-49
lines changed

18 files changed

+66
-49
lines changed

.changeset/many-bobcats-wave.md

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
---
2+
'@builder.io/react': major
3+
'@builder.io/sdk-angular': major
4+
'@builder.io/sdk-react-nextjs': minor
5+
'@builder.io/sdk-qwik': minor
6+
'@builder.io/sdk-react': major
7+
'@builder.io/sdk-react-native': major
8+
'@builder.io/sdk-solid': major
9+
'@builder.io/sdk-svelte': major
10+
'@builder.io/sdk-vue': major
11+
---
12+
13+
Bump dependency `isolated-vm` from `5.0.0` to `6.0.0` to add support for Node v24.
14+
15+
BREAKING CHANGE: Drops support for Node 18 and 20.

.github/workflows/ci.yml

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ jobs:
2929
- name: Use Node.js
3030
uses: actions/setup-node@v4
3131
with:
32-
node-version: '18.x'
32+
node-version: '24.x'
3333

3434
- name: 📥 Monorepo install
3535
uses: ./.github/actions/yarn-nm-install
@@ -91,7 +91,7 @@ jobs:
9191
- name: Use Node.js
9292
uses: actions/setup-node@v4
9393
with:
94-
node-version: '18.x'
94+
node-version: '24.x'
9595

9696
- name: 📥 Monorepo install
9797
uses: ./.github/actions/yarn-nm-install
@@ -149,7 +149,7 @@ jobs:
149149
- name: Use Node.js
150150
uses: actions/setup-node@v4
151151
with:
152-
node-version: '18.x'
152+
node-version: '24.x'
153153

154154
- name: 📥 Monorepo install
155155
uses: ./.github/actions/yarn-nm-install
@@ -184,7 +184,7 @@ jobs:
184184
- name: Use Node.js
185185
uses: actions/setup-node@v4
186186
with:
187-
node-version: '18.x'
187+
node-version: '24.x'
188188

189189
- name: 📥 Monorepo install
190190
uses: ./.github/actions/yarn-nm-install
@@ -218,7 +218,7 @@ jobs:
218218
- name: Use Node.js
219219
uses: actions/setup-node@v4
220220
with:
221-
node-version: '18.x'
221+
node-version: '24.x'
222222

223223
- name: 📥 Monorepo install
224224
uses: ./.github/actions/yarn-nm-install
@@ -258,7 +258,7 @@ jobs:
258258
- name: Use Node.js
259259
uses: actions/setup-node@v4
260260
with:
261-
node-version: '18.x'
261+
node-version: '24.x'
262262

263263
- name: 📥 Monorepo install
264264
uses: ./.github/actions/yarn-nm-install
@@ -324,10 +324,10 @@ jobs:
324324
steps:
325325
- uses: actions/checkout@v4
326326

327-
- name: Use node version 18
327+
- name: Use node version 24
328328
uses: actions/setup-node@v4
329329
with:
330-
node-version: '18.x'
330+
node-version: '24.x'
331331

332332
- name: Get npm cache directory
333333
id: npm-cache-dir

.github/workflows/lint-and-commit.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ jobs:
2626
- name: Use Node.js
2727
uses: actions/setup-node@v4
2828
with:
29-
node-version: '18.x'
29+
node-version: '24.x'
3030

3131
- name: 📥 Monorepo install
3232
uses: ./.github/actions/yarn-nm-install

.github/workflows/publish-sdks.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ jobs:
2525
- name: Use Node.js
2626
uses: actions/setup-node@v3
2727
with:
28-
node-version: '18.x'
28+
node-version: 24.x'
2929
registry-url: 'https://registry.npmjs.org'
3030

3131
- name: 📥 Monorepo install

.github/workflows/react-native-sdk-test-remote.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ jobs:
2525
- name: Use Node.js
2626
uses: actions/setup-node@v4
2727
with:
28-
node-version: '18.x'
28+
node-version: '24.x'
2929

3030
- name: 📥 Monorepo install
3131
uses: ./.github/actions/yarn-nm-install

.nvmrc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
v18.20.6
1+
v24.4.1

packages/react/CONTRIBUTING.md

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
We're really glad you're reading this, because we need volunteer developers to help this project come to fruition. 👏
22

3+
Refer to [the v2 contribution guide](../sdks/docs/DEVELOP.md) for more up-to-date information
4+
35
## Instructions
46

57
These steps will guide you through contributing to this project:
@@ -8,10 +10,10 @@ These steps will guide you through contributing to this project:
810
- Clone it and install dependencies
911

1012
git clone https://github.com/YOUR-USERNAME/builder-react
11-
npm install
13+
yarn install
1214

13-
Keep in mind that after running `npm install` the git repo is reset. So a good way to cope with this is to have a copy of the folder to push the changes, and the other to try them.
15+
Keep in mind that after running `yarn install` the git repo is reset. So a good way to cope with this is to have a copy of the folder to push the changes, and the other to try them.
1416

1517
Make and commit your changes. Make sure the commands npm run build and npm run test:prod are working.
1618

17-
Finally send a [GitHub Pull Request](https://github.com/builderio/builder-react/compare?expand=1) with a clear list of what you've done (read more [about pull requests](https://help.github.com/articles/about-pull-requests/)). Make sure all of your commits are atomic (one feature per commit).
19+
Finally send a [GitHub Pull Request](https://github.com/builderio/builder-react/compare?expand=1) with a clear list of what you've done (read more [about pull requests](https://help.github.com/articles/about-pull-requests/)). Make sure all of your commits are atomic (one feature per commit).

packages/react/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@
100100
"@builder.io/sdk": "workspace:*",
101101
"@emotion/core": "^10.0.17",
102102
"hash-sum": "^2.0.0",
103-
"isolated-vm": "^5.0.0",
103+
"isolated-vm": "^6.0.0",
104104
"preact": "^10.1.0"
105105
},
106106
"installConfig": {

packages/sdks/output/angular/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
"build:edge": "cross-env SDK_ENV=edge node ./scripts/multi-build.mjs"
1515
},
1616
"dependencies": {
17-
"isolated-vm": "^5.0.0",
17+
"isolated-vm": "^6.0.0",
1818
"tslib": "^2.3.0"
1919
},
2020
"peerDependencies": {

packages/sdks/output/nextjs/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@
110110
"vite": "^4.5.11"
111111
},
112112
"dependencies": {
113-
"isolated-vm": "^5.0.0"
113+
"isolated-vm": "^6.0.0"
114114
},
115115
"nx": {
116116
"targets": {

0 commit comments

Comments
 (0)