Small improvements to Converter

Author: Christopher Remde

Converter/Sequence_Converter.py

@@ -192,9 +192,13 @@ def convert_model(self, file):
 
         # For pointclouds, normals can be estimated
         if(self.convertSettings.generateNormals and self.convertSettings.isPointcloud):
-            ms.compute_normal_for_point_clouds(k = 10, flipflag = False)
+            ms.compute_normal_for_point_clouds(k = 10, flipflag = False, smoothiter = 10)
             normals = ms.current_mesh().vertex_normal_matrix().astype(np.float32)
 
+            #Pointcloud normal estimation leads to randomly flipped normals between frames
+
+            #To counteract this, we calculate the average normal direction of the pointcloud, and then compare it to the
+            #last frame's average normal
             averageNormal = [np.average(normals[:,0]), np.average(normals[:,1]), np.average(normals[:,2])]
 
             if not self.firstEstimation:
@@ -203,7 +207,8 @@ def convert_model(self, file):
                 v1_norm = averageNormal / np.linalg.norm(averageNormal)
                 v2_norm = self.lastAverageNormal / np.linalg.norm(self.lastAverageNormal)
 
-                # Compute the dot product
+                # The dot product let's us know how if the average normals point in the same direction
+                # (-1 for opposite, 1 for same direction)
                 dot_product = np.dot(v1_norm, v2_norm)
 
                 #Flip normals if the average normal differs too much from the last frame
@@ -310,7 +315,7 @@ def convert_model(self, file):
 
             byteCombination = []
 
-            #Flip vertices and bytes to match Unity's coordinate system
+            #Flip vertice positions and normals to match Unity's coordinate system
             vertices[:,0] *= -1
             normals[:,0] *= -1
 

Converter/Sequence_Metadata.py

@@ -21,7 +21,7 @@ class MetaData():
     hasNormals = False
     maxVertexCount = 0
     maxIndiceCount = 0
-    maxBounds = [0,0,0,0,0,0]
+    minMaxBounds = [0,0,0,0,0,0]
     textureWidth = 0
     textureHeight = 0
     textureSizeDDS = 0
@@ -44,7 +44,7 @@ def get_as_dict(self):
             "hasNormals" : self.hasNormals,
             "maxVertexCount": self.maxVertexCount,
             "maxIndiceCount" : self.maxIndiceCount,
-            "maxBounds" : self.maxBounds,
+            "maxBounds" : self.minMaxBounds,
             "textureWidth" : self.textureWidth,
             "textureHeight" : self.textureHeight,
             "textureSizeDDS" : self.textureSizeDDS,
@@ -71,12 +71,16 @@ def set_metadata_Model(self, vertexCount, indiceCount, headerSize, bounds, geome
             self.maxIndiceCount = indiceCount
 
         for maxBound in range(3):
-            if self.maxBounds[maxBound] < bounds.max()[maxBound]:
-                self.maxBounds[maxBound] = bounds.max()[maxBound]
+            if self.minMaxBounds[maxBound] < bounds.max()[maxBound]:
+                self.minMaxBounds[maxBound] = bounds.max()[maxBound]
 
         for minBound in range(3):
-            if self.maxBounds[minBound + 3] > bounds.min()[minBound]:
-                self.maxBounds[minBound + 3] = bounds.min()[minBound]
+            if self.minMaxBounds[minBound + 3] > bounds.min()[minBound]:
+                self.minMaxBounds[minBound + 3] = bounds.min()[minBound]
+
+        # Flip bounds x axis, as we also flip the model's x axis to match Unity's coordinate system
+        self.minMaxBounds[0] *= -1 # Min X
+        self.minMaxBounds[3] *= -1 # Max X
 
         self.headerSizes[listIndex] = headerSize
         self.verticeCounts[listIndex] = vertexCount