Skip to content

Commit 3a539a8

Browse files
author
Greg Smith
committed
- fixed issue with pedal skins not being centred on 4.3B screen
- updated task list to remove completed items
1 parent 7dfb324 commit 3a539a8

File tree

5 files changed

+19
-21
lines changed

5 files changed

+19
-21
lines changed

TaskList.md

Lines changed: 3 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,31 +1,19 @@
1-
# Tonex One Controller: An open-source controller and display interface for the IK Multimedia Tonex One guitar pedal
1+
# Tonex One/Pedal/GP5 Controller: An open-source controller and display interface
22
# Task List
33

44
## Midi Mapping
55
Add the ability to map all 127 midi program change values to any preset.
66

7-
## 4.3B Parameter UI
8-
Add sliders for bass/Mid/Treble frequency, to the 4.3B UI.<br>
9-
Add values to sliders that update as the slider is dragged.
10-
Add units to parameters (db, Hz etc)<br>
11-
Need to port to EEZ Studio due to widget limit in Squareline.
12-
137
## Expression pedal support.
148
Use ADC to read expression pedal pot, and have config to assign what quantity it adjusts and min/max clamps.
15-
16-
## Direct Preset load from footswitch
17-
Add ability to load preset X from a footswitch press.<br>
9+
Possibility of I2C ADC for platforms that don't have spare pins.
1810

1911
## Support for multiple Bluetooth devices
2012
Allow at least two simultaneous BT devices to be connected.
2113

22-
## Amp and Pedal skins in same build
23-
Look at ways of adding amp and pedal skins to the same build.<br>
24-
Could be done by adding a new platform type, with the Cmake file including some of each.
25-
2614
## Midi Output support
2715
Add support for Midi output, sending Midi PC and CC messages to indicate to receivers the current state.
2816

29-
## Tonex USB disconect handling
17+
## USB disconnect handling
3018
If the pedal is diosconnected after being connected, the ESP32 needs a reboot in order to allow connection again.
3119
Review the de-init and init code to allow it to be handled without needing a reboot.

source/main/ui_generated_480x320land/screens.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -172,6 +172,7 @@ void create_screen_screen1() {
172172
lv_obj_set_size(obj, LV_SIZE_CONTENT, LV_SIZE_CONTENT);
173173
lv_img_set_src(obj, &img_skin_jcm);
174174
lv_img_set_zoom(obj, 192);
175+
lv_obj_clear_flag(obj, LV_OBJ_FLAG_SCROLLABLE|LV_OBJ_FLAG_SCROLL_ELASTIC|LV_OBJ_FLAG_SCROLL_MOMENTUM);
175176
lv_obj_set_style_align(obj, LV_ALIGN_CENTER, LV_PART_MAIN | LV_STATE_DEFAULT);
176177
}
177178
}

source/main/ui_generated_800x480land/screens.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -142,9 +142,11 @@ void create_screen_screen1() {
142142
// ui_SkinImage
143143
lv_obj_t *obj = lv_img_create(parent_obj);
144144
objects.ui_skin_image = obj;
145-
lv_obj_set_pos(obj, 32, 5);
145+
lv_obj_set_pos(obj, 14, 0);
146146
lv_obj_set_size(obj, LV_SIZE_CONTENT, LV_SIZE_CONTENT);
147147
lv_img_set_src(obj, &img_skin_jcm);
148+
lv_obj_clear_flag(obj, LV_OBJ_FLAG_SCROLLABLE|LV_OBJ_FLAG_SCROLL_ELASTIC|LV_OBJ_FLAG_SCROLL_MOMENTUM);
149+
lv_obj_set_style_align(obj, LV_ALIGN_CENTER, LV_PART_MAIN | LV_STATE_DEFAULT);
148150
}
149151
}
150152
}

ui_design_480x320land/Tonex_Controller_480_320.eez-project

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -821,7 +821,7 @@
821821
"widthUnit": "content",
822822
"heightUnit": "content",
823823
"children": [],
824-
"widgetFlags": "ADV_HITTEST|CLICK_FOCUSABLE|GESTURE_BUBBLE|PRESS_LOCK|SCROLLABLE|SCROLL_CHAIN_HOR|SCROLL_CHAIN_VER|SCROLL_ELASTIC|SCROLL_MOMENTUM|SCROLL_WITH_ARROW|SNAPPABLE",
824+
"widgetFlags": "ADV_HITTEST|CLICK_FOCUSABLE|GESTURE_BUBBLE|PRESS_LOCK|SCROLL_CHAIN_HOR|SCROLL_CHAIN_VER|SCROLL_WITH_ARROW|SNAPPABLE",
825825
"hiddenFlagType": "literal",
826826
"clickableFlagType": "literal",
827827
"flagScrollbarMode": "",

ui_design_800x480land/Tonex_Controller_800_480land.eez-project

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -735,8 +735,8 @@
735735
{
736736
"objID": "6fc4996f-3218-489d-8656-6cf54af710bf",
737737
"type": "LVGLImageWidget",
738-
"left": 32,
739-
"top": 5,
738+
"left": 14,
739+
"top": 0,
740740
"width": 397,
741741
"height": 133,
742742
"customInputs": [],
@@ -755,7 +755,7 @@
755755
"widthUnit": "content",
756756
"heightUnit": "content",
757757
"children": [],
758-
"widgetFlags": "ADV_HITTEST|CLICK_FOCUSABLE|GESTURE_BUBBLE|PRESS_LOCK|SCROLLABLE|SCROLL_CHAIN_HOR|SCROLL_CHAIN_VER|SCROLL_ELASTIC|SCROLL_MOMENTUM|SCROLL_WITH_ARROW|SNAPPABLE",
758+
"widgetFlags": "ADV_HITTEST|CLICK_FOCUSABLE|GESTURE_BUBBLE|PRESS_LOCK|SCROLL_CHAIN_HOR|SCROLL_CHAIN_VER|SCROLL_WITH_ARROW|SNAPPABLE",
759759
"hiddenFlagType": "literal",
760760
"clickableFlagType": "literal",
761761
"flagScrollbarMode": "",
@@ -766,7 +766,14 @@
766766
"disabledStateType": "literal",
767767
"states": "",
768768
"localStyles": {
769-
"objID": "7d6a09f1-f55a-403d-867c-fb6af66ba0b7"
769+
"objID": "7d6a09f1-f55a-403d-867c-fb6af66ba0b7",
770+
"definition": {
771+
"MAIN": {
772+
"DEFAULT": {
773+
"align": "CENTER"
774+
}
775+
}
776+
}
770777
},
771778
"group": "",
772779
"groupIndex": 0,

0 commit comments

Comments
 (0)