Info: UX report for dtg/dtg-lib crates

[qtfkwk]

If interested, I just replaced chrono and chrono-tz dependencies in my dtg and dtg-lib crates without issue!

• https://github.com/qtfkwk/dtg
• Commit
• Changes to lib/src/lib.rs
• Changes to cli/src/main.rs

Notable observations include a maximum timestamp of 253402207200 (9999-12-30T22:00:00Z); using chrono it was 8210266876799 (262142-12-31T23:59:59Z); but no deal breakers.

Please feel free to close this issue.

[BurntSushi]

Nice! I think you might be the first. :-)

Did you hit any problems during the migration? Did you find anything easier? Harder?

[qtfkwk]

tldr: the migration was pretty straightforward... would say it is slightly easier with jiff

Summary of changes I needed to apply from chrono to jiff:

• Replace use chrono::{offset::LocalResult, DateTime, Datelike, TimeZone, Timelike, Utc}; with pub use jiff::{tz::TimeZone, Timestamp}; (pub is due largely to needing these exposed for doctests/tests w/o another use)
• Replace DateTime<Utc> with Timestamp
• Replace Utc::now() with Timestamp::now()
• Replace Utc.timestamp_opt with Timestamp::new
• Replace if let LocalResult::Single(dt) = Utc.with_ymd_and_hms(y, v[4], v[3], v[2], v[1], v[0]) with if let Ok(dt) = format!("{y}-{:02}-{:02}T{:02}:{:02}:{:02}Z", v[4], v[3], v[2], v[1], v[0]).parse::<Timestamp>()
• Replace Tz with TimeZone
• Replace Tz::UTC with TimeZone::UTC
• Replace .format with .strftime
• Replace .with_timezone(tz) with .to_zoned(tz.clone())
• Replace .month0() with .month() as u8 - 1
• Replace .day0() with .day() as u8 -1
• Replace s.parse() with jiff::tz::db().get(s)
• Replace TZ_VARIANTS.iter() with jiff::tz::db().available()

Thanks, btw for this! (I'd been waiting/hoping for a newer datetime lib since chrono doesn't include timezones without chrono-tz, get the local timezone without iana-time-zone, and had security issues.)

[BurntSushi]

if let Ok(dt) = format!("{y}-{:02}-{:02}T{:02}:{:02}:{:02}Z", v[4], v[3], v[2], v[1], v[0]).parse::<Timestamp>()

For this, I think you can do:

let result = jiff::civil::Date::new(y, v[4], v[3]).and_then(|d| {
    Ok(d.to_datetime(jiff::civil::Time::new(v[2], v[1], v[0], 0)?))
}).and_then(|dt| dt.to_zoned(TimeZone::UTC)).map(|zdt| zdt.timestamp());
if let Ok(ts) = result { ... }

Although that is a bit of a mouthful! I'd probably split it out into a helper function so it could be written in a bit more of a linear fashion. But I do wonder if perhaps there should be some helper constructors on Zoned for cases like this.

[qtfkwk]

Cool! Applied it in dtg-lib 6.1.0 as a new Dtg::from_ymd_hms function... it isn't too bad after cleaning up my variables, etc. Thanks!

[lukehsiao]

FWIW: I also made the switch in openring-rs: lukehsiao/openring-rs@485fe4e

I wasn't using chrono extensively, and found it very straightforward.

[BurntSushi]

w00t! Thanks for the feedback. :-)