Merge pull request #27 from RafaelJohn9/fix/ReturnCode

fix: changed ResultCode and ResponseCode to have int | str type due t…

Author: RafaelJohn9

mpesa_sdk/C2B/schemas.py

@@ -181,7 +181,7 @@ class C2BValidationRequest(BaseModel):
 class C2BValidationResponse(BaseModel):
     """Schema for response to validation requests (accept/reject payment)."""
 
-    ResultCode: str = Field(..., description="0 to accept, error code to reject.")
+    ResultCode: int | str = Field(..., description="0 to accept, error code to reject.")
     ResultDesc: str = Field(..., description="Short description: Accepted or Rejected.")
     ThirdPartyTransID: Optional[str] = Field(
         None, description="Optional partner transaction ID."

mpesa_sdk/business_paybill/schemas.py

@@ -111,7 +111,7 @@ class BusinessPayBillResultMetadata(BaseModel):
     """Metadata for Business PayBill result notification."""
 
     ResultType: int = Field(..., description="Type of result (0=Success, 1=Failure).")
-    ResultCode: int = Field(..., description="Result code (0=Success).")
+    ResultCode: int | str = Field(..., description="Result code (0=Success).")
     ResultDesc: str = Field(..., description="Result description.")
     OriginatorConversationID: str = Field(
         ..., description="Originator conversation ID."

mpesa_sdk/tax_remittance/schemas.py

@@ -54,7 +54,7 @@ class TaxRemittanceResponse(BaseModel):
     ConversationID: Optional[str] = Field(
         ..., description="Unique ID for the transaction."
     )
-    ResponseCode: str = Field(..., description="Status code, 0 means success.")
+    ResponseCode: str | int = Field(..., description="Status code, 0 means success.")
     ResponseDescription: str = Field(..., description="Status message.")
 
     model_config = ConfigDict(
@@ -108,7 +108,7 @@ class TaxRemittanceResultMetadata(BaseModel):
     """Metadata for Tax Remittance result notification."""
 
     ResultType: int = Field(..., description="Type of result (0=Success, 1=Failure).")
-    ResultCode: int = Field(..., description="Result code (0=Success).")
+    ResultCode: int | str = Field(..., description="Result code (0=Success).")
     ResultDesc: str = Field(..., description="Result description.")
     OriginatorConversationID: str = Field(
         ..., description="Originator conversation ID."
@@ -192,7 +192,8 @@ class TaxRemittanceResultCallback(BaseModel):
 
     def is_successful(self) -> bool:
         """Check if the result indicates success."""
-        return self.Result.ResultCode == 0
+        code = str(self.Result.ResultCode)
+        return code.strip("0") == "" and code != ""
 
 
 class TaxRemittanceResultCallbackResponse(BaseModel):