refactor: used enums instead of passing actual values

Signed-off-by: rafaeljohn9 <rafaeljohb@gmail.com>

Author: RafaelJohn9

tests/integration/mpesa_ratiba/test_mpesa_ratiba_e2e.py

@@ -10,7 +10,13 @@
 from mpesa_sdk.auth import TokenManager
 from mpesa_sdk.http_client import MpesaHttpClient
 
-from mpesa_sdk.mpesa_ratiba import MpesaRatiba, StandingOrderRequest
+from mpesa_sdk.mpesa_ratiba import (
+    MpesaRatiba,
+    StandingOrderRequest,
+    FrequencyEnum,
+    TransactionTypeEnum,
+    ReceiverPartyIdentifierTypeEnum,
+)
 
 load_dotenv()
 pytestmark = pytest.mark.live
@@ -37,18 +43,14 @@ def test_mpesa_ratiba_e2e(mpesa_ratiba_service):
     start_date = os.getenv("MPESA_RATIBA_START_DATE", "20240905")
     end_date = os.getenv("MPESA_RATIBA_END_DATE", "20250905")
     business_short_code = os.getenv("MPESA_RATIBA_BUSINESS_SHORT_CODE", "174379")
-    transaction_type = os.getenv(
-        "MPESA_RATIBA_TRANSACTION_TYPE", "Standing Order Customer Pay Bill"
-    )
-    receiver_party_identifier_type = os.getenv(
-        "MPESA_RATIBA_RECEIVER_PARTY_IDENTIFIER_TYPE", "4"
-    )
+    transaction_type = TransactionTypeEnum.STANDING_ORDER_CUSTOMER_PAY_BILL
+    receiver_party_identifier_type = ReceiverPartyIdentifierTypeEnum.BUSINESS_SHORT_CODE
     amount = os.getenv("MPESA_RATIBA_AMOUNT", "4500")
     party_a = os.getenv("MPESA_RATIBA_PARTY_A", "254708374149")
     callback_url = os.getenv("MPESA_RATIBA_CALLBACK_URL", "https://mydomain.com/pat")
     account_reference = os.getenv("MPESA_RATIBA_ACCOUNT_REFERENCE", "Test")
     transaction_desc = os.getenv("MPESA_RATIBA_TRANSACTION_DESC", "BikeRepayment")
-    frequency = os.getenv("MPESA_RATIBA_FREQUENCY", "2")
+    frequency = FrequencyEnum.MONTHLY
 
     request = StandingOrderRequest(
         StandingOrderName=standing_order_name,

tests/unit/mpesa_ratiba/test_mpesa_ratiba.py

@@ -11,6 +11,9 @@
 
 from mpesa_sdk.mpesa_ratiba import (
     MpesaRatiba,
+    FrequencyEnum,
+    TransactionTypeEnum,
+    ReceiverPartyIdentifierTypeEnum,
     StandingOrderRequest,
     StandingOrderResponse,
     StandingOrderCallback,
@@ -45,14 +48,14 @@ def valid_standing_order_request():
         StartDate="20240905",
         EndDate="20250905",
         BusinessShortCode="174379",
-        TransactionType="Standing Order Customer Pay Bill",
-        ReceiverPartyIdentifierType="4",
+        TransactionType=TransactionTypeEnum.STANDING_ORDER_CUSTOMER_PAY_BILL,
+        ReceiverPartyIdentifierType=ReceiverPartyIdentifierTypeEnum.MERCHANT_TILL,
         Amount="4500",
         PartyA="254708374149",
         CallBackURL="https://mydomain.com/pat",
         AccountReference="Test",
         TransactionDesc="Electric Bike",
-        Frequency="2",
+        Frequency=FrequencyEnum.DAILY,
     )
 
 
@@ -172,14 +175,14 @@ def test_standing_order_request_invalid_date_format():
             StartDate="202423305",  # Invalid date
             EndDate="20250905",
             BusinessShortCode="174379",
-            TransactionType="Standing Order Customer Pay Bill",
-            ReceiverPartyIdentifierType="4",
+            TransactionType=TransactionTypeEnum.STANDING_ORDER_CUSTOMER_PAY_BILL,
+            ReceiverPartyIdentifierType=ReceiverPartyIdentifierTypeEnum.MERCHANT_TILL,
             Amount="4500",
             PartyA="254708374149",
             CallBackURL="https://mydomain.com/pat",
             AccountReference="Test",
             TransactionDesc="Electric Bike",
-            Frequency="2",
+            Frequency=FrequencyEnum.DAILY,
         )
     assert "Date must be in 'yyyymmdd' format" in str(excinfo.value)
 
@@ -192,14 +195,14 @@ def test_standing_order_request_invalid_date_value():
             StartDate="20241305",  # Invalid month
             EndDate="20250905",
             BusinessShortCode="174379",
-            TransactionType="Standing Order Customer Pay Bill",
-            ReceiverPartyIdentifierType="4",
+            TransactionType=TransactionTypeEnum.STANDING_ORDER_CUSTOMER_PAY_BILL,
+            ReceiverPartyIdentifierType=ReceiverPartyIdentifierTypeEnum.MERCHANT_TILL,
             Amount="4500",
             PartyA="254708374149",
             CallBackURL="https://mydomain.com/pat",
             AccountReference="Test",
             TransactionDesc="Electric Bike",
-            Frequency="2",
+            Frequency=FrequencyEnum.WEEKLY,
         )
     assert "Date must be in 'yyyymmdd' format" in str(excinfo.value)
 
@@ -211,14 +214,14 @@ def test_standing_order_request_other_date_value():
         StartDate="2024-12-05",  # With separators
         EndDate="20250905",
         BusinessShortCode="174379",
-        TransactionType="Standing Order Customer Pay Bill",
-        ReceiverPartyIdentifierType="4",
+        TransactionType=TransactionTypeEnum.STANDING_ORDER_CUSTOMER_PAY_BILL,
+        ReceiverPartyIdentifierType=ReceiverPartyIdentifierTypeEnum.MERCHANT_TILL,
         Amount="4500",
         PartyA="254708374149",
         CallBackURL="https://mydomain.com/pat",
         AccountReference="Test",
         TransactionDesc="Electric Bike",
-        Frequency="2",
+        Frequency=FrequencyEnum.MONTHLY,
     )
     assert request.StartDate == "20241205"  # Should normalize to yyyymmdd format
 
@@ -231,13 +234,13 @@ def test_invalid_phone_number():
             StartDate="20240905",
             EndDate="20250905",
             BusinessShortCode="174379",
-            TransactionType="Standing Order Customer Pay Bill",
-            ReceiverPartyIdentifierType="4",
+            TransactionType=TransactionTypeEnum.STANDING_ORDER_CUSTOMER_PAY_BILL,
+            ReceiverPartyIdentifierType=ReceiverPartyIdentifierTypeEnum.MERCHANT_TILL,
             Amount="4500",
             PartyA="123456789",  # Invalid phone number
             CallBackURL="https://mydomain.com/pat",
             AccountReference="Test",
             TransactionDesc="Electric Bike",
-            Frequency="2",
+            Frequency=FrequencyEnum.MONTHLY,
         )
     assert "Invalid PartyA phone number" in str(excinfo.value)