Commit 742f88f
authored
[task] fix: replace DataArguments with MyDataArguments and remove duplicated step2token saving (#189)
### What does this PR do?
Replace DataArguments with MyDataArguments and remove duplicated
step2token saving
> Add **concise** overview of what this PR aims to achieve or
accomplish. Reference related GitHub issues and PRs that help with the
review.
### Checklist Before Starting
- [x] Search for similar PRs. Paste at least one query link here: ...
- [x] Format the PR title as `[{modules}] {type}: {description}` (This
will be checked by the CI)
- `{modules}` include `misc`, `ci`, `config`, `docs`, `core`, `data`,
`dist`, `omni`, `logging`, `model`, `optim`, `ckpt`, `release`, `task`,
`
- If this PR involves multiple modules, separate them with `,` like
`[megatron, torch, liger-kernals,fsdp, doc]`
- `{type}` is in `feat`, `fix`, `refactor`, `chore`, `test`
- If this PR breaks any API (CLI arguments, config, function signature,
etc.), add `[BREAKING]` to the beginning of the title.
- Example: `[BREAKING][fsdp, torch, liger-kernals] feat: dynamic
batching`
### Test
> For changes that can not be tested by CI (e.g., algorithm
implementation, new model support), validate by experiment(s) and show
results like training curve plots, evaluation results, etc.
### API and Usage Example
> Demonstrate how the API changes if any, and provide usage example(s)
if possible.
```python
# Add code snippet or script demonstrating how to use this
```
### Design & Code Changes
> Demonstrate the high-level design if this PR is complex, and list the
specific changes.
### Checklist Before Submitting
> [!IMPORTANT]
> Please check all the following items before requesting a review,
otherwise the reviewer might deprioritize this PR for review.
- [x] Read the [Contribute
Guide](https://github.com/ByteDance-Seed/VeOmni/blob/main/CONTRIBUTING.md).
- [x] Apply [pre-commit
checks](https://github.com/ByteDance-Seed/VeOmni/blob/main/CONTRIBUTING.md?plain=1#L22):
`make commit && make style && make quality`
- [x] Add / Update [the
documentation](https://github.com/ByteDance-Seed/VeOmni/blob/main/docs).
- [x] Add unit or end-to-end test(s) to [the CI
workflow](https://github.com/ByteDance-Seed/VeOmni/tree/main/.github/workflows)
to cover all the code. If not feasible, explain why: ...1 parent 47a1f63 commit 742f88f
1 file changed
+1
-15
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
91 | 91 | | |
92 | 92 | | |
93 | 93 | | |
94 | | - | |
| 94 | + | |
95 | 95 | | |
96 | 96 | | |
97 | 97 | | |
| |||
438 | 438 | | |
439 | 439 | | |
440 | 440 | | |
441 | | - | |
442 | | - | |
443 | | - | |
444 | | - | |
445 | | - | |
446 | | - | |
447 | | - | |
448 | 441 | | |
449 | 442 | | |
450 | 443 | | |
| |||
465 | 458 | | |
466 | 459 | | |
467 | 460 | | |
468 | | - | |
469 | | - | |
470 | | - | |
471 | | - | |
472 | | - | |
473 | | - | |
474 | | - | |
475 | 461 | | |
476 | 462 | | |
477 | 463 | | |
| |||
0 commit comments