Load sound file on startup (cinnyapp#444)

ajbura · ajbura · commit 5cdad44abf69 · 2022-05-03T13:18:27.000+05:30
diff --git a/public/index.html b/public/index.html
@@ -18,5 +18,11 @@
 </head>
 <body id="appBody">
     <div id="root"></div>
+    <audio id="notificationSound">
+        <source src="./sound/notification.ogg" type="audio/ogg" />
+    </audio>
+    <audio id="inviteSound">
+        <source src="./sound/invite.ogg" type="audio/ogg" />
+    </audio>
 </body>
 </html>
diff --git a/src/client/state/Notifications.js b/src/client/state/Notifications.js
@@ -6,9 +6,6 @@ import cons from './cons';
 import navigation from './navigation';
 import settings from './settings';
 
-import NotificationSound from '../../../public/sound/notification.ogg';
-import InviteSound from '../../../public/sound/invite.ogg';
-
 function isNotifEvent(mEvent) {
   const eType = mEvent.getType();
   if (!cons.supportEventTypes.includes(eType)) return false;
@@ -238,14 +235,14 @@ class Notifications extends EventEmitter {
 
   _playNotiSound() {
     if (!this._notiAudio) {
-      this._notiAudio = new Audio(NotificationSound);
+      this._notiAudio = document.getElementById('notificationSound');
     }
     this._notiAudio.play();
   }
 
   _playInviteSound() {
     if (!this._inviteAudio) {
-      this._inviteAudio = new Audio(InviteSound);
+      this._inviteAudio = document.getElementById('inviteSound');
     }
     this._inviteAudio.play();
   }
diff --git a/src/index.scss b/src/index.scss
@@ -475,6 +475,10 @@ textarea {
                                   supported by Chrome, Edge, Opera and Firefox */
 }
 
+audio:not([controls]) {
+  display: none !important;
+}
+
 .flex--center {
   display: flex;
   justify-content: center;

Original file line number	Diff line number	Diff line change
`@@ -6,9 +6,6 @@ import cons from './cons';`
`6`	`6`	`import navigation from './navigation';`
`7`	`7`	`import settings from './settings';`
`8`	`8`
`9`		`-import NotificationSound from '../../../public/sound/notification.ogg';`
`10`		`-import InviteSound from '../../../public/sound/invite.ogg';`
`11`		`-`
`12`	`9`	`function isNotifEvent(mEvent) {`
`13`	`10`	`const eType = mEvent.getType();`
`14`	`11`	`if (!cons.supportEventTypes.includes(eType)) return false;`
`@@ -238,14 +235,14 @@ class Notifications extends EventEmitter {`
`238`	`235`
`239`	`236`	`_playNotiSound() {`
`240`	`237`	`if (!this._notiAudio) {`
`241`		`- this._notiAudio = new Audio(NotificationSound);`
	`238`	`+ this._notiAudio = document.getElementById('notificationSound');`
`242`	`239`	`}`
`243`	`240`	`this._notiAudio.play();`
`244`	`241`	`}`
`245`	`242`
`246`	`243`	`_playInviteSound() {`
`247`	`244`	`if (!this._inviteAudio) {`
`248`		`- this._inviteAudio = new Audio(InviteSound);`
	`245`	`+ this._inviteAudio = document.getElementById('inviteSound');`
`249`	`246`	`}`
`250`	`247`	`this._inviteAudio.play();`
`251`	`248`	`}`