feat: extract duplicate code into another helper

Author: Laertes87

tests/converters/assimp.test.ts

@@ -1,24 +1,7 @@
 import { test } from "bun:test";
 import { convert } from "../../src/converters/assimp.ts";
-import {
-  runConvertFailTest,
-  runConvertLogsStderror,
-  runConvertLogsStderrorAndStdout,
-  runConvertSuccessTest,
-} from "./helpers/converters.ts";
+import { runCommonTests } from "./helpers/commonTests.ts";
 
-test("convert resolves when execFile succeeds", async () => {
-  await runConvertSuccessTest(convert);
-});
+runCommonTests(convert);
 
-test("convert rejects when execFile fails", async () => {
-  await runConvertFailTest(convert);
-});
-
-test("convert logs stderr when present", async () => {
-  await runConvertLogsStderror(convert);
-});
-
-test("convert logs both stderr and stdout when present", async () => {
-  await runConvertLogsStderrorAndStdout(convert);
-});
+test.skip("dummy - required to trigger test detection", () => {});

tests/converters/calibre.test.ts

@@ -1,24 +1,7 @@
 import { test } from "bun:test";
 import { convert } from "../../src/converters/calibre.ts";
-import {
-  runConvertFailTest,
-  runConvertLogsStderror,
-  runConvertLogsStderrorAndStdout,
-  runConvertSuccessTest,
-} from "./helpers/converters.ts";
+import { runCommonTests } from "./helpers/commonTests.ts";
 
-test("convert resolves when execFile succeeds", async () => {
-  await runConvertSuccessTest(convert);
-});
+runCommonTests(convert);
 
-test("convert rejects when execFile fails", async () => {
-  await runConvertFailTest(convert);
-});
-
-test("convert logs stderr when present", async () => {
-  await runConvertLogsStderror(convert);
-});
-
-test("convert logs both stderr and stdout when present", async () => {
-  await runConvertLogsStderrorAndStdout(convert);
-});
+test.skip("dummy - required to trigger test detection", () => {});

tests/converters/dvisvgm.test.ts

@@ -2,34 +2,15 @@ import type { ExecFileException } from "node:child_process";
 import { beforeEach, expect, test } from "bun:test";
 import { convert } from "../../src/converters/dvisvgm.ts";
 import { ExecFileFn } from "../../src/converters/types.ts";
-import {
-  runConvertFailTest,
-  runConvertLogsStderror,
-  runConvertLogsStderrorAndStdout,
-  runConvertSuccessTest,
-} from "./helpers/converters.ts";
+import { runCommonTests } from "./helpers/commonTests.ts";
 
 let calls: string[][] = [];
 
 beforeEach(() => {
   calls = [];
 });
 
-test("convert resolves when execFile succeeds", async () => {
-  await runConvertSuccessTest(convert);
-});
-
-test("convert rejects when execFile fails", async () => {
-  await runConvertFailTest(convert);
-});
-
-test("convert logs stderr when present", async () => {
-  await runConvertLogsStderror(convert);
-});
-
-test("convert logs both stderr and stdout when present", async () => {
-  await runConvertLogsStderrorAndStdout(convert);
-});
+runCommonTests(convert);
 
 test("convert respects eps filetype", async () => {
   const originalConsoleLog = console.log;

tests/converters/graphicsmagick.test.ts

@@ -1,24 +1,7 @@
 import { test } from "bun:test";
 import { convert } from "../../src/converters/graphicsmagick.ts";
-import {
-  runConvertFailTest,
-  runConvertLogsStderror,
-  runConvertLogsStderrorAndStdout,
-  runConvertSuccessTest,
-} from "./helpers/converters.ts";
+import { runCommonTests } from "./helpers/commonTests.ts";
 
-test("convert resolves when execFile succeeds", async () => {
-  await runConvertSuccessTest(convert);
-});
+runCommonTests(convert);
 
-test("convert rejects when execFile fails", async () => {
-  await runConvertFailTest(convert);
-});
-
-test("convert logs stderr when present", async () => {
-  await runConvertLogsStderror(convert);
-});
-
-test("convert logs both stderr and stdout when present", async () => {
-  await runConvertLogsStderrorAndStdout(convert);
-});
+test.skip("dummy - required to trigger test detection", () => {});

tests/converters/helpers/commonTests.ts

@@ -0,0 +1,26 @@
+import { test } from "bun:test";
+import { ConvertFnWithExecFile } from "../../../src/converters/types.ts";
+import {
+  runConvertFailTest,
+  runConvertLogsStderror,
+  runConvertLogsStderrorAndStdout,
+  runConvertSuccessTest,
+} from "./converters.ts";
+
+export function runCommonTests(convert: ConvertFnWithExecFile) {
+  test("convert resolves when execFile succeeds", async () => {
+    await runConvertSuccessTest(convert);
+  });
+
+  test("convert rejects when execFile fails", async () => {
+    await runConvertFailTest(convert);
+  });
+
+  test("convert logs stderr when present", async () => {
+    await runConvertLogsStderror(convert);
+  });
+
+  test("convert logs both stderr and stdout when present", async () => {
+    await runConvertLogsStderrorAndStdout(convert);
+  });
+}

tests/converters/imagemagick.test.ts

@@ -2,34 +2,15 @@ import type { ExecFileException } from "node:child_process";
 import { beforeEach, expect, test } from "bun:test";
 import { convert } from "../../src/converters/imagemagick.ts";
 import { ExecFileFn } from "../../src/converters/types.ts";
-import {
-  runConvertFailTest,
-  runConvertLogsStderror,
-  runConvertLogsStderrorAndStdout,
-  runConvertSuccessTest,
-} from "./helpers/converters.ts";
+import { runCommonTests } from "./helpers/commonTests.ts";
 
 let calls: string[][] = [];
 
 beforeEach(() => {
   calls = [];
 });
 
-test("convert resolves when execFile succeeds", async () => {
-  await runConvertSuccessTest(convert);
-});
-
-test("convert rejects when execFile fails", async () => {
-  await runConvertFailTest(convert);
-});
-
-test("convert logs stderr when present", async () => {
-  await runConvertLogsStderror(convert);
-});
-
-test("convert logs both stderr and stdout when present", async () => {
-  await runConvertLogsStderrorAndStdout(convert);
-});
+runCommonTests(convert);
 
 test("convert respects ico conversion target type", async () => {
   const originalConsoleLog = console.log;

tests/converters/inkscape.test.ts

@@ -1,24 +1,7 @@
 import { test } from "bun:test";
 import { convert } from "../../src/converters/inkscape.ts";
-import {
-  runConvertFailTest,
-  runConvertLogsStderror,
-  runConvertLogsStderrorAndStdout,
-  runConvertSuccessTest,
-} from "./helpers/converters.ts";
+import { runCommonTests } from "./helpers/commonTests.ts";
 
-test("convert resolves when execFile succeeds", async () => {
-  await runConvertSuccessTest(convert);
-});
+runCommonTests(convert);
 
-test("convert rejects when execFile fails", async () => {
-  await runConvertFailTest(convert);
-});
-
-test("convert logs stderr when present", async () => {
-  await runConvertLogsStderror(convert);
-});
-
-test("convert logs both stderr and stdout when present", async () => {
-  await runConvertLogsStderrorAndStdout(convert);
-});
+test.skip("dummy - required to trigger test detection", () => {});

tests/converters/libheif.test.ts

@@ -1,24 +1,7 @@
 import { test } from "bun:test";
 import { convert } from "../../src/converters/libheif.ts";
-import {
-  runConvertFailTest,
-  runConvertLogsStderror,
-  runConvertLogsStderrorAndStdout,
-  runConvertSuccessTest,
-} from "./helpers/converters.ts";
+import { runCommonTests } from "./helpers/commonTests.ts";
 
-test("convert resolves when execFile succeeds", async () => {
-  await runConvertSuccessTest(convert);
-});
+runCommonTests(convert);
 
-test("convert rejects when execFile fails", async () => {
-  await runConvertFailTest(convert);
-});
-
-test("convert logs stderr when present", async () => {
-  await runConvertLogsStderror(convert);
-});
-
-test("convert logs both stderr and stdout when present", async () => {
-  await runConvertLogsStderrorAndStdout(convert);
-});
+test.skip("dummy - required to trigger test detection", () => {});

tests/converters/libjxl.test.ts

@@ -2,34 +2,15 @@ import type { ExecFileException } from "node:child_process";
 import { beforeEach, expect, test } from "bun:test";
 import { convert } from "../../src/converters/libjxl.ts";
 import { ExecFileFn } from "../../src/converters/types.ts";
-import {
-  runConvertFailTest,
-  runConvertLogsStderror,
-  runConvertLogsStderrorAndStdout,
-  runConvertSuccessTest,
-} from "./helpers/converters.ts";
+import { runCommonTests } from "./helpers/commonTests.ts";
 
 let command: string = "";
 
 beforeEach(() => {
   command = "";
 });
 
-test("convert resolves when execFile succeeds", async () => {
-  await runConvertSuccessTest(convert);
-});
-
-test("convert rejects when execFile fails", async () => {
-  await runConvertFailTest(convert);
-});
-
-test("convert logs stderr when present", async () => {
-  await runConvertLogsStderror(convert);
-});
-
-test("convert logs both stderr and stdout when present", async () => {
-  await runConvertLogsStderrorAndStdout(convert);
-});
+runCommonTests(convert);
 
 test("convert uses djxl with input filetype being jxl", async () => {
   const originalConsoleLog = console.log;

tests/converters/potrace.test.ts

@@ -1,24 +1,7 @@
 import { test } from "bun:test";
 import { convert } from "../../src/converters/potrace.ts";
-import {
-  runConvertFailTest,
-  runConvertLogsStderror,
-  runConvertLogsStderrorAndStdout,
-  runConvertSuccessTest,
-} from "./helpers/converters.ts";
+import { runCommonTests } from "./helpers/commonTests.ts";
 
-test("convert resolves when execFile succeeds", async () => {
-  await runConvertSuccessTest(convert);
-});
+runCommonTests(convert);
 
-test("convert rejects when execFile fails", async () => {
-  await runConvertFailTest(convert);
-});
-
-test("convert logs stderr when present", async () => {
-  await runConvertLogsStderror(convert);
-});
-
-test("convert logs both stderr and stdout when present", async () => {
-  await runConvertLogsStderrorAndStdout(convert);
-});
+test.skip("dummy - required to trigger test detection", () => {});