Skip to content

Commit c80856c

Browse files
committed
Extract exception messqge
1 parent 08a44f2 commit c80856c

File tree

2 files changed

+7
-6
lines changed
  • community-rust-plugin/src

2 files changed

+7
-6
lines changed

community-rust-plugin/src/main/java/org/elegoff/plugins/communityrust/coverage/lcov/LCOVParser.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,8 @@ private void parseLineCoverage(FileContent fileContent, int linum, String line)
143143
}
144144

145145
private void logMismatch(String dataType, int linum, Exception e) {
146-
LOG.debug("Error while parsing LCOV report: can't save {} data for line {} of coverage report file ({}).", dataType, linum, e.toString());
146+
String msg = e.getMessage();
147+
LOG.debug("Error while parsing LCOV report: can't save {} data for line {} of coverage report file ({}).", dataType, linum, msg);
147148
pbCount++;
148149
}
149150

community-rust-plugin/src/test/java/org/elegoff/plugins/communityrust/coverage/lcov/LCOVSensorTest.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -127,10 +127,10 @@ void should_ignore_and_log_warning_for_invalid_line() {
127127
assertThat(context.coveredConditions("moduleKey:file1.rs", 2)).isEqualTo(1);
128128

129129
assertThat(logTester.logs(Level.DEBUG)).contains(
130-
"Error while parsing LCOV report: can't save DA data for line 3 of coverage report file (java.lang.IllegalArgumentException: Line number 0 doesn't exist in file file1.rs).");
130+
"Error while parsing LCOV report: can't save DA data for line 3 of coverage report file (Line number 0 doesn't exist in file file1.rs).");
131131

132132
assertThat(logTester.logs()).contains(
133-
"Error while parsing LCOV report: can't save BRDA data for line 8 of coverage report file (java.lang.IllegalArgumentException: Line number 102 doesn't exist in file file1.rs).");
133+
"Error while parsing LCOV report: can't save BRDA data for line 8 of coverage report file (Line number 102 doesn't exist in file file1.rs).");
134134
}
135135

136136
@Test
@@ -168,12 +168,12 @@ void should_log_warning_when_wrong_data() throws Exception {
168168
assertThat(context.coveredConditions("moduleKey:file1.rs", 2)).isEqualTo(2);
169169

170170
assertThat(logTester.logs(Level.DEBUG))
171-
.contains("Error while parsing LCOV report: can't save DA data for line 3 of coverage report file (java.lang.NumberFormatException: For input string: \"1.\").");
171+
.contains("Error while parsing LCOV report: can't save DA data for line 3 of coverage report file (For input string: \"1.\").");
172172
String stringIndexOutOfBoundLogMessage = logTester.logs(Level.DEBUG).get(1);
173173
assertThat(stringIndexOutOfBoundLogMessage)
174-
.startsWith("Error while parsing LCOV report: can't save DA data for line 3 of coverage report file (java.lang.NumberFormatException:");
174+
.startsWith("Error while parsing LCOV report: can't save DA data for line 3 of coverage report file (For input string: \"1.\").");
175175
assertThat(logTester.logs(Level.DEBUG).get(logTester.logs(Level.DEBUG).size() - 1))
176-
.startsWith("Error while parsing LCOV report: can't save BRDA data for line 6 of coverage report file (java.lang.ArrayIndexOutOfBoundsException: ");
176+
.startsWith("Error while parsing LCOV report: can't save BRDA data for line 6 of coverage report file (Index 3 out of bounds for length 3)");
177177
assertThat(logTester.logs(Level.WARN)).contains("Found 3 inconsistencies in coverage report");
178178
}
179179

0 commit comments

Comments
 (0)